- Issue created by @kunalkursija
- š¬š§United Kingdom longwave UK
The preview endpoint could probably return additional data to achieve this.
- š§šŖBelgium wim leers Ghent š§šŖšŖšŗ
I think it's not the
experience_builder.api.previewroute that should provide that info, butexperience_builder.experience_builderitself? š¤Because:
experience_builder.experience_builderis requested once, and the information should be retrieved thenexperience_builder.experience_builderis requested N times (once per component placement/props change), and it is completely unaware of the underlying content entity being edited
But perhaps @longwave sees a reason for using
experience_builder.api.previewthat I'm missing? š¤ - š¬š§United Kingdom longwave UK
If the user changes the page title inside XB, should it update immediately (ie. on preview)?
- š«š®Finland lauriii Finland
The page title should update automatically as it's being changed.
- š¬š§United Kingdom longwave UK
I guess another question is what should be displayed here: just the entity title/label? Or the HTML
<head>title? - š«š®Finland lauriii Finland
That's a good question. I think it should be just the entity title/label since that's what we would be using for referring to the page else where.
- š®š³India anjali rathod India
I will be working on the API part of this issue and then my colleague parthbcharya will take over the FE work. Iām unclear about which API to use for my current task in experience_builder. Should I leverage an existing API route, extend one of the current routes, or consider creating a new API from scratch?
Iād appreciate some guidance to understand the best approach for this scenario.
- š¬š§United Kingdom longwave UK
Given the discussion in #7-11 I still think the preview endpoint is the best place to add this to the API.
I suggest adding the title to the JSON response in
XBPreviewRenderer::renderResponse(); it looks like we might be able to capture the title inprepare(). - Merge request !496Issue #3489106: Created a function for returning key value pairs of entity title and status ā (Merged) created by Unnamed author
- š®š³India anjali rathod India
Need review for the API related changes made by me, so that @parthbcharya can then continue working with these changes for React code part.
- š¬š§United Kingdom longwave UK
While I agree we want to refactor this in the near future in š Support additional top-level data in returns from ApiPreviewController Active I think this is OK for now, but it would be good to add at least two assertions to
ApiPreviewControllerTestto prove that the entity title and status are returned.If š Support additional top-level data in returns from ApiPreviewController Active lands first then this will need refactoring to match the changes there.
- š«š®Finland lauriii Finland
Merged š Support additional top-level data in returns from ApiPreviewController Active .
@anjali rathod Could you reimplement the API to utilize the new API?
- First commit to issue fork.
- š¦šŗAustralia larowlan š¦šŗš.au GMT+10
I've pushed a rebase on top of 0.x making use of the new functionality from MR 420 and added a test.
This is ready for the FE implementation now.
I would suggest this goes in its own slice and makes use of onQueryStarted in the preview API to pluck out the values and dispatch the reducer to update the slice - š³š±Netherlands balintbrews Amsterdam, NL
Let's create a UI component (or set of UI components) and present them in Storybook. We'll need to display the currently focused global region in āØ Focus mode for global regions Active . Whichever issue gets to implementing a UI component earlier, let's anticipate each others' needs with the component design. š
- š§šŖBelgium wim leers Ghent š§šŖšŖšŗ
Thanks for explaining the rationale, @anjali rathod ā I was thinking about not making this too narrow, and I've now clarified that in the MR comments.
I think that between my response and @balintbrews' at #24, you have all you need here to proceed? š
- Assigned to parthbcharya
- Status changed to Needs review
3 months ago 11:04am 22 January 2025 - š¬š§United Kingdom longwave UK
This appears to be duplicating what is being done in core in š [PP1] Show entity information on the Top Bar Postponed
- š«š®Finland lauriii Finland
What's being done in š [PP1] Show entity information on the Top Bar Postponed is for the top bar when visiting the site frontend / current edit form. What we're supposed to be doing here is doing the same but within XB. These need to be sync but it shouldn't be duplicated effort.
- šŗšøUnited States mglaman WI, USA
Going to help push this through over the finish line
- šŗšøUnited States mglaman WI, USA
MR approved! here's my attempt at issue credits, other maintainers fix as needed!
-
mglaman ā
committed d87bb121 on 0.x authored by
anjali rathod ā
Issue #3489106 by mglaman, parthbcharya, anjali rathod, larowlan,...
-
mglaman ā
committed d87bb121 on 0.x authored by
anjali rathod ā
- šŗšøUnited States mglaman WI, USA
Woo! We're unblocked to build the in-editor page navigation.
- š§šŖBelgium wim leers Ghent š§šŖšŖšŗ
Wow, the merged MR looks nothing like what I reviewed a month ago: no more server-side changes!
- šŗšøUnited States hooroomoo
Updated issue summary to remove "fetching from API" from the proposed solution, since the solution changed to use the selectPageData selector instead.
Automatically closed - issue fixed for 2 weeks with no activity.
