- Issue created by @larowlan
- ๐ฆ๐บAustralia larowlan ๐ฆ๐บ๐.au GMT+10
This would also help https://git.drupalcode.org/project/experience_builder/-/merge_requests/496
- ๐ฌ๐งUnited Kingdom longwave UK
Two nits but otherwise this looks good to me and unblocks at least three other issues.
- First commit to issue fork.
-
lauriii โ
committed 8e065810 on 0.x authored by
larowlan โ
Issue #3494348 by larowlan, longwave: Support additional top-level data...
-
lauriii โ
committed 8e065810 on 0.x authored by
larowlan โ
- ๐ซ๐ฎFinland lauriii Finland
Merging to unblock โจ Show page information in top bar Active .
Automatically closed - issue fixed for 2 weeks with no activity.
- ๐ง๐ชBelgium wim leers Ghent ๐ง๐ช๐ช๐บ
wim leers โ made their first commit to this issueโs fork.
- ๐ง๐ชBelgium wim leers Ghent ๐ง๐ช๐ช๐บ
๐คฉ
final class PreviewEnvelope
AFAICT
XBPreviewRenderer
now is no longer a main content renderer (aMainContentRendererInterface
implementation that is arender.main_content_renderer
-tagged service), nor does it need to be a (private) service, because nothing uses?_wrapper_format=xb_preview
anymore? ๐คI wanted to merge the logic in
\Drupal\experience_builder\Render\MainContent\XBPreviewRenderer
into\Drupal\experience_builder\EventSubscriber\PreviewEnvelopeViewSubscriber
, but turns out that's not easily possible because we want to maximally reuse\Drupal\Core\Render\MainContent\HtmlRenderer
logic.So, proposed an MR to clarify that.
-
wim leers โ
committed 10345778 on 0.x
Issue #3494348 by larowlan, wim leers, longwave: Support additional top-...
-
wim leers โ
committed 10345778 on 0.x
Automatically closed - issue fixed for 2 weeks with no activity.