- Issue created by @lauriii
- ๐ง๐ชBelgium Wim Leers Ghent ๐ง๐ช๐ช๐บ
We can use hard-coded images for the purposes of the demo, before we have implemented #3462636: Auto-generating component preview images.
IMHO that'd be a waste of time, because those images would be more of a pain to generate than implementing #3462636-2: Auto-generating component preview images โ ?
- Status changed to Postponed
about 2 months ago 11:08am 23 July 2024 - ๐ง๐ชBelgium Wim Leers Ghent ๐ง๐ช๐ช๐บ
More importantly:
Sections are pre-configured compositions of components (i.e. a tree of components with some pre-defined content). How sections are different from components is that content creators are able to de-compose them, unlike components where content creators can only interact with the properties and slots provided by the component.
I am still very worried that "a section" is ambiguously defined, #3455036 exists to clarify that (and has been open for a month now). See #3455036-13: [research] Clarify "components" vs "elements" vs "patterns" โ , where I explained that we need this to be documented first, so that all these UI implementation issues can refer to that to get clarifications/answers without needing to talk to you.
- ๐ซ๐ฎFinland lauriii Finland
#2: I agree we should not implement a backend API for this because we know it would be replaced by the auto-generated images. This would be only in the scope of the client implementation. FWIW, I created this issue with @jessebaker and he didn't raise concerns over this approach. Maybe he can explicitly confirm if he thinks it's okay to keep both of these issues to be actionable in parallel.
#3: Can you point out what are the remaining questions in regards to sections? To me it seems that it's pretty clear what sections are in comparison to components and elements. My perception is that what's remaining in relation to sections is making sure that section as a term makes sense. If naming is all that's remaining to be clarified, I'm not sure we should make it a blocker to this.
- ๐ง๐ชBelgium Wim Leers Ghent ๐ง๐ช๐ช๐บ
#4 RE: #3: Let's continue this discussion in the issue that exists for specifically this purpose: #3455036-17: [research] Clarify "components" vs "elements" vs "patterns" โ .
- Assigned to jessebaker
- Status changed to Needs review
about 1 month ago 11:37am 8 August 2024 - ๐ง๐ชBelgium Wim Leers Ghent ๐ง๐ช๐ช๐บ
As described in #2, โจ Preview component when selecting in left sidebar Fixed landed, so that's one fewer blocker ๐
But โฆ the closely related ๐ Implement add button for top level item (section) Fixed landed already. How does that affect this issue's scope? Tagging , because AFAICT there's nothing blocking this anymore? ๐ค Assigning to front-end lead @jessebaker to get clarity on that.
- First commit to issue fork.
- Status changed to Active
25 days ago 12:17pm 14 August 2024 - Merge request !170#3463300: Implement the concept of sections within the client โ (Merged) created by jessebaker
- ๐ญ๐บHungary balintk
balintbrews โ made their first commit to this issueโs fork.
- Assigned to balintk
- ๐ญ๐บHungary balintk
I posted a todo list in the MR description based on my assessment of the remaining work.
- ๐ญ๐บHungary balintk
From the list of remaining work:
Review and potentially revisit how preview thumbnails for the listed components and sections in
ListItem.tsx
are rendered. There is a failing test currently inxb-general.cy.js
that seems to be showing a real bug. Plus, this might be a good opportunity to figure out how those preview thumbnails will play nicely with overflow: scroll added in ๐ No upward auto-scroll when components are dragged Needs review .I now consider this item done โ or at least something that doesn't require more action in this MR. I realized that the test failure also frequently happens in
0.x
, so it is not being introduced by this MR. We're better off opening a separate issue to address it. The preview thumbnails were fixed in ๐ Unable to scroll component list Fixed by rendering them in a portal. I carried out the same change here in3471102
, since this MR refactors the component where this was previously added.I also marked error handling tasks as done (and with strikethrough) after realizing that it is work all the methods could use in those files, and it doesn't make sense to just do it for the couple of new ones this MR adds. We should target them all at once at one point.
- Assigned to bnjmnm
- Status changed to Needs review
6 days ago 11:20pm 1 September 2024 - ๐ญ๐บHungary balintk
This is now ready for a review. @jessebaker had already done all the heavy lifting, so I approved the MR, and I really would like @bnjmnm's review before we merge.
- Assigned to jessebaker
- Status changed to RTBC
4 days ago 12:53pm 4 September 2024 - ๐ง๐ชBelgium Wim Leers Ghent ๐ง๐ช๐ช๐บ
The back-end side LGTM now :)
AFAICT
_Nice to have:_ Refactor `layoutModelSlice.ts::replaceUUIDsAndUpdateModel()` and `layoutModelSlice.ts::insertMultipleNodes()`, make them unit testable, then write unit tests
is not yet addressed.
That's fine: it's a nice-to-have. Can we extract a follow-up issue for that, and have a less experienced team member take that on? ๐
-
jessebaker โ
committed 3d41e58f on 0.x
Issue #3463300 by jessebaker, balintbrews, wim leers: Implement the...
-
jessebaker โ
committed 3d41e58f on 0.x
- Issue was unassigned.
- Status changed to Fixed
3 days ago 1:23pm 4 September 2024 - ๐ฌ๐งUnited Kingdom jessebaker
All fixed! Hooray!
Follow up to address that last nice to have is created here: ๐ Improve/Refactor replaceUUIDsAndUpdateModel() and insertMultipleNodes() Active .
- ๐บ๐ธUnited States Kristen Pol Santa Cruz, CA, USA
I see the "Fake Section 2" section listed now.
- Will there be other sections created for Barcelona?
- Is SDDS supposed to create sections?
- How do you create sections? Is there documentation?
- ๐ซ๐ฎFinland lauriii Finland
@kristen pol I responded in #3454125-88: Implement temporary design system for the DrupalCon Barcelona demo โ ๐