Only run XbTwigExtension inside XBPreviewRenderer

… 

This should be feasible to do at any time, actually; it's not urgent because AFAICT it's low-risk.

Thanks, @roshni upadhyay!

Hi @wim leers, The wrapper comments in the rendered output are being added by both the Component and ComponentTreeHydrated classes. I wanted to check if the XbTwigExtension is actively being used, or if we can directly handle the wrapper comments logic within the Component and ComponentTreeHydrated classes instead.

Could you please guide me on whether we should continue using XbTwigExtension or refactor the logic to manage these comments directly within the respective classes?

Just to keep this one moving along, I've started to update some of the tests, had a lot of failures before, lets see how this run goes

Well on its way, the test coverage you added is excellent, @danielveza — thanks! 😄

Made some progress on this today, assigning to me to wrap up

Clarify issue title. Thanks, @danielveza!

Actually, this only affects \Drupal\experience_builder\Plugin\ExperienceBuilder\ComponentSource\SingleDirectoryComponent, so it belongs under 🌱 [META] Production-ready ComponentSource plugins Active , not 🌱 [META] Production-ready client-side data model + internal HTTP API Active .

This will need test coverage for \Drupal\experience_builder\Plugin\ExperienceBuilder\ComponentSource\SingleDirectoryComponent::renderComponent() with isPreview: true|false, which we de facto have now:

• \Drupal\Tests\experience_builder\Kernel\Plugin\ExperienceBuilder\ComponentSource\SingleDirectoryComponentTest::testRenderComponentLive() tests with isPreview: TRUE
• \Drupal\Tests\experience_builder\Kernel\Plugin\ExperienceBuilder\ComponentSource\SingleDirectoryComponentTest::testGetClientSideInfo() tests with isPreview: FALSE

Per #3473761-15: [PP-1] Render a placeholder DIV inside empty Regions/Slots in the preview → , this blocks that.

This MR is not yet updating \Drupal\experience_builder\Extension\XbWrapperNode and friends, but I'd be happy to land the current MR first — it just needs the test expectations to be updated now 🤓

@wimleers - I have pushed changes to the tests, and removed the test that was added "simplest component tree with nesting (Non preview)" as I believe it is now a duplicate of "simplest component tree with nesting" which tests "non preview" and "simplest component tree with nesting in preview" which tests in the preview. Everything looks to now be passing.

As mentioned I'll next need to look at \Drupal\experience_builder\Extension\XbWrapperNode and update to only show the HTML comments when previewing.

Looks like this is on the right track, thanks! 👍

Your test expectation changes revealed a bug in \Drupal\experience_builder\Entity\Pattern::normalizeForClientSide() though, which I posted a one-liner fix for on the MR 😄

Have pushed an update to remove the other HTML comments, unsure if this is the right track or not. Does look like a number of tests are failing though.

Reviewed and LGTM. Assigning to Wim for sign-off.

X-posted 😇

Truly great work here, @thoward216! Especially retaining test simplicity and hence DX, and your much simpler approach than what I proposed in the issue summary 👏

Also very nice to see @isholgueras' work at 📌 ComponentSource robustness: add `ComponentSourceTestBase::testSettings()` Active paying off here :)

Approved the MR, with 3 bits of missing test coverage that are trivial to add:

1. https://git.drupalcode.org/project/experience_builder/-/merge_requests/8...
2. https://git.drupalcode.org/project/experience_builder/-/merge_requests/8...
3. https://git.drupalcode.org/project/experience_builder/-/merge_requests/8...

As soon as those 3 are addressed, feel free to merge yourself 😄

Committed to 0.x thanks!

Automatically closed - issue fixed for 2 weeks with no activity.