Minnesota, USA
Account created on 16 March 2010, over 14 years ago
#

Merge Requests

Recent comments

πŸ‡ΊπŸ‡ΈUnited States mtift Minnesota, USA

Looks even better in camelCase!

πŸ‡ΊπŸ‡ΈUnited States mtift Minnesota, USA
πŸ‡ΊπŸ‡ΈUnited States mtift Minnesota, USA

Good call. I added the change record.

πŸ‡ΊπŸ‡ΈUnited States mtift Minnesota, USA

Going forward, the process for validating these config actions will need to be sorted out. It's not clear (to me at least) how strict they should be, or if a recipe should be applied when the config action refers to things that don't (yet?) exist. But this issue is probably not the place to have that conversation.

This plugin works to do something like this (with the minimal profile installed):

name: 'Place a block'
config:
actions:
block.block.whatever:
place_block:
id: minimal_test
theme: default
region: sidebar_second
weight: -10
plugin: system_powered_by_block
visibility: { }

The tests cover other situations, and the PlaceBlock class does a lot of checking already.

This looks great to me. Nice work, @madclu!

πŸ‡ΊπŸ‡ΈUnited States mtift Minnesota, USA

Makes sense to me. In conversations at DrupalCon and the recent Starshot webinars (Zoom) meetings I think pretty much everyone who mentioned this initiative called it "Recipes." I don't hear people saying "Distributions and Recipes" so it make sense for the name to match what people are saying.

πŸ‡ΊπŸ‡ΈUnited States mtift Minnesota, USA

I'm pretty sure the intention of the change (with the commit message "Example") was to demonstrate a test failure.

πŸ‡ΊπŸ‡ΈUnited States mtift Minnesota, USA

mtift β†’ created an issue.

πŸ‡ΊπŸ‡ΈUnited States mtift Minnesota, USA

That was it. Thank you @smustgrave!

FWIW, this looks good to me, too.

πŸ‡ΊπŸ‡ΈUnited States mtift Minnesota, USA

@alexpott I don't see any comments. Did you add them on https://git.drupalcode.org/project/drupal/-/merge_requests/7910?

πŸ‡ΊπŸ‡ΈUnited States mtift Minnesota, USA

This one makes sense to me. All of the reply & redirect issues have been addressed per https://www.drupal.org/node/3452650 β†’ . The deprecation messages and tests make sense. The feedback has been addressed.

However, I applied the MR on a standard install for 11.x with config inspector and got all green checks, but it shows "1 errors" and I'm not quite sure what that is referring to:

πŸ‡ΊπŸ‡ΈUnited States mtift Minnesota, USA

So if "every config entity type MUST allow NULL to be set on any class property corresponding to a top-level config entity property" would the implication be that:

  protected array $settings = [];

Gets interpreted as:

  protected array|null $settings = [];

That seems confusing to me.

πŸ‡ΊπŸ‡ΈUnited States mtift Minnesota, USA

Yes, yes, yes! I fully support this proposal. +1

πŸ‡ΊπŸ‡ΈUnited States mtift Minnesota, USA
πŸ‡ΊπŸ‡ΈUnited States mtift Minnesota, USA

mtift β†’ made their first commit to this issue’s fork.

πŸ‡ΊπŸ‡ΈUnited States mtift Minnesota, USA

mtift β†’ created an issue.

πŸ‡ΊπŸ‡ΈUnited States mtift Minnesota, USA

I think I got them all

πŸ‡ΊπŸ‡ΈUnited States mtift Minnesota, USA

Since I'm doing issue queue maintenance, it was suggested that I mark a credit for myself. So I'll do that here.

πŸ‡ΊπŸ‡ΈUnited States mtift Minnesota, USA

I don't see any code changes here

πŸ‡ΊπŸ‡ΈUnited States mtift Minnesota, USA

Committed to 8.x-1.x

πŸ‡ΊπŸ‡ΈUnited States mtift Minnesota, USA

Code looks good, and I can confirm that the patch works. With Upgrade Status enabled and the patch applied, I see this:

πŸ‡ΊπŸ‡ΈUnited States mtift Minnesota, USA

Thanks, all. Committed to 8.x-3.x.

πŸ‡ΊπŸ‡ΈUnited States mtift Minnesota, USA

@geekygnr I don't understand why you moved development to GitHub. What does that have to do with "time constraints"?

πŸ‡ΊπŸ‡ΈUnited States mtift Minnesota, USA

Whoops, let's try that again

πŸ‡ΊπŸ‡ΈUnited States mtift Minnesota, USA

mtift β†’ made their first commit to this issue’s fork.

πŸ‡ΊπŸ‡ΈUnited States mtift Minnesota, USA

I'm not sure why it's anonymous, but your patch fixes the problem and the code makes sense to me. Thanks, @webflo!

Production build 0.69.0 2024