- Issue created by @penyaskito
- Status changed to Needs work
over 1 year ago 9:50pm 19 July 2023 - πͺπΈSpain penyaskito Seville π, Spain πͺπΈ, UTC+2 πͺπΊ
WIP
- πͺπΈSpain penyaskito Seville π, Spain πͺπΈ, UTC+2 πͺπΊ
Most of this patch was paired between Pablo and me.
This adds a way to select which blocks should be shown without layout builder.
While working on it, we discovered that probably we want to have something more similar to views displays, were you can drag stuff between a content and a disabled region, aside of setting the weights. That would be far more usable than the checkboxes that this patch provides.Also, we still need to figure out how I would store and configure the block instances themselves, which is something that is completly ignored by this patch.
Also, we are rendering the blocks, but we still need to figure out the instance values, and also decide how we render title of the block et al (which might be related with the previous pending task)
- πͺπΈSpain penyaskito Seville π, Spain πͺπΈ, UTC+2 πͺπΊ
This patch allows to change between choosing blocks and layout builder integrations by replacing the entity class when layout builder is enabled.
- πͺπΈSpain plopesc Valladolid
Reviewed last patch and looks good!
As you mentioned, we need to figure out the UI to setup the block specific properties, and how to store them.
I made some research on trying to replicate the same structure used by Layout Builder to reuse existing bits, but it turned out that the config schema and the way sections are rendered is part of layout builder itself.
So, I believe we might need to add a different key in
dashboard.schema.yml
file to store the list of blocks. Also we might need to have a differentDashboardController
class, or create an abstraction layer to render the dashboard entity in one way or the other depending on the presence of layout_builder module.Regards
- Merge request !6Issue #3375577 by plopesc, penyaskito, mtift: Dashboard shouldn't depend on layout builder β (Merged) created by plopesc
- Status changed to Needs review
8 months ago 9:47am 22 March 2024 - πͺπΈSpain plopesc Valladolid
Updated MR with the basic functionality to manage the different logic depending on the existence of layout_builder module.
- πͺπΈSpain penyaskito Seville π, Spain πͺπΈ, UTC+2 πͺπΊ
I won't nitpick, I think this is the way to go if what you wanted is confirmation. Great work!
- πͺπΈSpain plopesc Valladolid
Thank you for your review @penyaskito
Cleaned up the code a bit and fixed all the code quality and functional tests.
We might need a more in deep review if you consider it appropriate and determine whether we should refactor tests to cover both Block and Layout Builder as part of this issue or as follow-ups.
Thank you!
- πΊπΈUnited States mtift Minnesota, USA
penyaskito β credited mtift β .
- πͺπΈSpain penyaskito Seville π, Spain πͺπΈ, UTC+2 πͺπΊ
Updating credit
-
penyaskito β
committed ed2d2e6c on 2.x authored by
plopesc β
Issue #3375577 by plopesc, penyaskito, mtift: Dashboard shouldn't depend...
-
penyaskito β
committed ed2d2e6c on 2.x authored by
plopesc β
- Status changed to Fixed
7 months ago 8:35am 27 April 2024 - πͺπΈSpain penyaskito Seville π, Spain πͺπΈ, UTC+2 πͺπΊ
Merged for the glory. THANKS A TON.
- πͺπΈSpain penyaskito Seville π, Spain πͺπΈ, UTC+2 πͺπΊ
Will be reverted in π Dashboard should build on top of the new experience builder initiative (revert ed2d2e6c) Active
Automatically closed - issue fixed for 2 weeks with no activity.