Move my_own_drafts View to optional config

Created on 8 February 2024, about 1 year ago
Updated 17 September 2024, 7 months ago

Problem/Motivation

The "My own drafts" View gets installed when enabling the dashboard module. However, it persists when disabling the module, and an error is thrown if the module is re-enabled. The Dashboard module also has no other dependencies on the Views module, so by moving this config to optional, we can remove Views as a dependency.

Steps to reproduce

  1. Enable the module
  2. Disable the module
  3. Try to re-enable the module
  4. Observe error
πŸ› Bug report
Status

Postponed

Version

2.0

Component

Code

Created by

πŸ‡ΊπŸ‡ΈUnited States jayhuskins

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Merge Requests

Comments & Activities

  • Issue created by @jayhuskins
  • Status changed to Needs review about 1 year ago
  • πŸ‡ΊπŸ‡ΈUnited States jayhuskins
  • Pipeline finished with Success
    about 1 year ago
    Total: 196s
    #90853
  • πŸ‡ͺπŸ‡ΈSpain penyaskito Seville πŸ’ƒ, Spain πŸ‡ͺπŸ‡Έ, UTC+2 πŸ‡ͺπŸ‡Ί

    This LGTM, but as this is simpler to recreate than the other views-related issues I'll defer merging this.

  • Status changed to RTBC about 1 year ago
  • πŸ‡ͺπŸ‡ΈSpain penyaskito Seville πŸ’ƒ, Spain πŸ‡ͺπŸ‡Έ, UTC+2 πŸ‡ͺπŸ‡Ί
  • πŸ‡ΊπŸ‡ΈUnited States mtift Minnesota, USA

    Making this view optional seems like a good idea to me. On the other hand, now that we have Recipes in core, we might want this to be included in the module as a Recipe (or part of a recipe) in the module and included, for example, with a "content editor" Dashboard.

  • πŸ‡ΊπŸ‡ΈUnited States thejimbirch Cape Cod, Massachusetts

    Modules can't contain recipes. The idea is a good one, but the recipe would be independent of this module.

    Why? Recipes can only live in a single place (with the exception of core's recipes which are special cased. Unlike modules which can be in a number of places, recipes all need to be in the same folder. It's been determined that the best place for recipes is above the webroot in a folder called /recipes.

    If you did go the recipes route, the content_editor_dashboard would install the dashboard and views modules and required dependencies.

  • πŸ‡ͺπŸ‡ΈSpain penyaskito Seville πŸ’ƒ, Spain πŸ‡ͺπŸ‡Έ, UTC+2 πŸ‡ͺπŸ‡Ί

    We will need to cover πŸ“Œ Resolve warning in tests for numeric argument Closed: duplicate here too if we fix that one first.

  • Status changed to Needs work 7 months ago
  • πŸ‡ͺπŸ‡ΈSpain penyaskito Seville πŸ’ƒ, Spain πŸ‡ͺπŸ‡Έ, UTC+2 πŸ‡ͺπŸ‡Ί

    This isn't postponed anymore, but needs work.

  • Status changed to Postponed 7 months ago
  • πŸ‡ͺπŸ‡ΈSpain penyaskito Seville πŸ’ƒ, Spain πŸ‡ͺπŸ‡Έ, UTC+2 πŸ‡ͺπŸ‡Ί

    To take into account: πŸ’¬ Should the "My own drafts" view be included? Active . I have not a formed opinion yet.

Production build 0.71.5 2024