Do you have hover JS enabled? If so, which setting do you have selected for "Resolve disclosure button hover and click"?
jayhuskins → created an issue.
jayhuskins → created an issue.
jayhuskins → made their first commit to this issue’s fork.
jayhuskins → made their first commit to this issue’s fork.
I was unable to reproduce these errors using Axe Dev Tools, nor do I see how an li could appear outside of a ul.
The `CKEditor5 - 3.x` branch is ready to be added as a 3.x version.
jayhuskins → made their first commit to this issue’s fork.
As of issue 3043321 → the _access_node_revision route requirement is no longer used.
jayhuskins → made their first commit to this issue’s fork.
jayhuskins → made their first commit to this issue’s fork.
jayhuskins → made their first commit to this issue’s fork.
Marking this as a duplicate of https://www.drupal.org/project/project_browser/issues/3310884 ✨ Ability to clear keyword/search filter with one click Needs work
Rather than rely on the webkit clear button (which is not keyboard accessible), I made an MR that creates an actual "Clear search text" button. Chrome also automatically clears the input on the "escape" key. Should we replicate this feature in code to ensure that it's consistent between browsers?
jayhuskins → made their first commit to this issue’s fork.
jayhuskins → created an issue.
jayhuskins → created an issue.
Here's where I'm at now:
- "Expand all menu links" is a confusing option in the disclosure menu context
- But the setting needs to be supported in some fashion
- By default, all menu link items should be rendered (even if they haven't been set to "expanded")
- So "Expand all menu links" should be true by default
- We can relabel the option to something like "Build all submenus"
- Or we can invert the option (disabled by default) and label it something like "Only build enabled submenus"
- I like the terms "build" and "render" because the setting controls what markup gets added, not necessarily what gets displayed
For reference this is the setting on the menu link item that we are overriding:
I moved the padding from the `ul` to the `li` and now the submenus are properly aligned! If this looks good, I think it's ready to merge.
Also, it looks like #3 menu items are slightly lower, due to some padding, maybe?
Correct, the level 3 menu items are not perfectly aligned due to the padding on the submenu container. If anyone has the time to tweak this styling it would be much appreciated.
@ressa great feedback thank you! I just fixed a separate issue ✨ Unlimited option for Maximum disclosure levels Fixed that was causing confusion. Basically there is a setting for how many menu levels should use disclosure buttons, and by default it was set to 1, which means the first menu level would have disclosure buttons, but all subsequent menu levels would not. To fix this confusion, I set the default to "Unlimited" so that all menu levels will use disclosure buttons by default.
The unlimited settings should also be the default.
I made the styles prettier without making them too imposing. Let me know how they look! If you'd like more enhanced theming, I'd appreciate design help as that is not my specialty.
This should be documented on both the module page and the README
In order to access the Symfony\Component\String\UnicodeString class in twig, you need to add it as an allowed class in your settings.php with the twig_sandbox_allowed_classes setting. For example:
$settings['twig_sandbox_allowed_classes'] = [
'Symfony\Component\String\UnicodeString',
'Drupal\Core\Template\Attribute',
];
See more on how this is processed in the TwigSandboxPolicy.
The MR !7 will also fix this issue:
https://www.drupal.org/project/linked_field/issues/2979890 →
May require a new release version though, because unlike the previous functionality which searches for an image tag, this just wraps whatever the field would render in a link.
jayhuskins → made their first commit to this issue’s fork.
jayhuskins → created an issue.
jayhuskins → made their first commit to this issue’s fork.
Okay vertical styling is now an option and horizontal has been set as the default.
jayhuskins → created an issue.
Marking this as a duplicate of issue #3246142 🐛 Reset button is not displaying in Exposed filter block when using Ajax Needs work
Do you mean "Expand all menu links" @jayhuskins? Or is there an "Enable all menu links" option somewhere?
@ressa, Whoops, yes I mean "Expand all menu links" :)
I worry about being too opinionated, but I think you're right. It's easier to see the functionality of the module with default styles enabled, and site builders can always disabled them if they want to write their own.
Yes, I mean "remove".
As mention by @ressa in this issue (#3401517), it may be better to have the "Enable all menu links" option enabled by default. In that case we could hide the "Enable all menu links" option and add an "Only include expanded submenus" option that's disabled by default.
Let's move the discussion about the "Expand all menu links" option to this ticket:
https://www.drupal.org/project/disclosure_menu/issues/3419021
✨
Make "Expand all menu links" label clearer
Active
I'll set up a vertical style option, but I'm on the fence about making any styles active by default.
I added an option for horizontal styling. Let me know how it looks! We could also add an option for a vertical menu.
jayhuskins → created an issue.
That label comes from the core menu block configuration. I kept in place mostly so that site builders already familiar with that setting wouldn't be confused, but there's nothing to stop us from relabelling it and/or adding better help text.
jayhuskins → made their first commit to this issue’s fork.
MR !2 fixes this issue for me.
jayhuskins → created an issue.
Nevermind, I missed the "operator" query parameter.
jayhuskins → created an issue.
The documentation → needs to be updated to reflect this.
jayhuskins → made their first commit to this issue’s fork.
I'm running into a similar situation except instead of using Default content, I'm migrating inline blocks. I wonder if there's a deeper issue here.
I created this separate branch for work on a 3.x branch of this module that removes CKEditor4 dependencies
https://git.drupalcode.org/issue/ckeditor_blockquote_attribution-3362519...
jayhuskins → made their first commit to this issue’s fork.
I think I found where the behavior is coming from:
https://git.drupalcode.org/project/drupal/-/blob/11.x/core/modules/views...
Here the reset button is explicitly ignored from the ajax form because "Many things break during the form reset phase if using AJAX". There are two options for moving forward on this issue
- Keep the reset button in the form, but do not use it with AJAX.
- Keep the reset button in the AJAX form and fix the "Many things" that will subsequently break
The core issue has been fixed, and so this patch can now be evaluated against 11.x.
SDC has already been merged into core as an experimental module. This MR refers to the core version "drupal:sdc". The contrib version would be referred to as "sdc:sdc".
jayhuskins → created an issue. See original summary → .
jayhuskins → created an issue.
jayhuskins → created an issue.
Micro-nit fix for #30: changing "null" to "NULL"
This a great use-case for this module! Let's move the discussion for default styling options to this ticket [#3401517] ✨ Add styling? Active . The twig override could also be better implemented once there is a separate sub-template for the toggle button per this ticket [#3391087] ✨ Break-up menu template into sub-templates Active .
jayhuskins → created an issue.
jayhuskins → created an issue.
Setting this to postponed until this core issue is fixed:
https://www.drupal.org/project/drupal/issues/2793343
🐛
Dialog drupalAutoButtons option should be respected on initial load
Needs review
This module may solve your problem:
https://www.drupal.org/project/field_group_markup →
On the static mapping form, the "Browse available tokens" helper does not include tokens for the entity being displayed. Is this intentional? If I used a token for a static mapping like [node:title] for a node display, would the token be evaluated for each node individually?
jayhuskins → created an issue.
jayhuskins → created an issue.
jayhuskins → created an issue.
jayhuskins → made their first commit to this issue’s fork.
This functionality is not automated, but it is possible with a little extra work. There is an option to add a button to toggle open the entire menu:
This will give you the functionality of a menu that is hidden by default and opened with a button. To get the seamless effect requested you will also need to:
- Create a duplicate menu block that does not have the "Full menu disclosure" option enabled.
- Add styling to hide the expanded menu block until a desired breakpoint, and hide the collapsed menu block at that breakpoint.
To achieve all of this within a single block would require a submodule that depends on the core Breakpoints module. I have not prioritized this work because "mobile menus" often contains different content than the default menu.
Yes we could add default styling with a configuration option on the block to enable/disable it.
Moved to this new issue
https://www.drupal.org/project/leaflet/issues/3400212
💬
Display multipolygon and center point unclustered
Active
jayhuskins → created an issue.