Add Drupal core SDC module as a dependency

Yup.

Otherwise you get

" The service "Drupal\cl_editorial\NoThemeComponentManager" has a dependency on a non-existent service "plugin.manager.sdc"."

I am hesitant to merge this, because this module will soon be removed from core (and merged into the Core namespace instead). This will cause this module to download the contrib module instead.

How do you think we should handle that?

I was not aware of that, we either merge this and remove it and release a minor whenever that happens or we ignore/postpone it

SDC has already been merged into core as an experimental module. This MR refers to the core version "drupal:sdc". The contrib version would be referred to as "sdc:sdc".

@jayhuskins this is not what @e0ipso is referring to, please see 📌 Move code from the experimental SDC module to core Fixed

On the current 10.4.0-dev if I install Drupal, and then install this module I get the error that @pcambra mentioned. I'm only able to use this module if I enable the experimental SDC module.

So I don't think we'd want to add the experimental SDC module as a dependency - my understanding is that going forward components / SDCs are just a fundamental part of Drupal that don't need to be enabled. Instead, we need to figure out what this sdc_display is relying on from the experimental module and fix that.

In Drupal 10.3, the core sdc module has almost nothing in it. What is there is there to output deprecation messages. This should probably be closed as wontfix. All versions of Drupal 10 before 10.3 will be EOL very soon in any case.

Fair enough :)