DashboardLocalAction results in WSOD on dashboard route if no dashboard exists

Nice catch!

layout_builder.dashboard.view action has appears_on dashboard, but if there's no default dashboard for the user, that's a WSOD.
I'm wondering how we can dinamically alter that, while it depends on the user. Is not an action that can be cached sitewide or anything.

We need to still check how this will work with caching, but any solution would look similar to this.

1. +++ b/src/Plugin/Menu/LocalAction/DashboardLocalAction.php
   @@ -56,10 +57,36 @@ class DashboardLocalAction extends LocalActionDefault {
   +      if ($dashboard !== NULL) {
   

   IMHO it makes sense here to check if dashboard is in fact an instance of DashboardInterface.

2. +++ b/src/Plugin/Menu/LocalAction/DashboardLocalAction.php
   @@ -56,10 +57,36 @@ class DashboardLocalAction extends LocalActionDefault {
   +    $dashboard = $this->dashboardManager->getDefaultDashboard();
   

   This object instance makes a call to getDefaultDashboard 3 times - in getRouteParams, getRouteName and getTitle. For the performance reasons the default dashboard retrieval can be moved to constructor and the default dashboard could be stored as member variable.

I guess we're also lacking some test coverage.

One more thing now I think about it - I am afraid that swapping action link could be problematic given each one has different access criteria so users with edit layout permission may not necessarily also have access to manage dashboards? Just thinking out loud here, perhaps that's not an issue.

That's something we need to test. My assumption was than if the user has no access, the link is not shown, but a WSOD is avoided. But definitely need to verify AND we need automated tests for this.

Working on tests during contrib sprints.

Hi.

Adding a new version of the patch following a different approach. It adds a custom access checker to dashboard page throwing a 403 error when the user does not have access to view any dashboard.

Patch looks good, but doesn't apply anymore.

New version fixing CS issues.

ckrina → closed merge request !2

ckrina → reopened merge request !2

I opened&closed the MR to see if Tugboat appeared.

MR !2 fixes this issue for me.

plopesc → closed merge request !2

plopesc → reopened merge request !2

Automatically closed - issue fixed for 2 weeks with no activity.