Make "Expand all menu links" label clearer

That label comes from the core menu block configuration. I kept in place mostly so that site builders already familiar with that setting wouldn't be confused, but there's nothing to stop us from relabelling it and/or adding better help text.

As mention by @ressa in this issue (#3401517), it may be better to have the "Enable all menu links" option enabled by default. In that case we could hide the "Enable all menu links" option and add an "Only include expanded submenus" option that's disabled by default.

That label comes from the core menu block configuration.

I think that's why it was confusing to me. I see the logic of using consistent termonology with the core block, but where functionality differs

In that case we could hide the "Enable all menu links" option and add an "Only include expanded submenus" option that's disabled by default.

Do you mean "remove" rather than "hide" the "Enable all menu links"? I think this would make sense.

Do you mean "Expand all menu links" @jayhuskins? Or is there an "Enable all menu links" option somewhere?

But yes, I think the "Expand all menu links" option should be enabled by default :)

Yes, I mean "remove".

Do you mean "Expand all menu links" @jayhuskins? Or is there an "Enable all menu links" option somewhere?

@ressa, Whoops, yes I mean "Expand all menu links" :)

Great @jayhuskins :) I am having difficulties visualizing '... hide the "Enable Expand all menu links" option and add an "Only include expanded submenus" option that's disabled by default.' ...

So this looks like it stalled ... though it seems like you both agree on the solution. I am not certain what it will look like, but as long as the result will be an "Expand all menu links" situation, feel free to go ahead :)

Here's where I'm at now:

• "Expand all menu links" is a confusing option in the disclosure menu context
• But the setting needs to be supported in some fashion
• By default, all menu link items should be rendered (even if they haven't been set to "expanded")
• So "Expand all menu links" should be true by default
• We can relabel the option to something like "Build all submenus"
• Or we can invert the option (disabled by default) and label it something like "Only build enabled submenus"
• I like the terms "build" and "render" because the setting controls what markup gets added, not necessarily what gets displayed

For reference this is the setting on the menu link item that we are overriding:

I agree with your thoughts @jayhuskins. I have been away from the module for a while, and tried it again, and it didn't work .... until I enabled "Expand all menu links" after trying other things. So fixing this will help many other new users.

I also prefer the term "build" over "render", so "Build all submenus" would work well, enabled by default.

sonfd → changed the visibility of the branch 3419021-expand-all to hidden.

sonfd → changed the visibility of the branch 2.1.x to hidden.

I took a pass at updating labels and descriptions of the options under the Menu Levels fieldset. I think these might be an improvement, but I think they're still not ideal. See MR !17.

Changes:
I added a description to the "Menu Levels" fieldset:

These options allow you to limit which menu links are available in your block.
Example: Set "First menu level" to 1 and "Total menu levels" to 2, and check "Force all menu items with children to be expandable". This will result in a menu that shows the top level of your menu by default and all menu items will have disclosure buttons to show their child menu items.

I updated the label and description for the "Initial visibility level" field.
Label:
First menu level
Description:
The highest menu level to display. This menu is only visible if the current page is at or below this level.
If you are unsure, keep this set to "1".

I updated the label and description for the "Number of levels to display" field.
Label:
Total menu levels
Description:
The maximum number of menu levels to include in this block.
All submenu items will be initially hidden behind disclosure buttons.

I updated the label and description for the "Expand all menu links" field.
Label:
Force all menu items with children to be expandable
Description:
Without this checked, only menu items that are configured to "Show as expanded" will be expandable with disclosure buttons.
If you are unsure, keep this checked.