Keep fallback string when clear option is false

Created on 12 January 2024, about 1 year ago

Updated 13 February 2024, about 1 year ago

Problem/Motivation

If a token with a fallback string is processed without the "clear" option set to true and the token does not resolve, then the fallback string will be ignored.

Proposed resolution

When processing sub-tokens check if clear option not true and the token replacement string is the same as the subtoken before returning the token replacement string.

🐛 Bug report

Status

Needs work

Version

2.0

Component

Code

Created by

🇺🇸United States jayhuskins

Live updates comments and jobs are added and updated live.

Merge Requests

!18Keep fallback string when clear option is false
Open
🇺🇸United States jayhuskins
updated about 1 year ago

Comments & Activities

Issue created by @jayhuskins
Merge request !18Check if token was not replaced → (Open) created by jayhuskins
Comment about 1 year ago →
🇺🇸United States pianomansam
@jayhuskins thank you for the bug report and initial MR. For it to be accepted, please create a failing test demonstrating the issue and a passing test.
Status changed to Needs work about 1 year ago4:00pm 13 February 2024
Comment about 1 year ago →
🇺🇸United States pianomansam

contrib.social Blog FAQ Discussions

Production build 0.71.5 2024

Keep fallback string when clear option is false

Problem/Motivation

Proposed resolution

Merge Requests

!18Keep fallback string when clear option is falseOpen

Comments & Activities

!18Keep fallback string when clear option is false
Open