- Merge request !253Issue #3310884: Ability to clear keyword/search filter with one click → (Open) created by srishtiiee
- 🇺🇸United States chrisfromredfin Portland, Maine
I re-tested this but there's an issue that on hover there's a smaller blue X that needs to be removed. Otherwise, I think this looks good.
I can also confirm that this will close https://www.drupal.org/project/project_browser/issues/3348761 🐛 Clearing keyword search with X does not update search results Needs work once the blue X is gone.
- First commit to issue fork.
- Open on Drupal.org →Core: 10.1.x + Environment: PHP 8.1 & MySQL 5.7last update
over 1 year ago Not currently mergeable. - 🇮🇳India omkar-pd
Removed default search (x) icon. PR still needs a rebase.
- First commit to issue fork.
- last update
11 months ago Custom Commands Failed - Open on Drupal.org →Core: 10.2.x + Environment: PHP 8.1 & MySQL 5.7last update
11 months ago Not currently mergeable. - last update
11 months ago Custom Commands Failed - last update
11 months ago Custom Commands Failed - 🇮🇳India ahsannazir
The cs spell is failing due to cross.svg saying Forbidden word (grey)
- 🇪🇸Spain fjgarlin
You can just add the word to the dictionary: https://git.drupalcode.org/issue/project_browser-3310884/-/blob/3310884-...
- First commit to issue fork.
- last update
11 months ago 86 pass - last update
11 months ago 86 pass - last update
11 months ago Custom Commands Failed - Status changed to Needs review
11 months ago 7:42pm 8 March 2024 - last update
11 months ago 86 pass - 🇺🇸United States chrisfromredfin Portland, Maine
chrisfromredfin → changed the visibility of the branch 3310884-ability-to-clear to hidden.
- Status changed to Needs work
11 months ago 8:55pm 8 March 2024 - 🇺🇸United States chrisfromredfin Portland, Maine
Love this, it's working!
But, I think we need to have a FunctionalJavascript test - approach is probably something like:
1. grab the number of results
2. search for something known (or awful), see that the number of results is correct (or zero)
3. hit the X, make sure the number of results returns to the original value from 1 - Status changed to Needs review
9 months ago 3:59pm 24 April 2024 - 🇺🇸United States chrisfromredfin Portland, Maine
This needed a rebase for my test to work - the markup hadn't included the issue to change markup classnames. This is a rebase plus the test. Need someone besides me to review my test!
- 🇺🇸United States bernardm28 Tennessee
I created a new DrupalPod instance with Drupal 10.1 and the standard profile.
After adding text to the input field I was able to verify that #9 is not an issue anymore. As overlapping text still allows one to click the X and it works as expected by clearing the search results.The test seems to work as expected checking whether there are results before searching for a string that has no results and comparing their outcome.
- Status changed to RTBC
9 months ago 5:22pm 24 April 2024 -
chrisfromredfin →
committed daaf365d on 1.0.x authored by
jayhuskins →
Issue #3310884 by mpaulo, jayhuskins, srishtiiee, chrisfromredfin,...
-
chrisfromredfin →
committed daaf365d on 1.0.x authored by
jayhuskins →
- Status changed to Fixed
9 months ago 3:33pm 25 April 2024 - 🇺🇸United States chrisfromredfin Portland, Maine
another one bites the dust! Thanks, everyone. :)
Automatically closed - issue fixed for 2 weeks with no activity.