Clearing keyword search with X does not update search results

Tagged as DrupalCon Lille 23 and Novice

We, the mentoring team, are triaging issues for first time contributors at DrupalCon Lille and I think this is a good issue for the contribution day.
We are reserving this issue so please don't work on this issue if you are not at DrupalCon Lille. You can continue the work when the event is over.

Search input clear control fires the search event, so I added on:search event to trigger onSearch().

I was initially concerned about:

Non-standard: This feature is non-standard and is not on a standards track. Do not use it on production sites facing the Web: it will not work for every user. There may also be large incompatibilities between implementations and the behavior may change in the future.

However, really it just doesn't work in Firefox; however, Firefox doesn't provide the X button at all either, so it's a moot point there. However, I do think this will fire twice if someone presses enter: once for the search event, and then once again 250ms after the enter key is released.

I think we need to just watch for that by testing in the on:search that the value is blank.

Current UA implementations of have an additional control to clear the field. Using this control also fires the search event. In that case the value of the element will be the empty string.

Rather than rely on the webkit clear button (which is not keyboard accessible), I made an MR that creates an actual "Clear search text" button. Chrome also automatically clears the input on the "escape" key. Should we replicate this feature in code to ensure that it's consistent between browsers?

Marking this as a duplicate of https://www.drupal.org/project/project_browser/issues/3310884 ✨ Ability to clear keyword/search filter with one click Needs work

jayhuskins → closed merge request !445