- 🇺🇸United States japerry KVUO
hmm it appears this already has been done for a while. Closing.
- 🇺🇸United States jrockowitz Brooklyn, NY
I updated the categories, but I am still not sure about the summary.
Automatically closed - issue fixed for 2 weeks with no activity.
- 🇳🇴Norway svenryen
@leslieg just to double-check with you. Is this graphic made by you, or does it have a license that allows us to embed it in our code base?
- 🇺🇸United States DamienMcKenna NH, USA
I committed the logo files to the repo, which is a rendition of the existing logo file.
We can discuss updating the project's logo in a separate issue.
Thanks everyone.
-
damienmckenna →
committed c0d57b91 on 5.1.x
Issue #3478354 by leslieg, damienmckenna: Add logo for compatibility...
-
damienmckenna →
committed c0d57b91 on 5.1.x
- 769cae38 committed on 2.x
Issue #3474473 by leslieg: Update logo for compatibility with Project...
- 769cae38 committed on 2.x
Automatically closed - issue fixed for 2 weeks with no activity.
Automatically closed - issue fixed for 2 weeks with no activity.
Automatically closed - issue fixed for 2 weeks with no activity.
The tests are failing because they are not able to interact with the elements(by scrolling).I can't figure out how does the addition of one more element in the scroll list is causing this issue.
I tried adjusting the z-index for the apply and clear button's div but that also didn't help to fix the problem because as you can see the css of the apply and clear button's div is causing the issue (see the SS).For better understanding i changed the background colour.
I also tried to move the apply and clear button out of the select list(which is not actually we want) but that seems to pose a greater problem as you can see the SS.If anyone has any idea of what could be reason for the test fails or what else can i try to fix the problem, it would be helpful if they can document it on the issue or give it a try to fix the problem.
Thanks in advance.Hi @megachriz,
Glad to have you back at this issue. Its been a while and as far as I can remember based on our Slack conversations it was almost on the verge on finalisation. Didn't bother you guys in between as you guys might have been tied up.
So ya, waiting for @irinaz's feedback and please do let me know if I could be of any further help!TIA :)
I have adjusted the height to 50vh and also the spacing between the buttons as mentioned in #17 📌 Consider adding Apply and Clear buttons to Categories dropdown Active . Also i the concern raise by @rkoller in #18 📌 Consider adding Apply and Clear buttons to Categories dropdown Active is fixed related to
last visible option fully visible
along with the black background colour for the div containing the 2 buttons (which matches the bulk operation) and now it will be easier for the user to distinguish from the actual list.
Also regarding
and in regards of the keyboard navigation. would it make sense to move the details about the keyboard navigation into #3458844: Improve keyboard navigation/general a11y for categories dropdown if the rest of this issue is ready?
I think we could do that as a part of the that issue.
- 🇺🇸United States chrisfromredfin Portland, Maine
Should we need to update/change some of these, we have a governance process for this now.
- 🇺🇸United States camhoward New Hampshire, USA
Hi @leslieg -- Thanks, I understand. It seems I misunderstood the question from @ivnish and thought he might have been opening a discussion about the logo itself. Since that was not the case, the maintainers should proceed with whatever they think best.
- Issue created by @fromme
- 🇺🇸United States pfrilling Minster, OH
The markup is changing in https://www.drupal.org/project/project_browser/issues/3485747 🐛 The multi-category filter needs to be an actual set of labeled checkboxes Active . This will likely need a rebase once that fix lands.
- 🇩🇪Germany rkoller Nürnberg, Germany
in regards of aesthetics two details. first, i am unable to test the current state since it is broken or at least the buttons are not showing anymore at the moment, but in my previous tests i'Ve noticed a regression that is illustrated in #15 📌 Consider adding Apply and Clear buttons to Categories dropdown Active . we ve agreed on a previous issue that the user should always see only the half of the last visible option if there are more options than vertical available space. that way the user directly knows the list is scrollable. in the screenshot in #15 you see the last visible option fully visible instead. that way it is not directly apparent that the list is visible.
and i wonder if it would make sense to align the background color of that box/bar that contains those two buttons with the dark of the bulk action bar? to visualize that this is a button bar and not part of the multi select list anymore, to make it visualy distinguished from the actual list?
and in regards of the keyboard navigation. would it make sense to move the details about the keyboard navigation into 📌 Improve keyboard navigation for categories dropdown Active if the rest of this issue is ready?
- 🇺🇸United States chrisfromredfin Portland, Maine
@utkarsh_33 With many, many apologies, I think I really beefed this. I tried to rebase, which of course meant force-pushing. I then tried to restore, but I think my restore point was prior to these final fixes. If you still have the latest you did locally, can you please force-push it?
Changes remaining that I want:
- max-height of the dropdown should be "50vh" and not a pixel-based value
- Apply and clear buttons should not be space-between, but right next to each other, with clear being 0.5rem away (get rid of justify-content and replace with "gap: 0.5rem;" should do it.That's it for aesthetic fixes; but then we need to address the a11y of keyboard navigation. I THINK the right/logical thing would be IF it's open, we should be able to tab to the apply/clear buttons. If they're closed, tab should jump to the next filter. (??? ¯\_(ツ)_/¯ )
- 🇺🇸United States leslieg
Hi @camhoward. Thanks for the inquiry. The Project Browser team did not introduce the dump truck. That was part of the existing logo for Backup_migrate. We resized the logo, etc to make it comptable with Project Browser. The logo we provided is a suggestion, your team is welcome to change the logo to better reflect the module if you wish. The requirements for the logo can be found at bit.ly/maintpb. Let us know if you have any questions.
Agreed. Project Browser is still in alpha and not used by many sites yet. I think 5.1.0 should be released.
- 🇩🇪Germany Grevil
Yea, I agree, this shouldn't be a blocker for the 5.1.0 release.
- 🇳🇱Netherlands megachriz
In September, @irinaz said in Slack that she wanted to help on the logo:
https://drupal.slack.com/archives/C34CECZAL/p1725818501416959?thread_ts=...So I'm assigning the issue to her for now.
We'd like to go for something like the following logo:
The edit file as SVG is in the zip that was posted in #40:
https://www.drupal.org/files/issues/2024-08-22/Feeds-edited.svg_.zip →But here is the Affinity Designer document as well:
https://www.drupal.org/files/issues/2024-11-14/Feeds-edited.afdesign.zip →Remaining task: For the logo it should be checked if the documents has the right proportions and perhaps we should check if the strokes are thick enough. So some checks and maybe little tweaks.
Automatically closed - issue fixed for 2 weeks with no activity.