@fromme

Closed as duplicate - already applied in Replace usage of generateString with generate in Media module 📌 Replace usage of generateString with generate in MediaDisplayTest Needs work

📌 | Drupal core | Replace usage of generateString with generate in Media module

Changes from tasks 📌 Replace usage of generateString with generate in MediaDisplayTest Needs work and 📌 Replace usage of generateString with generate in MediaSourceImageTest Needs review merged into current branch and closed as duplicates.

📌 | Drupal core | Replace usage of generateString with generate in MediaDisplayTest

In drupal-3376945-2.patch the method toString() was applied incorrectly. Fixed and opened MR. All tests passed, so i moving issue to review.

📌 | Drupal core | Replace usage of generateString with generate in MediaSourceImageTest

In drupal-3376943-2.patch the method toString() was applied incorrectly. Fixed and opened MR. All tests passed, so i moving issue to review.

📌 | Drupal core | Replace usage of generateString with generate in MediaDisplayTest

fromme → made their first commit to this issue’s fork.

📌 | Drupal core | Replace usage of generateString with generate in MediaSourceImageTest

fromme → made their first commit to this issue’s fork.

📌 | Drupal core | Replace usage of generateString with generate in Media module

In drupal-3376942-2.patch the method toString() was applied incorrectly. Fixed and opened MR. All tests passed, so i moving issue to review.

📌 | Drupal core | Replace usage of generateString with generate in Media module

fromme → made their first commit to this issue’s fork.

📌 | Metatag | Content forms are painfully slow if multiple sub-modules are enabled

Here a problem with moderation state module:
1. Create node - set up some metatags, set "published" to node, save.
2. Edit node - update metatags, set "draft" to node, save.
3. Edit node again - metatags form loads default values from published version of node, but not from the last revision.

Re-roll patch with fixes, also create MR to 8.x-1.x.
It also needed to update issue fork and change target branch to 2.0.x

📌 | Metatag | Content forms are painfully slow if multiple sub-modules are enabled

📌 | Paragraphs Role Visibility | Automated Drupal 11 compatibility fixes for paragraphs_role_visibility

📌 | Delete Entity Translations | Automated Drupal 11 compatibility fixes for delete_entity_translations

fromme → made their first commit to this issue’s fork.

📌 | External Links In New Tab | Automated Drupal 11 compatibility fixes for external_links_new_tab

🐛 | Drupal core | Block/menu/views derivative labels are always shown in the first language they are view in after cache rebuild

Comment 4 months ago →

EntityType does not have label() method, that why i get:
Error: Call to undefined method Drupal\Core\Entity\ContentEntityType::label() in Drupal\Core\Entity\TranslatableEntityLabelMarkup->getTranslatedLabel() (line 233 of /var/www/html/web/core/lib/Drupal/Core/Entity/TranslatableEntityLabelMarkup.php).

Updated patch: replaced label() with getLabel()

📌 | stub project from issue ref | Offering to maintain Typography filter

gisle, yes my offer is still valid

📌 | Drupal core | Remove deprecated code from Access, Ajax, and Asset

Updated the fork, all tests passed

📌 | Drupal core | Remove deprecated code from Access, Ajax, and Asset

📌 | Drupal core | Remove deprecated usage of Migration::set() and Migration::getMigrationDependencies()

fromme → made their first commit to this issue’s fork.

Already fixed here https://www.drupal.org/project/drupal/issues/3439369 📌 Remove deprecated code in migration system Fixed
Close as duplicate.

📌 | Drupal core | Check if all admin views are using full pager

fromme → made their first commit to this issue’s fork.

📌 | Drupal core | Use service autoconfiguration for all event subscribers

It is already fixed in the issue:
Add default autoconfigure to all *.services.yml and remove event_subscriber tags 📌 Add default autoconfigure to all *.services.yml and remove event_subscriber tags Fixed

I think we can close current issue.

📌 | Drupal core | Use service autoconfiguration for all event subscribers

fromme → made their first commit to this issue’s fork.

📌 | Drupal core | Remove deprecated code in migration system

Done

📌 | Drupal core | Remove web.config from 11.x

Fixed

📌 | Drupal core | Remove deprecated code in migration system

Removed deprecated code according https://www.drupal.org/node/3266691 →

📌 | Drupal core | Remove deprecated code in migration system

Updated tests.
Here still one error, but it corresponded to Drupal\Tests\block\Functional\BlockCacheTest::testCachePerRole. Should we check and fix it in current issue?

📌 | Drupal core | Use provider in ViewExecutable::hasUrl() instead of \Drupal::service()

Replaced Drupal::service() with $this->routeProvider in ViewExecutable::hasUrl().
Opened MR.

📌 | Drupal core | Use provider in ViewExecutable::hasUrl() instead of \Drupal::service()

fromme → made their first commit to this issue’s fork.

📌 | Drupal core | Remove web.config from 11.x

Removed web.config with all references.
Opened MR.

📌 | Drupal core | Remove web.config from 11.x

fromme → made their first commit to this issue’s fork.

📌 | Drupal core | Remove deprecated code in migration system

I removed deprecated code according:
- https://www.drupal.org/node/3282894 →
- https://www.drupal.org/node/3277306 →

Opened MR.

📌 | Drupal core | Remove deprecated code in migration system

✨ | Drupal core | Give editor feedback when they changed the node title, but not the menu link title

fromme → made their first commit to this issue’s fork.

✨ | Drupal core | Implement getOriginal Method to get the original data on LanguageConfigOverride

I added typehint and update validation logic: made it more consistent and understandable.
If it's OK, i will add unit test.

Close MR. Thanx

🐛 | Drupal core | Config collections do not trigger configuration events consistently

✨ | Drupal core | Implement getOriginal Method to get the original data on LanguageConfigOverride

smustgrave → credited fromme → .

✨ | Drupal core | Implement getOriginal Method to get the original data on LanguageConfigOverride

Yes, for me it solves the issue.

✨ | Drupal core | Give editor feedback when they changed the node title, but not the menu link title

I find that getOriginal method already added to core/lib/Drupal/Core/Config/StorableConfigBase.php
It related to issue 3405800 🐛 Config collections do not trigger configuration events consistently Fixed
So should we close the issue?

✨ | Drupal core | Implement getOriginal Method to get the original data on LanguageConfigOverride

I find that getOriginal method already added to core/lib/Drupal/Core/Config/StorableConfigBase.php
It related to issue 3405800 🐛 Config collections do not trigger configuration events consistently Fixed
So should we close the issue?

✨ | Drupal core | Implement getOriginal Method to get the original data on LanguageConfigOverride

Open MR, hide patch

✨ | Drupal core | Give editor feedback when they changed the node title, but not the menu link title

fromme → made their first commit to this issue’s fork.

✨ | Drupal core | Give editor feedback when they changed the node title, but not the menu link title

✨ | Drupal core | Give editor feedback when they changed the node title, but not the menu link title

Open MR

fromme → made their first commit to this issue’s fork.

Small updates of description

📌 | stub project from issue ref | Offering to maintain Typography filter

📌 | stub project from issue ref | Offering to maintain Typography filter

🐛 | PWA - Progressive Web App | Deprecated function: str_starts_with(): Passing null to parameter #1 ($haystack) of type string is deprecated

🐛 | PWA - Progressive Web App | Deprecated function: str_starts_with(): Passing null to parameter #1 ($haystack) of type string is deprecated

Opened MR

fromme → created an issue.

✨ | External Links In New Tab | Setting form for flexibility

🐛 | SendGrid Integration | Undefined array key 1 in Drupal\sendgrid_integration\Plugin\Mail\SendGridMail->doMail()

🐛 | SendGrid Integration | Undefined array key 1 in Drupal\sendgrid_integration\Plugin\Mail\SendGridMail->doMail()

Open MR

🐛 | SendGrid Integration | Undefined array key 1 in Drupal\sendgrid_integration\Plugin\Mail\SendGridMail->doMail()

🐛 | Delete Entity Translations | getEntityTypes doesn't need to check entities AND processItems has wrong starting point

fromme → created an issue.

Comment 9 months ago →

🐛 | Delete Entity Translations | getEntityTypes doesn't need to check entities AND processItems has wrong starting point

Remove checking of translations in form.
Fix the bug with wrong starting point of batch.
Merged to release 1.0.3.

Thanks everyone for participating in this issue!

Comment 9 months ago →

According to PHP coding standards → should be used const instead of define(), so need to make this:

/**
  * The batch default size.
  */
const BATCH_SIZE = 50;

...................................
->range(0, self::BATCH_SIZE)

instead of

define("PROCESS_COMMIT_BATCH_SIZE", 50);

...................................
->range(0, PROCESS_COMMIT_BATCH_SIZE)

If main code changed - unit tests should be improved too. For now i see warnings and errors with current MR:
https://git.drupalcode.org/issue/delete_entity_translations-3411374/-/pi...

📌 | Delete Entity Translations | Fix the issues reported by phpcs

Comment 9 months ago →

✨ | External Links In New Tab | Setting form for flexibility

📌 | Typography filter | Add "Help" page

Added typography_filter.module file with hook_help(). Open MR

📌 | Typography filter | Add "Help" page

fromme → created an issue.

📌 | Typography filter | Add GitLab CI

Add GitLab CI, open MR

📌 | Typography filter | Add GitLab CI

fromme → created an issue.

✨ | Typography filter | Site builders can configure which filters to enable

Make filters configurable, open MR

✨ | Typography filter | Site builders can configure which filters to enable

fromme → made their first commit to this issue’s fork.

📌 | stub project from issue ref | Offering to maintain Typography filter

🐛 | PWA - Progressive Web App | Bad value "device-width", "device-height" and "-webkit-device-pixel-ratio" for attribute media on element link

fromme → created an issue.

Replaced "device-width" with "width" and "device-height" with "height" in pwa_extras.module according new info from https://drafts.csswg.org/mediaqueries/#mf-deprecated
"-webkit-device-pixel-ratio" doesn't have any effect, so it wasn't chenged.
Open MR.

📌 | External Links In New Tab | Need to add unit tests

Taken to DEV branch.

Taken to DEV branch.

📌 | External Links In New Tab | Add compatibility with Drupal 10

Taken to DEV branch.

✨ | External Links In New Tab | Setting form for flexibility

Done, MR opened

✨ | External Links In New Tab | Setting form for flexibility

📌 | External Links In New Tab | Add compatibility with Drupal 10

📌 | External Links In New Tab | Need to add unit tests

💬 | External Links In New Tab | external_links_new_tab project open to new maintainer applications on 30 Sep, 2021

fromme → created an issue.

Marked the issue as fixed, new maintainer is added: https://www.drupal.org/project/projectownership/issues/3394200 →

📌 | stub project from issue ref | Offering to maintain External links in new tab

@gisle, thank you

📌 | stub project from issue ref | Offering to maintain External links in new tab

📌 | Paragraphs Role Visibility | Fix eslint warnings

Fixed, merged to DEV branch

📌 | Paragraphs Role Visibility | Fix eslint warnings

fromme → created an issue.

📌 | stub project from issue ref | Offering to maintain External links in new tab

I sent a message to flyke via contact page https://www.drupal.org/user/2750085/contact → and mark "Send yourself a copy" (16 October 2023). Here the copy:

But still no response from flyke.
I move the issue to Drupal.org Project Ownership, is there anything else that can be done?

📌 | stub project from issue ref | Offering to maintain External links in new tab

Comment 12 months ago →

@gisle, thanks for detailed explanation.
I sent message to flyke, hope he responds)

📌 | External Links In New Tab | Need to add unit tests

Comment 12 months ago →