@fromme

fromme → created an issue.

fromme → made their first commit to this issue’s fork.

@sjmolinski I try "Steps to reproduce" and can't reproduce the bug (Drupal 10.3.5).
Have you tried to reproduce this bug on clean Drupal installation?
Can you provide more details?

Fixed, open MR

fromme → created an issue.

Fixed, open MR

fromme → created an issue.

Fixed, open MR

fromme → created an issue.

Fixed, open MR

fromme → created an issue.

fromme → created an issue.

Merged. Will be released with 8.x-1.1 version

fromme → made their first commit to this issue’s fork.

Merged. Will be released with 8.x-1.1 version

Merged. Will be released with 8.x-1.1 version

Merged. Will be released with 8.x-1.1 version

fromme → made their first commit to this issue’s fork.

Closed as duplicate - already applied in Replace usage of generateString with generate in Media module 📌 Replace usage of generateString with generate in Media module Needs work

Closed as duplicate - already applied in Replace usage of generateString with generate in Media module 📌 Replace usage of generateString with generate in MediaDisplayTest Needs work

Changes from tasks 📌 Replace usage of generateString with generate in MediaDisplayTest Needs work and 📌 Replace usage of generateString with generate in MediaSourceImageTest Needs review merged into current branch and closed as duplicates.

In drupal-3376945-2.patch the method toString() was applied incorrectly. Fixed and opened MR. All tests passed, so i moving issue to review.

In drupal-3376943-2.patch the method toString() was applied incorrectly. Fixed and opened MR. All tests passed, so i moving issue to review.

fromme → made their first commit to this issue’s fork.

fromme → made their first commit to this issue’s fork.

In drupal-3376942-2.patch the method toString() was applied incorrectly. Fixed and opened MR. All tests passed, so i moving issue to review.

fromme → made their first commit to this issue’s fork.

Here a problem with moderation state module:
1. Create node - set up some metatags, set "published" to node, save.
2. Edit node - update metatags, set "draft" to node, save.
3. Edit node again - metatags form loads default values from published version of node, but not from the last revision.

Re-roll patch with fixes, also create MR to 8.x-1.x.
It also needed to update issue fork and change target branch to 2.0.x

fromme → made their first commit to this issue’s fork.

EntityType does not have label() method, that why i get:
Error: Call to undefined method Drupal\Core\Entity\ContentEntityType::label() in Drupal\Core\Entity\TranslatableEntityLabelMarkup->getTranslatedLabel() (line 233 of /var/www/html/web/core/lib/Drupal/Core/Entity/TranslatableEntityLabelMarkup.php).

Updated patch: replaced label() with getLabel()

gisle, yes my offer is still valid

Updated the fork, all tests passed

fromme → made their first commit to this issue’s fork.

Already fixed here https://www.drupal.org/project/drupal/issues/3439369 📌 Remove deprecated code in migration system Fixed
Close as duplicate.

fromme → made their first commit to this issue’s fork.

It is already fixed in the issue:
Add default autoconfigure to all *.services.yml and remove event_subscriber tags 📌 Add default autoconfigure to all *.services.yml and remove event_subscriber tags Fixed

I think we can close current issue.

fromme → made their first commit to this issue’s fork.

Done

Fixed

Removed deprecated code according https://www.drupal.org/node/3266691 →

Updated tests.
Here still one error, but it corresponded to Drupal\Tests\block\Functional\BlockCacheTest::testCachePerRole. Should we check and fix it in current issue?

Replaced Drupal::service() with $this->routeProvider in ViewExecutable::hasUrl().
Opened MR.

fromme → made their first commit to this issue’s fork.

Removed web.config with all references.
Opened MR.

fromme → made their first commit to this issue’s fork.

I removed deprecated code according:
- https://www.drupal.org/node/3282894 →
- https://www.drupal.org/node/3277306 →

Opened MR.

fromme → made their first commit to this issue’s fork.

I added typehint and update validation logic: made it more consistent and understandable.
If it's OK, i will add unit test.

Close MR. Thanx

smustgrave → credited fromme → .

Yes, for me it solves the issue.

I find that getOriginal method already added to core/lib/Drupal/Core/Config/StorableConfigBase.php
It related to issue 3405800 🐛 Config collections do not trigger configuration events consistently Fixed
So should we close the issue?

I find that getOriginal method already added to core/lib/Drupal/Core/Config/StorableConfigBase.php
It related to issue 3405800 🐛 Config collections do not trigger configuration events consistently Fixed
So should we close the issue?

Open MR, hide patch

fromme → made their first commit to this issue’s fork.

Open MR

fromme → made their first commit to this issue’s fork.

Small updates of description

Opened MR

fromme → created an issue.

Open MR

fromme → created an issue.

Remove checking of translations in form.
Fix the bug with wrong starting point of batch.
Merged to release 1.0.3.

Thanks everyone for participating in this issue!

1. According to PHP coding standards → should be used const instead of define(), so need to make this:
   

   /**
     * The batch default size.
     */
   const BATCH_SIZE = 50;
   
   ...................................
   ->range(0, self::BATCH_SIZE)
   

   instead of

   define("PROCESS_COMMIT_BATCH_SIZE", 50);
   
   ...................................
   ->range(0, PROCESS_COMMIT_BATCH_SIZE)
   

2. If main code changed - unit tests should be improved too. For now i see warnings and errors with current MR:
   https://git.drupalcode.org/issue/delete_entity_translations-3411374/-/pi...

Added typography_filter.module file with hook_help(). Open MR

fromme → created an issue.

Add GitLab CI, open MR

fromme → created an issue.

Make filters configurable, open MR

fromme → made their first commit to this issue’s fork.

fromme → created an issue.

Replaced "device-width" with "width" and "device-height" with "height" in pwa_extras.module according new info from https://drafts.csswg.org/mediaqueries/#mf-deprecated
"-webkit-device-pixel-ratio" doesn't have any effect, so it wasn't chenged.
Open MR.

Taken to DEV branch.

Taken to DEV branch.

Taken to DEV branch.

Done, MR opened

fromme → created an issue.

Marked the issue as fixed, new maintainer is added: https://www.drupal.org/project/projectownership/issues/3394200 →

@gisle, thank you