Give editor feedback when they changed the node title, but not the menu link title

The Needs Review Queue Bot → tested this issue. It either no longer applies to Drupal core, or fails the Drupal core commit checks. Therefore, this issue status is now "Needs work".

Apart from a re-roll or rebase, this issue may need more work to address feedback in the issue or MR comments. To progress an issue, incorporate this feedback as part of the process of updating the issue. This helps other contributors to know what is outstanding.

Consult the Drupal Contributor Guide → to find step-by-step guides for working with issues.

Open MR

The Needs Review Queue Bot → tested this issue.

While you are making the above changes, we recommend that you convert this patch to a merge request → . Merge requests are preferred over patches. Be sure to hide the old patch files as well. (Converting an issue to a merge request without other contributions to the issue will not receive credit.)

Left some comments

Will need test coverage

I find that getOriginal method already added to core/lib/Drupal/Core/Config/StorableConfigBase.php
It related to issue 3405800 🐛 Config collections do not trigger configuration events consistently Fixed
So should we close the issue?

I added typehint and update validation logic: made it more consistent and understandable.
If it's OK, i will add unit test.

I think it would make more sense if that's implemented in the frontend *before* saving, otherwise you have to go back after you already saved and edit it again. Similar to the you have unsaved changes message after reordering.

That said, opinionated things are tricky to do in core. first, it should be in menu_ui, because node module should not depend on menu link stuff, then it needs to handle cases when the node title field isn't displayed and so on.

Thanks for taking a look @berdir, if reading correctly there's some feedback about doing before saving.