Contrib.social

Accesscheck for Terms doesn't support the new 'view all revisions' permission

Open on Drupal.org →
Created on 11 March 2022, over 2 years ago
Updated 18 February 2023, over 1 year ago

Problem/Motivation

\Drupal\taxonomy\TermAccessControlHandler::checkAccess doesn't handle the 'view all revisions'

The accesscheck for Terms doesn't use the new 'view all revisions' permission yet. This should be implemented. (see #3043321: Use generic access API for node and media revision UI → )

We notices this in: ✨ Support version negotiation for any entity type (currently only Node & Media are supported) Fixed

I think this work might be done here: ✨ Implement a generic revision UI Fixed , but i think a split might be good, since getting UI into core is a lot harder than this fix.

Steps to reproduce

Proposed resolution

Implement 'view all revisisons', operation check in TermAccessControlHandler by adding a new 'view term revisions' permission

Remaining tasks

User interface changes

API changes

Data model changes

Release notes snippet

🐛 Bug report
Status

Needs work

Version

10.1 ✨

Component
Taxonomy  →

Last updated 1 day ago

  • Maintained by
  • 🇺🇸United States @xjm
  • 🇬🇧United Kingdom @catch
Created by

🇳🇱Netherlands bbrala Netherlands

Live updates comments and jobs are added and updated live.
  • Novice

    It would make a good project for someone who is new to the Drupal contribution process. It's preferred over Newbie.

  • Needs change record

    A change record needs to be drafted before an issue is committed. Note: Change records used to be called change notifications.

Sign in to follow issues

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

  • Comment over 1 year ago →
    🇺🇸United States smustgrave

    This issue is being reviewed by the kind folks in Slack, #needs-review-queue-initiative. We are working to keep the size of Needs Review queue [2700+ issues] to around 400 (1 month or less), following Review a patch or merge request → as a guide.

    Think has this is adding a new ability it will need a change record.

    Ran the tests locally without the fix and get a valid failure

    Behat\Mink\Exception\ExpectationException : Current response status code is 404, but 200 expected.
 /var/www/html/web/vendor/behat/mink/src/WebAssert.php:794
 /var/www/html/web/vendor/behat/mink/src/WebAssert.php:130
 /var/www/html/web/core/modules/taxonomy/tests/src/Functional/TaxonomyTermRevisionTest.php:46
 /var/www/html/web/vendor/phpunit/phpunit/src/Framework/TestResult.php:728
contrib.social Blog FAQ Discussions
Production build 0.71.5 2024