Accesscheck for Terms doesn't support the new 'view all revisions' permission

Open on Drupal.org →

Created on 11 March 2022, about 3 years ago

Updated 11 November 2024, 4 months ago

Problem/Motivation

\Drupal\taxonomy\TermAccessControlHandler::checkAccess doesn't handle the 'view all revisions'

The accesscheck for Terms doesn't use the new 'view all revisions' permission yet. This should be implemented. (see #3043321: Use generic access API for node and media revision UI → )

We notices this in: ✨ Support version negotiation for any entity type (currently only Node & Media are supported) Fixed

I think this work might be done here: ✨ Implement a generic revision UI Fixed , but i think a split might be good, since getting UI into core is a lot harder than this fix.

Steps to reproduce

Proposed resolution

Implement 'view all revisisons', operation check in TermAccessControlHandler by adding a new 'view term revisions' permission

Remaining tasks

User interface changes

API changes

Data model changes

Release notes snippet

🐛 Bug report

Status

Needs work

Version

11.0 🔥

Component

Last updated 6 days ago

Maintained by
🇺🇸United States @xjm
🇬🇧United Kingdom @catch

Created by

🇳🇱Netherlands bbrala Netherlands

Live updates comments and jobs are added and updated live.

Novice
It would make a good project for someone who is new to the Drupal contribution process. It's preferred over Newbie.

Needs Review Queue Initiative
Used to track the progress of issues reviewed by the Drupal Needs Review Queue Initiative.

Needs change record
A change record needs to be drafted before an issue is committed. Note: Change records used to be called change notifications.

Incomplete comments

Sign in to follow issues

Merge Requests

!10360Accesscheck for Terms doesn't support the new 'view all revisions' permission
Open
🇦🇺Australia silverham
updated 4 months ago

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

Comment about 2 years ago →
🇺🇸United States smustgrave
This issue is being reviewed by the kind folks in Slack, #needs-review-queue-initiative. We are working to keep the size of Needs Review queue [2700+ issues] to around 400 (1 month or less), following Review a patch or merge request → as a guide.

Think has this is adding a new ability it will need a change record.

Ran the tests locally without the fix and get a valid failure

Behat\Mink\Exception\ExpectationException : Current response status code is 404, but 200 expected. /var/www/html/web/vendor/behat/mink/src/WebAssert.php:794 /var/www/html/web/vendor/behat/mink/src/WebAssert.php:130 /var/www/html/web/core/modules/taxonomy/tests/src/Functional/TaxonomyTermRevisionTest.php:46 /var/www/html/web/vendor/phpunit/phpunit/src/Framework/TestResult.php:728
First commit to issue fork.
First commit to issue fork.
Merge request !10360Accesscheck for Terms doesn't support the new 'view all revisions' permission #3269029 (10.5.x) → (Open) created by silverham
Comment 4 months ago →
🇦🇺Australia silverham
Add related issue where even if revision can be fetched via JSON:API, the first one is cached. 🐛 Add revision ID to "jsonapi_normalizations" cache keys Needs work

contrib.social Blog FAQ Discussions

Production build 0.71.5 2024