The Needs Review Queue Bot → tested this issue. It either no longer applies to Drupal core, or fails the Drupal core commit checks. Therefore, this issue status is now "Needs work".
Apart from a re-roll or rebase, this issue may need more work to address feedback in the issue or MR comments. To progress an issue, incorporate this feedback as part of the process of updating the issue. This helps other contributors to know what is outstanding.
Consult the Drupal Contributor Guide → to find step-by-step guides for working with issues.
- 🇮🇳India abhishek.kumar
Can this be reviewed by core maintainers and suggest their view on this ?
- 🇧🇪Belgium BramDriesen Belgium 🇧🇪
Version should always target the latest version and be back ported when needed.
- 🇺🇦Ukraine alt.dev
We faced an issue with this patch.
If the page title has an apostrophe symbol, the \Drupal::service('token')->replace() method will run the Html::escape() method which will convert the apostrophe to the ' HTML symbol. After that, the \Drupal::request()->query->get() function won't be able to extract the whole param and will trim everything after the # symbol.
I made changes so that the patch will use the "replacePlain()" method instead.
- 🇺🇦Ukraine alt.dev
Adding the patch with the current state of the branch. Works with 10.4.3.
- First commit to issue fork.
fromme → changed the visibility of the branch 2903336-allow-tokens-for to hidden.
