@sonfd Thank you!
The "Block Visibility Conditions" module is very appropriate here rather than trying to "fix" patch here.
Applied suggested change.
I chose Klaro already after evaluating available modules for the purpose which were not depending on other modules.
I don't I can close this as original post can be a valid issue.
junaidpv → changed the visibility of the branch 3493259-add-ability-to to active.
junaidpv → changed the visibility of the branch 3493259-add-ability-to to hidden.
Here is a patch for the proposed change.
junaidpv → created an issue.
Here the patch implementing three drush commands: listing, adding a country and removing a country.
junaidpv → created an issue.
Made a new release 2.0.2 with this change.
Here is a patch to start with.
junaidpv → created an issue.
Thanks for offering.
I just added you as a maintainer.
Please go ahead.
Sorry, there is a correction!
I was using the "Blazy OEmbed" form the blazy module.
Klaro works if I use "oEmbed content" from the core media module regardless of "loading" option set to "lazy" or "eager".
So, it works as designed when using core formatter.
Any option/plan to support the blazy → module?
I also facing this issue.
In my case it was already using "Blazy OEmbed" (from the blazy module) which has a string setting 'loading'. So, switching to "oEmbed content" formatter causes the error.
A fix worked for me was to replace occurrences of $this->getSetting('loading')['attribute']
with $this->getSetting('loading')['attribute'] ?? NULL
.
junaidpv → created an issue.
IMHO, this module should not have hard dependency on local and language modules.
Facing same issue and the proposed change fixes the issue.
Faced same issue. Changes from #2 fixed the issue.
Here is that changes in patch format for a composer based to fetch.
Facing this issue.
#5 no longer applies to 2.0.0-beta2, and the issue does not happen either!
Re-rolled for 2.0.0.
Created a MR having a fix. Here is a patch version of it.
Applies to 10.3.x, 10.4.x and 11.x branches.
junaidpv → made their first commit to this issue’s fork.
Same as #38 just in patch file format for our composer based builds to rely on.
junaidpv → created an issue.
Here is the patch.
junaidpv → created an issue.
Sorry, I made a mistake in last patch. Here is a corrected one.
Here is the patch.
junaidpv → created an issue.
Here is a patch fixing it.
junaidpv → created an issue.
I don't think that needs to be a configurable one. It is a known path within the library and usually no need to change.
Here is a version that works with both local and CDN. Without making that configurable thus a simpler patch.
Just re-rolled for 8.x-3.15.
I just verified that the patch in #151 works fine in 10.3.3
Re-rolled for 10.3.3. Did not include change from #138 as not sure whether that is required. Need to test to see if it works.
Thanks! Merged.
junaidpv → made their first commit to this issue’s fork.
Just a re-roll of #50 for 10.3.2
Hopefully, we need to address #51 and #52.
@alison, My apologies for not carefully evaluating before reverting the status.
Yes that fix indeed solves the issue of generating tons of warning messages logged.
The site page loading is also very slow. I assumed the slowness was due to the generation of that warning messages. I tried that patch and found the site loading still slowly. But now I noticed that it indeed it solves warning message generation. Thus solves the issue reported here.
However, the site is still being loaded very slowly until I uninstall the admin_toolbar_tools module. I need to look somewhere else to solve tha problem.
Only uninstalling the admin_toolbar_tools module helps. Fix now committed on 🐛 Fix access checks for bundle permissions to avoid triggering a config validation error Fixed is not helping, thus changing to the previous status.
@Prashant.c Batch process UI is using the active theme but the batch process ajax calls are processed with admin theme.
Please review the MR just updated.
junaidpv → created an issue.
Back to this issue again after 4 years. Patch from #14 helped.
@steveoriol You may delete a text format completely with drush command. Make sure it is not being anywhere in the site:
drush cdel filter.format.[format_name]
#2 helped me to solve a problem with a CSV export view using a batch process. Certain paragraph reference field was chosen to render using an overridden twig template. But the output was having column not rendered with that template. Figured out it was because the batch process was using the admin theme instead of the theme that was used to render the original view page.
The patch makes sense.
@Carlos Romero. Done
Merged. Thanks!
junaidpv → made their first commit to this issue’s fork.
Same as #6 (MR !23) but in classical patch form for easy applying in composer based build setup we use here.
Re-rolled for the 2.0.0-beta2 and latest 2.x branch.
It now just works for body fields??
The original patch I posted in #23 were supposed to work with any long text field with summary. But I see it now evolved lot more but restricted to just body fields as there are some hard coding for body fields. Definitely it needs to be a generic one.
Faced this bug. I confirm patch #5 helped to solve the issue.
Probably thy are compound errors specific to your site. I am unable to reproduce it here.
Could you please let me know the steps that can reproduce those errors. Also, please try it on a fresh site.
Thanks for getting back. It really helped. I appreciate the help.
I have applied a fix and a made a new release.
Please use the latest version 2.1.5 of this module. Hope it helps.
Please post the link to that webpage if that is available for public.
Or probably you will be having JS error in the browser console. Please post that error message here.
Thanks!
I appreciate the concern. Unfortunately only the current way helped to solve the original problem, to crop same image in multiple places. Please post if you have a better idea we can pursue.
Meanwhile, I am closing this until then.
Back porting #22 for Drupal 10.1.x.
I am facing same issue as the scenario 1 given in comment #11. Rebuilding the cache did not help.
Verified that above patch is no longer working.
I improved it. Now it is working.
Getting similar error. Running for the wysiwyg_template → against its 3.0.0-rc2 tag. On a Drupal 10.2.
Just re-rolled #20 for 10.2
Faced same issue with the crop_image → module as a field widget from that module extends FileBrowserWidget from the entity_browser module. I already made a new release of the crop_image module to fix the issue.
So, any other module out there extending plugins of the entity_browser module are going to get hit with this. Those module will be required to update anyway.
We tried using the Fullcalendar Block instead of using this patch. But that module cannot be used as a replacement, especially when we want to have views exposed form. Also we need to configure it in two places, and configuring the date filter is confusing.
As the patch got rejected here. We decide to create a separate module to have this feature. It is Fullcalendar Dynamic → . It is mostly a fork of the fullcalendar_view module. Please have look and please feel free to submit patches to fix any issues you encounter.
Re-rolled patch for the latest release 4.0.0
Re-rolled for the latest release 4.0.0
Re-rolled for latest release 2.1.0.
junaidpv → made their first commit to this issue’s fork.
Thanks!
Made a new release supporting D10, including this fix.
junaidpv → made their first commit to this issue’s fork.
Just rerolled #30 for 10.1.x
Exactly same as #47, just re-rolled for 10.1.x
I don't understand change in #11 thus just re-rolling #2 for 10.1
I don't see isDuplicate method in EntityBase class or anywhere other than in the jsonapi module which is on a completely different class.
What version of the Drupal you using?
Or probably it came from another patch you using?
I am facing same issue with a migration from D7 to D9.5.
@huzooka where did you set value for "needs_resave" ?
I developed a patch implementing this feature as well as additional other customization. Please see ✨ Customize display of signup fields Needs review .
I implemented it. It allows this customization in signup block configuration settings:
- Order of fields
- Control label display
- Add custom field classes
- Add custom field wrapper classes
- Set other additional attributes for the fields
Sample screenshot:
junaidpv → created an issue.
My profile2 type migration failed because somehow the profile2 type configuration in D7 having "roles" property with empty (0) for all non-selected roles. Filtering roles property from source solved the issue.
Here is the updated patch.
@Nupur Badola please open a new bug and attach the patch if you have.
Here is the working implementation with the help of a patch ✨ Provide Page and Page Variant as context values while rendering each component in the Layout Needs review for the Page Manager module.
junaidpv → created an issue.
Here is a very simple patch implementing it. But I feel it may to be correct place to add the content values. Please feel free to improve it.
junaidpv → created an issue.
Re-rolled for release 2.33.
Just a reroll of #18 for current 9.5.x
Try fixing CCF.
Building on #44. Adding similar improvement as #38 but to the datetime filter in core datetime module.
We were having this requirement and this thread had came in my search result. We could develop a solution. Hopefully people looking for a solution will find this helpful.
The solution is with help of a ViewsArgumentDefault plugin. It is somehow like an extended version of "User ID from logged in user" in user module. I created it like a completely new plugin. But I guess we can just improve existing "User ID from logged in user".
It is generic user module related plugin. Can be used for other related user cases. So, no need to go into media system.
Steps to use this:
- Apply the patch to Drupal core
- Clear cache
- Add "Authored by" contextual filter for Media items.
- On that contextual filter settings dialog. Under "When the filter value is NOT available". Choose "Provide default value" option.
- Then select "User ID from logged in user with skipping for selected roles" as type.
- Select roles you want to grant access to view items,
- Make sure the "Skipping value" setting matches with the "Exception Value" under "Exceptions" field set.
@Kris77, Yes, that was by mistake. I uploaded the correct one in #3.