- ðµð±Poland Graber
I finally created this https://www.drupal.org/project/date_filter â to address this issue and many other.
Looks like issues like this have a very small chance to get enough attention and find their way into core so we have to handle that in contrib :( - Status changed to Needs review
almost 2 years ago 7:26pm 6 April 2023 - ð®ð³India junaidpv Kannur, Kerala
Building on #44. Adding similar improvement as #38 but to the datetime filter in core datetime module.
- Status changed to Needs work
almost 2 years ago 7:39pm 6 April 2023 - ðºðžUnited States smustgrave
Was previously tagged for tests and issue summary update which still need to happen plese.
Also please include interdiffs with patches.
- ð®ð³India junaidpv Kannur, Kerala
Exactly same as #47, just re-rolled for 10.1.x
- ð«ð·France S3b0uN3t Nantes
Hello,
I tried to apply patch on comment #50, but it's thrown an error in datetime module :
Warning: Undefined array key "type" in Drupal\datetime\Plugin\views\filter\Date->getOffset() (line 180 of core/modules/datetime/src/Plugin/views/filter/Date.php).
Without this warning, the patch works perfectly on Drupal 10.2.2!
- ð«ð·France prudloff Lille
Starting with #38, the patch always adds
+1 day
to any max value that does not explicitly contain a time.
While I understand the reason to do this on date values, I don't think it always makes sense on offset values.
For example "now" will become "now +1 day" (so tomorrow at the same time). But if I want my view to return results between some date and now, it will be confusing if it starts returning results from tomorrow. - ð®ð³India junaidpv Kannur, Kerala
Just a re-roll of #50 for 10.3.2
Hopefully, we need to address #51 and #52.
- ðºðžUnited States SocialNicheGuru
- ðªðžSpain plopesc Valladolid
Added new version of the patch against 10.3.2 where it adds support also for missing max value.
- ððºHungary SunnyGambino Buj
Patch based on 2982968-core-views-improve-date-filter-56.patch.
Just quick fix to make sure there are no warnings, otherwise AJAX reset button won't work, as it is throwing these annoying warning. :) - ð³ð±Netherlands johnv
The OP is confusing to me on several accounts
- the expected outcome is in +/- 3 days, but the actual results are in years
- the printscreen shows that 'An offset [...]' is selected, instead of 'A date [...]'.I my test, when selecting
- 'An offset [...]', I need to set '-7 days', to '+1 day'
- 'A date [...]', I need to set '20241231' to '20250303'
IMO that is OK. I can imagine a view with changes in the last week (using offset).Of course the widget is very basic/not acceptable for ordinary users.
So, this issue still 'Needs issue summary update'