- @mingsong opened merge request.
- 🇦🇺Australia mingsong 🇦🇺
Thanks everyone for working or contributing your thought on this issue.
Since there are a lots changes and this move will require more testing, I created a new branch 5.2.x for it and a MR for this issue.
You can use following URL to get the patch for the MR.
https://git.drupalcode.org/project/fullcalendar_view/-/merge_requests/44...
The main concern I am having for the codes suggested is security. I will raise my concern on the MR for further clarifying.
It is a significant change and involved all lots work. I really appreciate your work and thought on such important feature for some sites in which there are a lots of events which are unnecessary to load at once.
- Status changed to Needs work
almost 2 years ago 1:22am 23 January 2023 - 🇦🇺Australia mingsong 🇦🇺
There are some unsolved issues (see the MR), so it needs more works.
- 🇮🇳India someshver Panchkula
Getting issue after applying the patch #61.
TypeError: Drupal\smart_date\Plugin\FullcalendarViewProcessor\SmartDateProcessor::getIdMappings(): Argument #1 ($entries) must be of type array, null given, called in C:\Users\FWS-22-3\PHPstorm Projects\P-Test\P-D9\drupal\web\modules\contrib\smart_date\src\Plugin\FullcalendarViewProcessor\SmartDateProcessor.php on line 53 in Drupal\smart_date\Plugin\FullcalendarViewProcessor\SmartDateProcessor->getIdMappings() (line 94 of modules\contrib\smart_date\src\Plugin\FullcalendarViewProcessor\SmartDateProcessor.php).
I am using Smart date with Smart Date Recurring module.
Same error with patch #61
Drupal\smart_date\Plugin\FullcalendarViewProcessor\SmartDateProcessor::getIdMappings(): Argument #1 ($entries) must be of type array, null given
- Status changed to Closed: outdated
over 1 year ago 5:48am 3 April 2023 - 🇦🇺Australia mingsong 🇦🇺
I will put this module into "Bug fixing only' status soon.
A feature like this one requires a lots testing, won't be add to future release of this module.
I recommend using Fullcalendar Block module instead.
- 🇺🇸United States fallenturtle
Was it ever identified what the "5" in the readme picture was for? I'm having an issue where I'm getting a white screen of death with full calendar, but if I limit the results number, it'll start working again. What's the expected value to be used here? I always assumed show all... but maybe that's what's breaking my view.
- 🇮🇳India junaidpv Kannur, Kerala
We tried using the Fullcalendar Block instead of using this patch. But that module cannot be used as a replacement, especially when we want to have views exposed form. Also we need to configure it in two places, and configuring the date filter is confusing.
As the patch got rejected here. We decide to create a separate module to have this feature. It is Fullcalendar Dynamic → . It is mostly a fork of the fullcalendar_view module. Please have look and please feel free to submit patches to fix any issues you encounter.
- 🇺🇦Ukraine alex.tiupa Lutsk, Ukraine
Updated patch from #74. I made some JS strings translatable.
- 🇺🇦Ukraine alex.tiupa Lutsk, Ukraine
Fixed mistake made in #77. The patch adds
Drupal.t
to js strings. - 🇺🇦Ukraine alex.tiupa Lutsk, Ukraine
My bad, I fixed the mistake from previous patches.