- last update
about 1 year ago 23 pass - 🇮🇳India junaidpv Kannur, Kerala
My profile2 type migration failed because somehow the profile2 type configuration in D7 having "roles" property with empty (0) for all non-selected roles. Filtering roles property from source solved the issue.
Here is the updated patch.
- last update
about 1 year ago Composer error. Unable to continue. - Status changed to RTBC
about 1 year ago 12:00pm 2 November 2023 - 🇮🇳India ajeet_kumar gurugaon
I reviewed and tested patch #49 → working for me
- Status changed to Needs review
9 months ago 11:10am 21 February 2024 - last update
9 months ago 23 pass, 2 fail - 🇺🇦Ukraine sickness29
Made migration test for both profile 2 types and profiles along with fixture for D7.
Also had to move views.view.profiles.yml into config/optional as migrate tests were failing because of this The last submitted patch, 51: profile2_migrate-2957256-51.patch, failed testing. View results →
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.- Status changed to Needs review
9 months ago 11:23am 21 February 2024 - last update
9 months ago 25 pass - 🇨🇦Canada joelpittet Vancouver
Same issue as #41
[warning] Undefined array key "use_page" Profile2Type.php:57 [warning] Undefined array key "use_page" Profile2Type.php:57 [warning] Undefined array key "use_page" Profile2Type.php:57 [warning] Undefined array key "use_page" Profile2Type.php:57 [warning] Undefined array key "use_page" Profile2Type.php:57 [warning] Undefined array key "use_page" Profile2Type.php:57
Apparently that key is not saved in 1.7 of profile2
- 🇨🇦Canada joelpittet Vancouver
@sickness29 There has got to be a better way to do test, 2MB patch files look a bit extreme, no?
Thanks for taking a crack at it though, tests are my least favourite task but generally really rewarding once they are working.
- last update
9 months ago 23 pass - last update
9 months ago 25 pass - 🇨🇦Canada joelpittet Vancouver
Here's a couple patches for easier review I have included an interdiff for the fix reported in #41 and #54.
And two patches based off #49 (without 2MB of tests) and #53
- 🇮🇱Israel jsacksick
I also wonder if we can find a middleground between no tests and 2MB of tests data :).
@ sickness29: Is that possible? - 🇺🇸United States mradcliffe USA
I also wonder if we can find a middleground between no tests and 2MB of tests data :).
You should be able to re-use drupal core's fixture along with an additional smaller fixture under 10k. The smaller fixture that is targeted only at profile2 data can be manually crafted rather than using the database dump script.
So instead of
+ + /** + * Gets the path to the fixture file. + */ + protected function getFixtureFilePath() { + return __DIR__ . '/../../../../fixtures/drupal7.php'; + } + + /** + * {@inheritdoc} + */ + protected function setUp(): void { + parent::setUp();
Remove the overridden
getFixtureFilePath()
, and do something like this instead:/** * {@inheritdoc} */ protected function setUp(): void { // The default drupal 7 database fixture will be loaded first as part of parent setUp method. parent::setUp(); $profile2Fixture = __DIR__ . '/../../../../fixtures/drupal7.php'; $this->assertNotFalse(realpath($profile2Fixture)); $this->loadFixture($profile2Fixture);
- last update
8 months ago 24 pass, 2 fail - 🇺🇦Ukraine khiminrm
I've made fixes according to the comment #58.
I've used2957256-56-from-53-migrate-profile2.patch
from the #56 as starting point and added the fixes. The last submitted patch, 59: 2957256-migrate-profile2-59.patch, failed testing. View results →
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.- 🇺🇦Ukraine khiminrm
I've moved views.view.profile.yml to optional similar as in #51 ✨ Migrate data from Profile2 Needs work and added some more data to the fixture file.
- last update
8 months ago 26 pass - Status changed to Needs review
8 months ago 10:19am 18 March 2024 -
jsacksick →
committed 0ebdb0d4 on 8.x-1.x
Issue #2957256 by super_romeo, ocastle, khiminrm, marvil07, joelpittet,...
-
jsacksick →
committed 0ebdb0d4 on 8.x-1.x
- Status changed to Fixed
8 months ago 11:21am 18 March 2024 Automatically closed - issue fixed for 2 weeks with no activity.