Account created on 21 November 2018, over 5 years ago
  • Sr Drupal developer at Melity 
#

Merge Requests

Recent comments

🇮🇳India Nishant

Provided patch for layout_paragraphs regarding above issue with version 2.0.4,

Please test.

🇮🇳India Nishant

Thanks @shashank5563, Faced same issue earlier, Now I have applied your patch and it's working fine fine for me.
I am moving it RTBC.

🇮🇳India Nishant

I have fixed the above issue and provided patch,Please validate.

🇮🇳India Nishant

I am providing patch for the above issue, Please validate.

🇮🇳India Nishant

Implemented this functionality
Extracts and lists all external links of a node. The list should be available as a block which can be embedded in the region of your choice.
Please validate.

🇮🇳India Nishant

Provided MR for the above issue, Please review.

🇮🇳India Nishant

I have fixed the installation issue, Now Module will install smoothly.

🇮🇳India Nishant

Provided patch for above issue, Please verify.

🇮🇳India Nishant

I have checkout 3379900-phpcs-errors this branch and run the above command, I saw some phpcs cs error, I am posting below.

FILE: /var/www/html/web/modules/live_weather/src/Plugin/Block/LiveWeatherBlock.php
-----------------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
-----------------------------------------------------------------------------------------------------------------------------------
 9 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\Core\Config\ConfigFactoryInterface.
-----------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-----------------------------------------------------------------------------------------------------------------------------------


FILE: /var/www/html/web/modules/live_weather/src/Form/LiveWeatherDeleteForm.php
-----------------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
-----------------------------------------------------------------------------------------------------------------------------------
 6 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\Core\Config\ConfigFactoryInterface.
-----------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-----------------------------------------------------------------------------------------------------------------------------------


FILE: /var/www/html/web/modules/live_weather/src/Form/LiveWeatherForm.php
-----------------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
-----------------------------------------------------------------------------------------------------------------------------------
 6 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\Core\Config\ConfigFactoryInterface.
-----------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-----------------------------------------------------------------------------------------------------------------------------------


FILE: /var/www/html/web/modules/live_weather/src/Controller/LiveWeatherController.php
-----------------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
-----------------------------------------------------------------------------------------------------------------------------------
 6 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\Core\Config\ConfigFactoryInterface.
-----------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-----------------------------------------------------------------------------------------------------------------------------------


FILE: /var/www/html/web/modules/live_weather/src/LiveWeather.php
-----------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
-----------------------------------------------------------------------------------------------------------------------------
 6 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\Component\Serialization\Json.
-----------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
🇮🇳India Nishant

Provided patch for above issue, Please review.

🇮🇳India Nishant

Reviewed above MR, I can see README.md file is correct and it's followed the Drupal standard.

🇮🇳India Nishant

This is fixed and above patch is working fine. Moving it to RTBC.

🇮🇳India Nishant

Review the above MR and it's working fine for me.

🇮🇳India Nishant

Fixed the above issue and provided solution with patch.

🇮🇳India Nishant

Fixed the above issue and created MR, Please review.

🇮🇳India Nishant

Fixed the above issue and provided patch for same.

🇮🇳India Nishant

Update the Readme file and provided MR.

🇮🇳India Nishant

Fixed the above issue and provided patch. Please review

🇮🇳India Nishant

Reviewed above patch and Merge it in latest branch.
Thanks @shashank5563

🇮🇳India Nishant

Created MR for above issue, Please review and Merge.

🇮🇳India Nishant

@shashank5563, Please check once, getting error while applying patch, Attaching SS for reference.

🇮🇳India Nishant

Nishant made their first commit to this issue’s fork.

🇮🇳India Nishant

Reviewed above patch and Merged it in latest branch.

🇮🇳India Nishant

This is fixed, I am closing this issue.

🇮🇳India Nishant

This is fixed so I am closing this issue.

🇮🇳India Nishant

Tested above patch#3, and all phpcs issue is fixed.

🇮🇳India Nishant

Fixed the above issue and provided patch.

🇮🇳India Nishant

Review above MR and Merged it in latest branch.

🇮🇳India Nishant

Fixed the above issue and provided patch for same.

🇮🇳India Nishant

I have review above patch #4 and Merged it in latest branch.

🇮🇳India Nishant

Nishant made their first commit to this issue’s fork.

🇮🇳India Nishant

Fixed the above issue and provided patch.

🇮🇳India Nishant

Removed the composer.json and provided patch for the same.

🇮🇳India Nishant

Please validate the patch #2.

🇮🇳India Nishant

Fixed above issue and provided patch.

🇮🇳India Nishant

Hello Team,

I see this module seeking new co-maintainer. I would like to become a maintainer of the module to update a codebase, prepare it for Drupal 10 and fix bugs mentioned in the issue queue.

Thanks!

🇮🇳India Nishant

Hello Team,

I see this module seeking new maintainer. I would like to become a maintainer of the module to update a codebase, prepare it for Drupal 10 and fix bugs mentioned in the issue queue.

Thanks!

🇮🇳India Nishant

Hello Team,

I see this module seeking new maintainer. I would like to become a maintainer of the module to update a codebase, prepare it for Drupal 10 and fix bugs mentioned in the issue queue.

Thanks!

🇮🇳India Nishant

Hello Team,

I see this module seeking new maintainer. I would like to become a maintainer of the module to update a codebase, prepare it for Drupal 10 and fix bugs mentioned in the issue queue.

Thanks!

🇮🇳India Nishant

Verified patch#7 working fine for me.

🇮🇳India Nishant

Fixed the above issue and provided patch for same.
Please verify.

🇮🇳India Nishant

Hello Team,

I see this module seeking new maintainer. I would like to become a maintainer of the module to update a codebase, prepare it for Drupal 10 and fix bugs mentioned in the issue queue.

Thanks!

🇮🇳India Nishant

Applied above patch and I can confirm patch is working fine.
Attaching SS for reference.

🇮🇳India Nishant

Reviewed and It's looking good for me. Attaching SS for reference.

🇮🇳India Nishant

Fixed the above Readme File issue and Provided MR,
Please verify.

Production build 0.69.0 2024