- Issue created by @Nishant
- First commit to issue fork.
- Assigned to kpoornima
- @kpoornima opened merge request.
- Issue was unassigned.
- Status changed to Needs review
over 1 year ago 12:00pm 8 August 2023 - Status changed to Needs work
over 1 year ago 2:50pm 8 August 2023 - 🇵🇭Philippines roberttabigue
Hi @kpoornima,
When I applied your MR !3 to the Audio Embed Field module against 8.x-2.x-dev on Drupal 9.5.10, it didn't resolve all the errors.
See the remaining 1 error below:FILE: /.../audio_embed_field/modules/audio_embed_media/audio_embed_media.info.yml -------------------------------------------------------------------------------------------------------------------------------------------------- FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE -------------------------------------------------------------------------------------------------------------------------------------------------- 1 | WARNING | "core_version_requirement" property is missing in the info.yml file -------------------------------------------------------------------------------------------------------------------------------------------------- Time: 473ms; Memory: 10MB
Please run this command on the module:
phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml,twig audio_embed_field
Moving this to Needs work for now.
Thank you!
- 🇮🇳India kpoornima
HI @roberttabigue
MR !3 Phpcs errors checked with 8.x-2.0 and updated ticket version with 8.x-2.0.
Thanks You!
-
shashank5563 →
committed 7aaed85e on 8.x-2.x authored by
kpoornima →
Reverted changes "#3379962 fixing spaces and phpcs"
-
shashank5563 →
committed 7aaed85e on 8.x-2.x authored by
kpoornima →
- Status changed to Fixed
over 1 year ago 6:33am 9 August 2023