Also use text editor (CKEditor) for "summary" of a text field

Have confirmed that #116 works well on 9.5.x.

There is some test coverage included in the patch, so is additional test coverage required?

#116 is working in Drupal 9.5.2

Thank You!!

Does any one have solution for this issue ? I want to use ckeditor5 in summery field in drupal 9.

I applied #2671162-116: Also use text editor (CKEditor) for "summary" of a text field → on 11.x and manually edit the editor.js file as the es6 file was removed.

Also, some of the test files modified on the patch there were removed in #3270438: Remove CKEditor 4 from core → so leaving the other tests.

latest patch seems not to apply anymore

re-rolled and created a new MR from it ...

let's see what happens.

Also for open tags

Fixed linting error in editor.js file.

Do we have a patch who is working well for the last drupal 9 version?

Or maybe drupal 10?

Tested #122 with 10.1.3 and works as intended.

Patch #122 ✨ Also use text editor (CKEditor) for "summary" of a text field Needs work works for me using Drupal 10.1.4 (don't forget to force reload your browser page to allow new js to refresh).

#122 rerolled.

I just tested it again on drupal 10.1.8-dev and it's not working anymore, do you know when this will be included in core?

did someone have a patch working for 10.2 at least?

I'm also curious about the status of getting this in Drupal 10. Any chance to get a patch rolled to 10.2.2?

#132 applies cleanly on drupal 10.2.2.

CKeditor didn´t show up until I turned on "Always show the summary field" in content type´s form display for the body field.

Is that intended?

Supplement to my comment #136:
I just realized that for new nodes CKeditor shows up without the checkmark as mentioned above.
But for existing nodes I have to do that.

I applied patch #132 to Drupal 10.2, but nothing changed because in the editor.libraries.yml file, drupal.editor has the version set as VERSION. Therefore, I rerolled the patch and removed it. If this is incorrect, please don't hesitate to provide the correct solution.

made the MR green "again" after some updates from 11.x
A lot of errors on tests ... Needs review, for now ... so maybe there could code improvements - code review.

Wondering if we still need the "Needs tests" tag ...

Tagging for usability.

My only concern is this feels odd. You essentially have two full text fields now so why not add 2 fields.

But will leave for usability

Also going to tag for framework thoughts.

But notes I'm seeing

Will need a configuration on the field for this feature, should not be the default added.
Will need to be able to limit the formatters, separate from the feature that was already added to filter formats from the main field. I imagine people won't want Full HTML to be used in their summary.
Will need a formatter configuration that will filter the summary now as the "Summary or trimmed" formatter don't believe is any longer safe.

Personally I'm wondering if this belongs in a contrib module vs core.

As sub maintainer I'm kinda -1 but this issue pre-dates me putting that hat on so will defer to the framework managers.

The Needs Review Queue Bot → tested this issue. It no longer applies to Drupal core. Therefore, this issue status is now "Needs work".

This does not mean that the patch necessarily needs to be re-rolled or the MR rebased. Read the Issue Summary, the issue tags and the latest discussion here to determine what needs to be done.

Consult the Drupal Contributor Guide → to find step-by-step guides for working with issues.

I applied #138 patch and it worked but there was an issue with unrecognized setAttribute function inside an event handler that casued an error and max length not working, setAttribute is a method that only works on individual DOM elements, not on jQuery objects or collections of elements.

To fix this, I modified the event handler to iterate over each element in field using .each(), allowing us to correctly call setAttribute on each raw DOM element individually.

I'm truly grateful for the efforts here, but ideally, I would like to be able to have this option on any full-text field - not just "body."

The 10.2 patch (132) works well for Body fields. Is the ultimate D11 fix also just going to target the body field?

It now just works for body fields??

The original patch I posted in #23 were supposed to work with any long text field with summary. But I see it now evolved lot more but restricted to just body fields as there are some hard coding for body fields. Definitely it needs to be a generic one.

Updated the MR - fix tests. made it green

I think this was in "Needs Review"

About the latest comments ... it's NOT only about the body field.... it's a generic solution for all text with summary fields.
Maybe the confusion is from tests ... that uses the already existing body field.

Believe this should be postponed on 🌱 [Meta] Deprecate text_with_summary Active

let's have https://www.drupal.org/project/drupal/issues/3427095 🌱 [Meta] Deprecate text_with_summary Active linked ... at least

@smustgrave:

When you tag an issue for usability review, please make it easy for the usability team to review the issue. Update the issue summary:

• The "Proposed resolution" section should describe all the changes made in the issue.
• The "User interface changes" should show the existing UI and the proposed UI.
• The "Remaining tasks" should include one explaining the usability issue(s).

Most of the time, I prefer to have plain text in the "Proposed resolution" section and screenshots in the "User interface changes" section. For this issue, (1) needs work (already noted in the "Remaining tasks"), (2) is already in good shape, and (3) is missing.

You can also attend the weekly usability meeting to present an issue.

I am setting the status to NW.

Usability review

We discussed this issue at 📌 Drupal Usability Meeting 2024-05-31 Needs work . That issue will have a link to a recording of the meeting.

For the record, the attendees at the usability meeting were @benjifisher, @rkoller, @simohell, @shaal, and @SKAUGHT.

If you want more feedback from the usability team, a good way to reach out is in the #ux channel in Slack.

The only usability issue we see in the comments is from Comment #140:

My only concern is this feels odd. You essentially have two full text fields now so why not add 2 fields.

As far as we can tell, that is out of scope for this issue. It is certainly relevant for 🌱 [Meta] Deprecate text_with_summary Active , but in the context of this issue, we have two text fields and they both use the same text format. It makes sense to use CKEditor for both of them.

We also discussed whether it was worth the effort to discuss this issue, considering #3427095. We decided it is worth our time: if the text_with_summary is deprecated in Drupal 11 and removed in Drupal 12, that means it will still be around for several years.

We only tested the updated code on the Body field during the meeting, and I just noticed Comments #144, #145. Personally, I agree: if we are going to make this change, then it should apply to all text_with_summary fields, not just the body field.

Patchs does not works for D10.3.3...

Re-rolled for 10.3.3. Did not include change from #138 as not sure whether that is required. Need to test to see if it works.

I just verified that the patch in #151 works fine in 10.3.3

#151 works fine on D10.3.3 for me too, thanks

fwiw #151 works against 10.3.5, thank you.

#151 applied on 10.3.2. It works : the summary is shown in CKEditor but 1 file does not exist in 10.3.2 (core/modules/ckeditor5/tests/src/FunctionalJavascript/CKEditor5MarkupTest.php) and 2 changes are rejected (core/modules/editor/src/Element.php)

$ ls -l core/modules/ckeditor5/tests/src/FunctionalJavascript/CKEditor5^C
$ patch -p1 < core/modules/editor/js/2671162-151.patch
can't find file to patch at input line 5
Perhaps you used the wrong -p or --strip option?
The text leading up to this was:
--------------------------
|diff --git a/core/modules/ckeditor5/tests/src/FunctionalJavascript/CKEditor5MarkupTest.php b/core/modules/ckeditor5/tests/src/FunctionalJavascript/CKEditor5MarkupTest.php
|index bd58595b12..b1a80fc7fd 100644
|--- a/core/modules/ckeditor5/tests/src/FunctionalJavascript/CKEditor5MarkupTest.php
|+++ b/core/modules/ckeditor5/tests/src/FunctionalJavascript/CKEditor5MarkupTest.php
--------------------------
File to patch:
Skip this patch? [y]
Skipping patch.
1 out of 1 hunk ignored
patching file core/modules/ckeditor5/tests/src/FunctionalJavascript/CKEditor5Test.php
Hunk #1 succeeded at 157 (offset 75 lines).
Hunk #2 succeeded at 319 (offset 75 lines).
Hunk #3 succeeded at 563 (offset 75 lines).
patching file core/modules/ckeditor5/tests/src/Traits/CKEditor5TestTrait.php
patching file core/modules/editor/js/editor.js
patching file core/modules/editor/src/Element.php
Reversed (or previously applied) patch detected!  Assume -R? [n]
Apply anyway? [n] y
Hunk #1 FAILED at 67.
Hunk #2 FAILED at 77.
2 out of 2 hunks FAILED -- saving rejects to file core/modules/editor/src/Element.php.rej
patching file core/modules/editor/tests/src/Functional/EditorLoadingTest.php
Hunk #1 succeeded at 182 (offset 2 lines).
Hunk #2 succeeded at 223 (offset 2 lines).
$