Account created on 31 May 2015, over 9 years ago
#

Recent comments

🇨🇭Switzerland motame

Ah OK !
Thank you very much @jrockowitz for your rapid reaction.
I searched first for it but I didn't find any thing about it.
Sorry then for this unnecessary new issue...

🇨🇭Switzerland motame

motame created an issue.

🇨🇭Switzerland motame

#151 applied on 10.3.2. It works : the summary is shown in CKEditor but 1 file does not exist in 10.3.2 (core/modules/ckeditor5/tests/src/FunctionalJavascript/CKEditor5MarkupTest.php) and 2 changes are rejected (core/modules/editor/src/Element.php)

$ ls -l core/modules/ckeditor5/tests/src/FunctionalJavascript/CKEditor5^C
$ patch -p1 < core/modules/editor/js/2671162-151.patch
can't find file to patch at input line 5
Perhaps you used the wrong -p or --strip option?
The text leading up to this was:
--------------------------
|diff --git a/core/modules/ckeditor5/tests/src/FunctionalJavascript/CKEditor5MarkupTest.php b/core/modules/ckeditor5/tests/src/FunctionalJavascript/CKEditor5MarkupTest.php
|index bd58595b12..b1a80fc7fd 100644
|--- a/core/modules/ckeditor5/tests/src/FunctionalJavascript/CKEditor5MarkupTest.php
|+++ b/core/modules/ckeditor5/tests/src/FunctionalJavascript/CKEditor5MarkupTest.php
--------------------------
File to patch:
Skip this patch? [y]
Skipping patch.
1 out of 1 hunk ignored
patching file core/modules/ckeditor5/tests/src/FunctionalJavascript/CKEditor5Test.php
Hunk #1 succeeded at 157 (offset 75 lines).
Hunk #2 succeeded at 319 (offset 75 lines).
Hunk #3 succeeded at 563 (offset 75 lines).
patching file core/modules/ckeditor5/tests/src/Traits/CKEditor5TestTrait.php
patching file core/modules/editor/js/editor.js
patching file core/modules/editor/src/Element.php
Reversed (or previously applied) patch detected!  Assume -R? [n]
Apply anyway? [n] y
Hunk #1 FAILED at 67.
Hunk #2 FAILED at 77.
2 out of 2 hunks FAILED -- saving rejects to file core/modules/editor/src/Element.php.rej
patching file core/modules/editor/tests/src/Functional/EditorLoadingTest.php
Hunk #1 succeeded at 182 (offset 2 lines).
Hunk #2 succeeded at 223 (offset 2 lines).
$
🇨🇭Switzerland motame

Hi @viren18febS,
That is exactly my proposed solution and i did it before writing this issue and it works.
I'm wondering whether it's the best way to do it.
Interested to hear from the maintainers.

Thank you.

Production build 0.71.5 2024