Account created on 1 November 2017, over 7 years ago
#

Merge Requests

More

Recent comments

๐Ÿ‡บ๐Ÿ‡ฆUkraine alt.dev

Adding the patch with the current state of the branch. Works with 10.4.3.

๐Ÿ‡บ๐Ÿ‡ฆUkraine alt.dev

We faced an issue with this patch.

If the page title has an apostrophe symbol, the \Drupal::service('token')->replace() method will run the Html::escape() method which will convert the apostrophe to the ' HTML symbol. After that, the \Drupal::request()->query->get() function won't be able to extract the whole param and will trim everything after the # symbol.

I made changes so that the patch will use the "replacePlain()" method instead.

๐Ÿ‡บ๐Ÿ‡ฆUkraine alt.dev

alt.dev โ†’ made their first commit to this issueโ€™s fork.

๐Ÿ‡บ๐Ÿ‡ฆUkraine alt.dev

Closing this task since the module doesn't support Drupal 7 anymore.

๐Ÿ‡บ๐Ÿ‡ฆUkraine alt.dev

Closing this issue since module doesn't support Drupal 7 anymore.

๐Ÿ‡บ๐Ÿ‡ฆUkraine alt.dev

Closing this task since the code was merged a long time ago.

๐Ÿ‡บ๐Ÿ‡ฆUkraine alt.dev

The code was merged a long time ago. Closing this issue.

๐Ÿ‡บ๐Ÿ‡ฆUkraine alt.dev

A similar code was merged in the #3417381 task. Closing this task.

๐Ÿ‡บ๐Ÿ‡ฆUkraine alt.dev

alt.dev โ†’ made their first commit to this issueโ€™s fork.

๐Ÿ‡บ๐Ÿ‡ฆUkraine alt.dev

Hi, I checked the code and tested the changes. LGTM.

๐Ÿ‡บ๐Ÿ‡ฆUkraine alt.dev

I checked the code and tested the patch, and everything looks good.

๐Ÿ‡บ๐Ÿ‡ฆUkraine alt.dev

I checked and tested the code provided in the MR. LGTM.

๐Ÿ‡บ๐Ÿ‡ฆUkraine alt.dev

alt.dev โ†’ changed the visibility of the branch 3.x to hidden.

๐Ÿ‡บ๐Ÿ‡ฆUkraine alt.dev

alt.dev โ†’ made their first commit to this issueโ€™s fork.

๐Ÿ‡บ๐Ÿ‡ฆUkraine alt.dev

alt.dev โ†’ created an issue.

๐Ÿ‡บ๐Ÿ‡ฆUkraine alt.dev

I attached the latest patch from the MR.

๐Ÿ‡บ๐Ÿ‡ฆUkraine alt.dev

alt.dev โ†’ created an issue.

๐Ÿ‡บ๐Ÿ‡ฆUkraine alt.dev

I attach the latest patch from the MR just in case this task won't be merged soon.

๐Ÿ‡บ๐Ÿ‡ฆUkraine alt.dev

Attaching the latest patch from the MR.

๐Ÿ‡บ๐Ÿ‡ฆUkraine alt.dev

alt.dev โ†’ changed the visibility of the branch 3480896-drupal-11-compatibility to active.

๐Ÿ‡บ๐Ÿ‡ฆUkraine alt.dev

alt.dev โ†’ changed the visibility of the branch 3480896-drupal-11-compatibility to hidden.

๐Ÿ‡บ๐Ÿ‡ฆUkraine alt.dev

I added required changes that give other modules the ability to alter props and slots before they are passed to the render array.

Also, I'm attaching the patch.

๐Ÿ‡บ๐Ÿ‡ฆUkraine alt.dev

alt.dev โ†’ changed the visibility of the branch 3458850-props-alter to active.

๐Ÿ‡บ๐Ÿ‡ฆUkraine alt.dev

alt.dev โ†’ changed the visibility of the branch 3458850-props-alter to hidden.

๐Ÿ‡บ๐Ÿ‡ฆUkraine alt.dev

I made a fix when nested blocks added via the inline_entity_form module didn't have the edit button visible when you edit the block. Also, this fix fixes the issue when you can't see nested blocks while the node is not saved.

This patch can be applied to Drupal 10.2.x.

๐Ÿ‡บ๐Ÿ‡ฆUkraine alt.dev

While MR isn't merged, I'm attaching a patch based on the latest MR that can be applied to Drupal 10.2.x.

๐Ÿ‡บ๐Ÿ‡ฆUkraine alt.dev

I'm attaching a patch based on the latest MR that can be applied to Drupal 10.2.x.

๐Ÿ‡บ๐Ÿ‡ฆUkraine alt.dev

Thanks @bohart for your work. I merged your changes to codebase ;)

๐Ÿ‡บ๐Ÿ‡ฆUkraine alt.dev

Thanks everyone for the work. Merged the latest changes to the codebase.

๐Ÿ‡บ๐Ÿ‡ฆUkraine alt.dev

I created a new branch and re-rolled code to the 10.2.x. core branch.

Attaching the re-rolled patch for the Drupal 10.2.0 version(taken from the new MR !6023)

๐Ÿ‡บ๐Ÿ‡ฆUkraine alt.dev

alt.dev โ†’ made their first commit to this issueโ€™s fork.

๐Ÿ‡บ๐Ÿ‡ฆUkraine alt.dev

alt.dev โ†’ made their first commit to this issueโ€™s fork.

๐Ÿ‡บ๐Ÿ‡ฆUkraine alt.dev

When I apply this patch and try to add fields to the group content, I receive the next error:

Drupal\Core\Entity\EntityStorageException: 'group_relationship_type' entity with ID 'community-group_node-record' already exists. in Drupal\Core\Entity\EntityStorageBase->doPreSave() (line 519 of core/lib/Drupal/Core/Entity/EntityStorageBase.php).

Attaching an updated patch that solves this issue.

๐Ÿ‡บ๐Ÿ‡ฆUkraine alt.dev

Thank you all for your work. I merged the code to the dev branch.

๐Ÿ‡บ๐Ÿ‡ฆUkraine alt.dev

alt.dev โ†’ made their first commit to this issueโ€™s fork.

๐Ÿ‡บ๐Ÿ‡ฆUkraine alt.dev

Thank you all for your work. I merged the code to the dev branch.

๐Ÿ‡บ๐Ÿ‡ฆUkraine alt.dev

Thanks, everyone, I merged the MR.

๐Ÿ‡บ๐Ÿ‡ฆUkraine alt.dev

I confirm that the patch doesn't work with the JSON:API module.

I updated the latest patch and added the fix for the computed field.

๐Ÿ‡บ๐Ÿ‡ฆUkraine alt.dev

Hi @labboy0276, I use this module in several projects and I would like to offer to take the maintenance of this module.

๐Ÿ‡บ๐Ÿ‡ฆUkraine alt.dev

alt.dev โ†’ created an issue.

๐Ÿ‡บ๐Ÿ‡ฆUkraine alt.dev

I updated the module a little bit, and made the following changes:

  • Added composer.json file;
  • Moved sensitive data to state;
  • Added config/install and config/schema files;
  • Created custom graph_mail key type.
  • Added integration with the key module;
  • Fixed critical issue when the getEmailFromString method couldn't extract email from the string;
  • Fixed the logic when default email didn't use by default.
  • Re-worked the mail plugin to make it use objects instead of the array as the mail argument;
  • Created the GraphMailHelper service.
  • Wrote the hook_update function that moves sensitive data from config to state.
  • Added configuration to the info file. Created the menu item for the module configuration form.
  • Code cleanup/optimization.

What needs to be done is to add tests.

When I created this issue I saw that we have the 2.0 version of the module, but it's not compatible with Drupal <10 version.
I think we can migrate some logic from this issue to the 2.0 version later.

๐Ÿ‡บ๐Ÿ‡ฆUkraine alt.dev

alt.dev โ†’ created an issue.

๐Ÿ‡บ๐Ÿ‡ฆUkraine alt.dev

Never mind my previous comment. It turned out that the patch made by the bot applies without a problem if we won't use a custom composer package to install this module to bypass composer validation.

I can confirm that the patch provided in comment #2 works like a charm.

๐Ÿ‡บ๐Ÿ‡ฆUkraine alt.dev

I was not able to apply the patch provided by the bot so I created the new one that apply without a problem.

๐Ÿ‡บ๐Ÿ‡ฆUkraine alt.dev

I created a patch with the required changes to the composer.libraries.json file to make it compatible with D10.

๐Ÿ‡บ๐Ÿ‡ฆUkraine alt.dev

Checked the code and tested the functionality. Everything working like charm.

๐Ÿ‡บ๐Ÿ‡ฆUkraine alt.dev

Hello @Snap โ†’ ,

I left one comment in your MR. Please check it and add changes if you feel that they are reasonable.

๐Ÿ‡บ๐Ÿ‡ฆUkraine alt.dev

The patch looks good, everything works like a charm.

Thank you @snap_x for your work.

๐Ÿ‡บ๐Ÿ‡ฆUkraine alt.dev

alt.dev โ†’ made their first commit to this issueโ€™s fork.

๐Ÿ‡บ๐Ÿ‡ฆUkraine alt.dev

Working on this ticket during #LutskGCW23

Production build 0.71.5 2024