- Issue created by @Matroskeen
- Assigned to deimos
- @deimos opened merge request.
- First commit to issue fork.
-
Matroskeen β
committed 6b914c6f on 2.0.x authored by
deimos β
Issue #3336935 by deimos, Matroskeen, HitchShock: Create "Rabbit Hole"...
-
Matroskeen β
committed 6b914c6f on 2.0.x authored by
deimos β
- Issue was unassigned.
- Status changed to Needs review
almost 2 years ago 3:53pm 28 January 2023 - πΊπ¦Ukraine deimos
'Rabbit hole' field type and appropriate widget is implemented.
Field formatter can be skipped because without it field still works fine but is disabled at 'Manage display' page. - @altdev opened merge request.
- πΊπ¦Ukraine alt.dev
alt.dev β made their first commit to this issueβs fork.
- Assigned to HitchShock
- πΊπ¦Ukraine HitchShock Ukraine
Reviewed and tested the current solution.
Fixed a couple of bugs I found.The issue is a blocker for another ticket - π Use Rabbit Hole values from config field instead of base fields Fixed , and possibly for π Automatically copy values from old base fields to new config field Fixed
- πΊπ¦Ukraine HitchShock Ukraine
Reviewed and tested the current solution.
Fixed a couple of bugs I found.The issue is a blocker for another ticket - π Use Rabbit Hole values from config field instead of base fields Fixed , and possibly for π Automatically copy values from old base fields to new config field Fixed
- Issue was unassigned.
- πΊπ¦Ukraine HitchShock Ukraine
@matroskeen One thing to think about, at the moment the allow_override option is enabled by default (to keep the previous behavior), but since we want to avoid unnecessary field creation, it would be nice if this option was disabled by default.
This is just a thought out loud. - Status changed to Needs work
almost 2 years ago 4:26pm 18 February 2023 - πΊπ¦Ukraine Matroskeen πΊπ¦ Ukraine, Lutsk
@HitchShock thanks for picking this up! Let's change the behavior and keep allow_override disabled by default.
I also added some comments to the merge request, so it's back to "Needs Work". - Status changed to Needs review
almost 2 years ago 10:39am 19 February 2023 - πΊπ¦Ukraine HitchShock Ukraine
@matroskeen About allow_override - it should be a separate issue. See my comment here
- Status changed to Needs work
almost 2 years ago 2:39pm 25 February 2023 - πΊπ¦Ukraine Matroskeen πΊπ¦ Ukraine, Lutsk
@HitchShock I agree it can be another issue. I suggested expanding the scope of π Use Rabbit Hole values from config field instead of base fields Fixed , but feel free to create a new one if it makes sense. I also made more detailed review and added more comments to the MR.
Thank you and keep up the good work!
- Status changed to Needs review
almost 2 years ago 5:35pm 4 March 2023 -
Matroskeen β
committed 4ccfe338 on 2.0.x authored by
alt.dev β
Issue #3336935 by HitchShock, deimos, Matroskeen, alt.dev: Create "...
-
Matroskeen β
committed 4ccfe338 on 2.0.x authored by
alt.dev β
- Status changed to Fixed
almost 2 years ago 3:10pm 18 March 2023 - πΊπ¦Ukraine Matroskeen πΊπ¦ Ukraine, Lutsk
Thanks everyone for your hard work! Special kudos to @HitchShock for keeping it up!
We can advance to the next step, which is: π Use Rabbit Hole values from config field instead of base fields Fixed . Automatically closed - issue fixed for 2 weeks with no activity.