🇺🇦Ukraine @deimos

Fix looks and works good!
Also adding a patch file for safer changes applying on site/projects.

Committed fix into fork-branch. Attaching patch-file for safer applying in projects.
Ready for review/testing.

I'm going to provide solution described in description.

deimos → created an issue.

I added a basic .gitlab-ci.yml for automatic phpcs checking what might help for task review. Additionally it checks other code styles (for css, js) and run tests.

deimos → made their first commit to this issue’s fork.

Attach a patch file with the same fix to use on my site and don't be dependent from MR and for others to get quick fix if they face the same issue.

Committed fix as described in the proposed solution.
Please review.

I will provide a proposed solution.

deimos → created an issue.

Also I tested module on Drupal 11.1.4 and module works fine.

1. Drop Drupal 8 and 9 from module's supported versions since Drupal 8 is now end-of-life - PSA-2021-11-30 → and Drupal 9 is end of life - PSA-2023-11-01 →
2. Add basic Drupal GitLab CI usage to get automatic checks for code styles (phpcs, cslint), typos (cspell) and php issues (phpstan).
   More information about Drupal GitLab CI: https://www.drupal.org/docs/develop/git/using-gitlab-to-contribute-to-dr... →

These are done and pushed into 3434827-drupal-11-compatibility , see MR!4.
I put this issue back into Needs review. Feel free to re-open task and add code-styles corrections to get pipeline build fully green - https://git.drupalcode.org/issue/summary_word_limit-3434827/-/pipelines/....

I take this in work to add a few changes:
1. Drop Drupal 8 and 9 from module's supported versions since Drupal 8 is now end-of-life - PSA-2021-11-30 → Drupal 9 is end of life - PSA-2023-11-01 →
2. Add basic Drupal GitLab CI usage to get automatic checks for code styles (phpcs, cslint), typos (cspell) and php issues (phpstan).

deimos → made their first commit to this issue’s fork.

The deprecated code was ignored because of // @phpstan-ignore-next-line.

src/Form/MediaBulkUploadForm.php

  public function batchOperation($id, array $operation_details, array &$context) {
...

    catch (\Exception $e) {
      if (method_exists(Error::class, 'logException')) {
        Error::logException($this->getLogger('media_bulk_upload'), $e);
      }
      else {
        // @phpstan-ignore-next-line
        watchdog_exception('media_bulk_upload', $e);
      }
    }
  }

I removed deprecated code since Media Bulk Upload 3.0.x-dev version is compatible with Drupal ^10.3 || ^11 and Error::logException is present for sure.

Additionally I extended .gitlab-ci.yml to run checks for previous major (in current case Drupal 10.4.2), previous minor (in current case Drupal 11.0.8) and next minor (in current case Drupal 11.x-dev 67cb9b5) versions.

Put back to Needs review.

Take back to work to check why phpstan job doesn't detect deprecations and fix deprecation

------ -----------------------------------------------------------
  Line   src/Form/MediaBulkUploadForm.php
 ------ -----------------------------------------------------------
  450    Call to deprecated function watchdog_exception():
         in drupal:10.1.0 and is removed from drupal:11.0.0. Use
           Use \Drupal\Core\Utility\Error::logException() instead.
 ------ -----------------------------------------------------------

Added phpcs, cspell and eslint fixes. Pipeline is green, MR!22 is ready for review.

Added fixed for phpstan and phpstan (max PHP version), left comments in MR!22.

Add basic .gitlab-ci.yml and phpstan.neon (for phpstan) files.

I'm going to work on this and will return tomorrow with the results.

deimos → created an issue.

Tested on Drupal 11.1.3, module works as expected.
RTBC +1

@manishvaity Thank you for your work to get this module D11 ready.
I added a few corrections/additions, fixes reported by Drupal Rector, and basic .gitlab-ci.yml.
I leave a comment in MR about core_version_requirement, I think it makes sense.
Put the task back into Needs Review for someone to review.

deimos → made their first commit to this issue’s fork.

Issue reported by Update Status module can be ignored till Drupal 12 release.

================================================================================
Config Override Warn, --
Scanned on Tue, 03/04/2025 - 20:32

FILE: web/modules/contrib/config_override_warn/config_override_warn.module

STATUS         LINE                           MESSAGE                           
--------------------------------------------------------------------------------
Ignore         32   Call to deprecated method renderPlain() of class            
                    Drupal\Core\Render\Renderer. Deprecated in drupal:10.3.0 and
                    is removed from drupal:12.0.0. Use                          
                    Drupal\Core\Render\RendererInterface::renderInIsolation()   
                    instead.                                                    
--------------------------------------------------------------------------------

Greetings,

I merged bot's changes and added corrections to get tests green. They were failed due to changes done in 📌 Correct spelling in Config tests Fixed , specifically this changes.
Also I checked test on D11 and added fixes to get them working as well.
Changes were pushed into 3428552-automated-drupal-11

deimos → changed the visibility of the branch project-update-bot-only to active.

deimos → changed the visibility of the branch project-update-bot-only to hidden.

I added some workaround to solve issue. You're welcome to provide any better fix for this issue :)

deimos → created an issue.

Patch solves my problem.
Thank you.

+

Hi,

During project (site) preparation to the D10 I tried latest module's dev version, i.e. composer require 'drupal/ldap:4.x-dev@dev' --with-all-dependencies
And I can confirm that the module basically works with D10 after upgrade from D9. (I haven't got a chance to test the module on actual site after upgrade to D10 yet.)
Here is a short info about environment setup:

• Core - 10.0.9
• PHP - 8.1.20
• MariaDB - 10.4.28-MariaDB-1:10.4.28+maria~ubu2004-log

For LDAP server I used setup provided by LDAP module itself - Hogwarts

Before upgrade from D9 to D10 I run upgrade-status analysis (drush upgrade_status:analyze ldap) and got the following report. So I added fixed based on it (see attached patch file).

Also I run unit-tests after upgrade to D10 and got a couple of PHP errors like
PHPUnit\Framework\Exception: PHP Fatal error: Declaration of Drupal\ldap_servers_dummy\FakeQuery::execute() must be compatible with Symfony\Component\Ldap\Adapter\QueryInterface::execute() So patch-file has corrections for that too.

In general, patch-file provides:
- Add ->accessCheck()
- Fix PHP Fatal error in tests

Patch file doesn't provide (I skipped that because don't feel confident to fix LDAP module's tests):
- Fixes in tests when deprecated PHPUnit methods are used. For example, Call to deprecated method setMethods() of class PHPUnit\Framework\MockObject\MockBuilder

Patch #2 works fine for me, tested on the fresh D9 installation with local LDAP server and users specified in docs/hogwarts
+1 to RTBC

Module works fine on D10 with changes in MR!6 Plus patches listed in #3273674-2 💬 Drupal 8/9 version? Active

"drupal/trailing_slash": {
                "PHP version 7.1.22 incompatibility (https://www.drupal.org/project/trailing_slash/issues/3016988)": "https://git.drupalcode.org/project/trailing_slash/-/merge_requests/2.diff",
                "TrailingSlashUrlGenerator issue with PHP 8 (https://www.drupal.org/project/trailing_slash/issues/3253681)": "https://git.drupalcode.org/project/trailing_slash/-/merge_requests/5.diff",
                "Notice on SettingsForm file (https://www.drupal.org/project/trailing_slash/issues/3206933)": "https://git.drupalcode.org/project/trailing_slash/-/merge_requests/3.diff",
                "Handle access permissions to configuration (https://www.drupal.org/project/trailing_slash/issues/3106821)": "https://git.drupalcode.org/project/trailing_slash/-/merge_requests/4.diff"
            }

deimos → created an issue.

Sorry, I messed up branches a little bit.
Please ignore 3305370-automated-drupal-10 branch.
Also I tried to add additional commit into 2.0.x and got issue with that because there already is branch with such name in original module's repo.

I created a new branch with changes from #19 📌 Automated Drupal 10 compatibility fixes Needs review
plus fix for

PHP Fatal error:  Declaration of Drupal\webhooks\WebhooksService::encode($data, $format, array $context = []) must be compatible with Symfony\Component\Serializer\Encoder\EncoderInterface::encode(mixed $data, string $format, array $context = []): string in /var/www/html/docroot/modules/contrib/webhooks/src/WebhooksService.php on line 331

Fatal error: Declaration of Drupal\webhooks\WebhooksService::encode($data, $format, array $context = []) must be compatible with Symfony\Component\Serializer\Encoder\EncoderInterface::encode(mixed $data, string $format, array $context = []): string in /var/www/html/docroot/modules/contrib/webhooks/src/WebhooksService.php on line 331

Created patch file based on MR!2.

Attached patch file.

deimos → created an issue.

Oh, nevermind :) I figured out, it's already working as needed and messages about deprecation is false-alarm.

- Get and set index:
-- Drupal\jsonapi_search_api_facets\Plugin\facets\facet_source\JsonApiFacets::create()
-- Drupal\jsonapi_search_api_facets\Plugin\facets\facet_source\JsonApiFacets::__construct()
- ::getIndex() implementation - Drupal\jsonapi_search_api_facets\Plugin\facets\facet_source\JsonApiFacets::getIndex()

deimos → created an issue.

Attach patch file.

deimos → created an issue.

Set request method with more compact way.

@swilmes Thanks for requesting this feature. I've just faced the same case when I need to request endpoint with POST method. Your approach looks good, I just reformat it a little bit (fork and MR is created).
Needs review and testing.

deimos → made their first commit to this issue’s fork.

bohart → credited deimos → .

'Rabbit hole' field type and appropriate widget is implemented.
Field formatter can be skipped because without it field still works fine but is disabled at 'Manage display' page.

I'll work on this during #LutskGCW23