🇺🇦Ukraine @deimos

Patch solves my problem.
Thank you.

+

Hi,

During project (site) preparation to the D10 I tried latest module's dev version, i.e. composer require 'drupal/ldap:4.x-dev@dev' --with-all-dependencies
And I can confirm that the module basically works with D10 after upgrade from D9. (I haven't got a chance to test the module on actual site after upgrade to D10 yet.)
Here is a short info about environment setup:

• Core - 10.0.9
• PHP - 8.1.20
• MariaDB - 10.4.28-MariaDB-1:10.4.28+maria~ubu2004-log

For LDAP server I used setup provided by LDAP module itself - Hogwarts

Before upgrade from D9 to D10 I run upgrade-status analysis (drush upgrade_status:analyze ldap) and got the following report. So I added fixed based on it (see attached patch file).

Also I run unit-tests after upgrade to D10 and got a couple of PHP errors like
PHPUnit\Framework\Exception: PHP Fatal error: Declaration of Drupal\ldap_servers_dummy\FakeQuery::execute() must be compatible with Symfony\Component\Ldap\Adapter\QueryInterface::execute() So patch-file has corrections for that too.

In general, patch-file provides:
- Add ->accessCheck()
- Fix PHP Fatal error in tests

Patch file doesn't provide (I skipped that because don't feel confident to fix LDAP module's tests):
- Fixes in tests when deprecated PHPUnit methods are used. For example, Call to deprecated method setMethods() of class PHPUnit\Framework\MockObject\MockBuilder

Patch #2 works fine for me, tested on the fresh D9 installation with local LDAP server and users specified in docs/hogwarts
+1 to RTBC

Module works fine on D10 with changes in MR!6 Plus patches listed in #3273674-2 💬 Drupal 8/9 version? Active

"drupal/trailing_slash": {
                "PHP version 7.1.22 incompatibility (https://www.drupal.org/project/trailing_slash/issues/3016988)": "https://git.drupalcode.org/project/trailing_slash/-/merge_requests/2.diff",
                "TrailingSlashUrlGenerator issue with PHP 8 (https://www.drupal.org/project/trailing_slash/issues/3253681)": "https://git.drupalcode.org/project/trailing_slash/-/merge_requests/5.diff",
                "Notice on SettingsForm file (https://www.drupal.org/project/trailing_slash/issues/3206933)": "https://git.drupalcode.org/project/trailing_slash/-/merge_requests/3.diff",
                "Handle access permissions to configuration (https://www.drupal.org/project/trailing_slash/issues/3106821)": "https://git.drupalcode.org/project/trailing_slash/-/merge_requests/4.diff"
            }

deimos → created an issue.

Sorry, I messed up branches a little bit.
Please ignore 3305370-automated-drupal-10 branch.
Also I tried to add additional commit into 2.0.x and got issue with that because there already is branch with such name in original module's repo.

I created a new branch with changes from #19 📌 Automated Drupal 10 compatibility fixes Needs review
plus fix for

PHP Fatal error:  Declaration of Drupal\webhooks\WebhooksService::encode($data, $format, array $context = []) must be compatible with Symfony\Component\Serializer\Encoder\EncoderInterface::encode(mixed $data, string $format, array $context = []): string in /var/www/html/docroot/modules/contrib/webhooks/src/WebhooksService.php on line 331

Fatal error: Declaration of Drupal\webhooks\WebhooksService::encode($data, $format, array $context = []) must be compatible with Symfony\Component\Serializer\Encoder\EncoderInterface::encode(mixed $data, string $format, array $context = []): string in /var/www/html/docroot/modules/contrib/webhooks/src/WebhooksService.php on line 331

Created patch file based on MR!2.

Attached patch file.

deimos → created an issue.

Oh, nevermind :) I figured out, it's already working as needed and messages about deprecation is false-alarm.

- Get and set index:
-- Drupal\jsonapi_search_api_facets\Plugin\facets\facet_source\JsonApiFacets::create()
-- Drupal\jsonapi_search_api_facets\Plugin\facets\facet_source\JsonApiFacets::__construct()
- ::getIndex() implementation - Drupal\jsonapi_search_api_facets\Plugin\facets\facet_source\JsonApiFacets::getIndex()

deimos → created an issue.

Attach patch file.

deimos → created an issue.

Set request method with more compact way.

@swilmes Thanks for requesting this feature. I've just faced the same case when I need to request endpoint with POST method. Your approach looks good, I just reformat it a little bit (fork and MR is created).
Needs review and testing.

deimos → made their first commit to this issue’s fork.

bohart → credited deimos → .

'Rabbit hole' field type and appropriate widget is implemented.
Field formatter can be skipped because without it field still works fine but is disabled at 'Manage display' page.

I'll work on this during #LutskGCW23