Automatically copy values from old base fields to new config field

Igor Mashevskyi → made their first commit to this issue’s fork.

In the context of 📌 Use Rabbit Hole values from config field instead of base fields Fixed we changed the default value of the allow_override option.
Therefore, we have to consider the following case:
If the entity type used the default settings, then we need to create a personal configuration and set allow_override: 1

@HitchShock, thanks for the heads-up! I checked this scenario and it seems we're safe here:
1) The "Rabbit Hole" field and field values are copied properly in update hooks;
2) After the upgrade, it still works because existing installations will have allow_override: 1 in default settings;

Speaking of allow_override, I'm evaluating possible removal of this property from config object. I think it can represent the presence of the field instead of the config value. If field exists, then override is allowed. More details here: 📌 Remove "allow_override" property from rabbit_hole.behavior_settings.* configs Fixed .

__

I put some changes in the MR including test for the update.

Hi @matroskeen
Tested the solution:

• Installed an empty project
• Created two CTs: A and B
• Installed 8.x-1.0-beta11 version of the module
• Enabled Rabbit Hole nodes
• Kept a default settings for A
• B - Disabled allow_override option and set behavior "Page not found"
• Created two CTs: C and D
• C - Enabled allow_override option and set behavior "Access denied"
• D - Disabled allow_override option and set behavior "Page redirect"
• Made several nodes for A and C CTs with different own RH settings
• Switched to the MR branch
• Ran `druah updb -y`
• Rechecked RH settings for all CTs that I created - settings are still the same which means that hook_update works as expected

The MR is merged with some minor changes added in the latest commits. 🥳

Kudos to @HitchShock for the review and to @Igor Mashevskyi for the initial development.

Automatically closed - issue fixed for 2 weeks with no activity.