t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead.

Issue created by @Rohit Rana
Issue was unassigned.
Status changed to Needs review about 1 year ago11:02am 12 October 2023
Open in Jenkins → Open on Drupal.org →
Core: 10.1.4 + Environment: PHP 7.4 & MySQL 8
last update about 1 year ago
Composer require failure
Comment about 1 year ago →
🇮🇳India Rohit Rana
Open in Jenkins → Open on Drupal.org →
Core: 10.1.x + Environment: PHP 8.1 & sqlite-3.27
last update about 1 year ago
2 pass
Status changed to Needs work about 1 year ago6:04am 31 October 2023
Comment about 1 year ago →
🇮🇳India AditiVB
Due to failure moving this to need Work
Assigned to AditiVB
Comment about 1 year ago →
🇮🇳India AditiVB
i am checking this issue .
Comment about 1 year ago →
🇮🇳India AditiVB
i have uploaded patch , please review .
Status changed to Needs review about 1 year ago9:14am 31 October 2023
Open in Jenkins → Open on Drupal.org →
Core: 10.1.4 + Environment: PHP 7.4 & MySQL 8
last update about 1 year ago
Composer require failure
Comment about 1 year ago →
🇮🇳India AditiVB
Issue was unassigned.
Comment about 1 year ago →
🇮🇳India AditiVB
Open in Jenkins → Open on Drupal.org →
Core: 10.1.4 + Environment: PHP 7.4 & MySQL 8
last update about 1 year ago
Composer require failure
Comment about 1 year ago →
🇮🇳India AditiVB
Comment about 1 year ago →
🇮🇳India Raveen Kumar
Absolutely, in Drupal 8 and 9, the t() function is indeed discouraged for use within classes. Instead, you can use the \Drupal\Core\StringTranslation\StringTranslationTrait and the $this->t() method for translation within classes.
First commit to issue fork.
Merge request !7Resolve #3393576 "t() calls should be avoided in classes" → (Merged) created by admirlju
Open on Drupal.org →
Core: 10.1.4 + Environment: PHP 7.4 & MySQL 8
last update about 1 year ago
Not currently mergeable.
Open in Jenkins → Open on Drupal.org →
Core: 10.1.4 + Environment: PHP 7.4 & MySQL 8
last update about 1 year ago
Unable to generate test groups
Open in Jenkins → Open on Drupal.org →
Core: 10.1.4 + Environment: PHP 7.4 & MySQL 8
last update about 1 year ago
Unable to generate test groups
Open in Jenkins → Open on Drupal.org →
Core: 10.1.4 + Environment: PHP 7.4 & MySQL 8
last update about 1 year ago
Unable to generate test groups
Pipeline finished with Success
about 1 year ago
Total: 201s
#53721
Open in Jenkins → Open on Drupal.org →
Core: 10.1.4 + Environment: PHP 7.4 & MySQL 8
last update about 1 year ago
Unable to generate test groups
Comment about 1 year ago →
admirlju
Created an issue fork, and applied the patches. Locally the tests are passing, but because Drupal CI is deprecated, they will not pass with that. So I just added a basic gitlab-ci. And from what I see they are passing there. Still because of some CS fixes I'll leave this as needs review.
Pipeline finished with Success
about 1 year ago
Total: 200s
#53723
Status changed to Needs work 2 months ago7:07pm 16 October 2024
Comment 2 months ago →
🇺🇦Ukraine bohart Lutsk, Ukraine
After the latest changes at 8.x-1.x-dev branch, it looks like all changes at DuplicateRoleForm.php and .gitlab-ci.yml files must be removed from MR !7.

Marking this one as Needs work.
Comment 2 months ago →
🇺🇦Ukraine alt.dev
alt.dev → made their first commit to this issue’s fork.
Pipeline finished with Failed
2 months ago
Total: 601s
#311857
Comment 2 months ago →
System Message

bohart → committed 898f9e4c on 8.x-1.x authored by admirlju →
Issue #3393576 by admirlju, Aditi Saraf, alt.dev, bohart: t() calls...
Comment 2 months ago →
🇺🇦Ukraine bohart Lutsk, Ukraine
Merged. The changes will be a part of the next module release. Thanks!
Comment about 2 months ago →
System Message
Automatically closed - issue fixed for 2 weeks with no activity.

t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead.

Problem/Motivation

Merge Requests

!7t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead.
Merged

Comments & Activities

t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead.

Problem/Motivation

Merge Requests

!7t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead.Merged

Comments & Activities

!7t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead.
Merged