Drupal 11 Compatibility

I have made some changes. Please refer to attached patch.

Thank you so much @ananya.k!
I was able to install the patch without any problems. I will test the functionality after the Drupal 11 upgrade (I'm currently in the preparation stages).

olmyr → changed the visibility of the branch 3479745-drupal-11-compatibility to hidden.

Hmm...thanks for the work here, I wonder if we need to wait for ACL to have a Drupal 11 version: 📌 Automated Drupal 11 compatibility fixes for acl Needs review

I wonder if we could get most of these changes into our module anyway, and leave off actual Drupal 11 support until ACL has it.

Thank you, olmyr!
The merge request !16 seems to work very well with Drupal 10.3.6.
I will test the functionality after the Drupal 11 upgrade (I'm currently in the preparation stages).

@steven jones
I was not aware of the dependency with ACL.
Unfortunately, I cannot yet test whether Content Access works correctly with Drupal 11 (despite the lacking Drupal 11 version for ACL), as I cannot yet upgrade from Drupal 10.3.6 to Drupal 11 (PHP 8.3 is missing).
Do you think that it is not possible to install Drupal 11 as long as there is no Drupal 11 version for ACL?

Ah, ACL is an optional dependency, so I think we can upgrade to Drupal 11 before ACL, we just can't test with ACL at the moment.

I attach the latest patch from the MR just in case this task won't be merged soon.

I can now confirm that the patch works with Drupal 11.0.5 (I have not installed ACL because I do not need the functionality).

Verified changes from MR !16 in Drupal 10 and Drupal 11, functionality is working fine.
RTBC +1

I had trouble installing the patch with Drupal 10.3.10, apparently some of the modifications on the content_access.module file can not be applied (the changed order in the use statements). I recreated a patch by changing just that and it works for me. I leave the patch here in case someone stumbles upon the same issue.

RTBC+1, this would unlock a test blocker for other modules on Drupal 11 who depend on this.

I confirm #16: The MR did not apply to the latest dev, but patch from #17 did.

The MR applies nicely, so I'm wondering which code base you've tried to patch. Was it 2.0.0 or 2.0.x-dev?

@jurgenhaas: apologies, tried this today on another project that I have now successfully updated from D10.4 to D11.1.
The MR applied and all seems to be working. No idea why the MR did not apply to the other project, probably a confmicting patch or something.

I have used this module on Drupal-7, 9 and 10 websites. Looking forward for Drupal-11 version. Thanks.

Please release the D11 version!

ACL just got a stable release for Drupal 11, so we should be able to progress this properly now.

Let's go back to reviewing the MR.

All tests are passing in Drupal 10 and 11!

Spotted that we've got a function exists call that might be masking something, committed removing that and will see if the tests still pass, if they do then I think we can cut a 2.1.0-rc1 release.

Okay, that seems to still work, I'd rather get the fatal error if it is coded wrong and the bug reports than silently ignoring it at runtime.

2.1.0-rc1 here we come.

Made the release: https://www.drupal.org/project/content_access/releases/2.1.0-rc1 →

Thanks everyone for the work on providing code and testing, much appreciated.

Automatically closed - issue fixed for 2 weeks with no activity.