- Issue created by @alt.dev
- @altdev opened merge request.
- Status changed to Needs review
over 1 year ago 11:02am 18 September 2023 - 🇺🇦Ukraine alt.dev
I updated the module a little bit, and made the following changes:
- Added composer.json file;
- Moved sensitive data to state;
- Added config/install and config/schema files;
- Created custom graph_mail key type.
- Added integration with the key module;
- Fixed critical issue when the getEmailFromString method couldn't extract email from the string;
- Fixed the logic when default email didn't use by default.
- Re-worked the mail plugin to make it use objects instead of the array as the mail argument;
- Created the GraphMailHelper service.
- Wrote the hook_update function that moves sensitive data from config to state.
- Added configuration to the info file. Created the menu item for the module configuration form.
- Code cleanup/optimization.
What needs to be done is to add tests.
When I created this issue I saw that we have the 2.0 version of the module, but it's not compatible with Drupal <10 version.
I think we can migrate some logic from this issue to the 2.0 version later. - Status changed to Needs work
about 1 year ago 5:23pm 25 September 2023 - 🇧🇪Belgium BramDriesen Belgium 🇧🇪
This is not reviewable. This should have been split into different issues. Merging this will potentially break all other patches which are RTBC in the issue queue.
- 🇧🇪Belgium BramDriesen Belgium 🇧🇪
E.g. this includes a duplicate fix of ✨ Adds "configure" links. RTBC
- First commit to issue fork.
- 🇧🇪Belgium BramDriesen Belgium 🇧🇪
Please, focus your effort on small increments. This will never ever get merged like this.
I suggest to start splitting things up and ignore things which are duplicated with the other issues.
- Status changed to Closed: won't fix
about 1 year ago 1:21pm 26 September 2023 - 🇮🇹Italy apaderno Brescia, 🇮🇹
This issue is covering too much different problems. If there are issues to be resolved, they must be created separately, with an adequate description for each of them.
Clean up code(remove deprecations), Improve code quality, or Hide sensitive data are too broad descriptions which do not make clear what exactly needs to be changed. - 🇮🇹Italy apaderno Brescia, 🇮🇹
The composer.json file has been added in 📌 Add the composer.json file Active , in the 2.0.x branch.