Fix the issues reported by phpcs

Open on Drupal.org →

Created on 4 April 2023, over 1 year ago

Updated 7 January 2024, 9 months ago

Problem/Motivation

FILE: C:\xampp\htdocs\backendassignment\web\modules\contrib\delete_entity_translations-3352083\delete_entity_translations.module
--------------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------------------------------------------------------------
1 | ERROR | [x] End of line character is invalid; expected "\n" but found "\r\n"
--------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------------------------------------------------------

FILE: C:\xampp\htdocs\backendassignment\web\modules\contrib\delete_entity_translations-3352083\src\Form\DeleteEntityTranslationsForm.php
----------------------------------------------------------------------------------------------------------------------------------------
FOUND 3 ERRORS AFFECTING 3 LINES
----------------------------------------------------------------------------------------------------------------------------------------
1 | ERROR | [x] End of line character is invalid; expected "\n" but found "\r\n"
19 | ERROR | [ ] Missing @var tag in member variable comment
24 | ERROR | [ ] Missing @var tag in member variable comment
----------------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------------------------------------------------------------------------

FILE: C:\xampp\htdocs\backendassignment\web\modules\contrib\delete_entity_translations-3352083\tests\src\Functional\DeleteEntityTranslationsTest.php
----------------------------------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
----------------------------------------------------------------------------------------------------------------------------------------------------
1 | ERROR | [x] End of line character is invalid; expected "\n" but found "\r\n"
----------------------------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------------------------------------------------------------------------------------

Time: 1.15 secs; Memory: 6MB

Steps to reproduce

Run the codesniffer command on the module.

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

📌 Task

Status

Closed: cannot reproduce

Version

1.0

Component

Code

Created by

🇮🇳India sidharth_soman Bangalore

Live updates comments and jobs are added and updated live.

Coding standards
It involves compliance with, or the content of coding standards. Requires broad community agreement.

Sign in to follow issues

Merge Requests

!1Fix the issues reported by phpcs
Closed
🇮🇳India sidharth_soman
updated 9 months ago

Comments & Activities

Issue created by @sidharth_soman
Comment over 1 year ago →
🇮🇳India sidharth_soman Bangalore
Status changed to Needs work over 1 year ago10:10am 4 April 2023
Comment over 1 year ago →
🇮🇳India sidharth_soman Bangalore
I am working on fixing the above issues.
Merge request !1Fixed phpcs issues. → (Closed) created by sidharth_soman
Issue was unassigned.
Status changed to Needs review over 1 year ago10:14am 4 April 2023
Comment over 1 year ago →
🇮🇳India sidharth_soman Bangalore
I have fixed the issues... and issued an MR for the same.
Please review. Thanks.
Comment over 1 year ago →
fromme
Hello, sidharth_soman.
Thanks for your suggestion.

Delete entity translations module marked as works with Drupal: ^9 || ^10.
According PHP requirements Drupal 9.4 dropped official support for PHP 7.3 → . Sites on PHP 7.3 may still be installed and updated to Drupal 9.4 (with a warning), but their security coverage is not guaranteed unless they update to at least PHP 7.4.

And since PHP 7.4 there is no need for a @var tag in the docblock when the property is typehinted ( https://www.drupal.org/project/coding_standards/issues/3291517#:~:text=W... → .)

According this information i think the proposed updates are reduntal.
Status changed to Active over 1 year ago1:16pm 14 April 2023
Comment over 1 year ago →
fromme
Comment 9 months ago →
🇮🇳India Prem Suthar gujrat
Not Reproduced any error while running the this cmd :- ./vendor/bin/phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,info,txt,md,css,js,yml web/modules/custom/delete_entity_translations
Status changed to Closed: cannot reproduce 9 months ago6:32am 21 December 2023
Comment 9 months ago →
fromme
Comment 9 months ago →
System Message
fromme → closed merge request !1

contrib.social Blog FAQ Discussions

Production build 0.71.5 2024