- Issue created by @kingdutch
- Issue was unassigned.
- Status changed to Needs review
over 1 year ago 8:39pm 25 July 2023 - last update
over 1 year ago 29,880 pass, 2 fail The last submitted patch, 2: drupal-3376942-2.patch, failed testing. View results →
- First commit to issue fork.
- Merge request !8629Replace generateString() with generate() in MediaStandardProfileTest → (Closed) created by fromme
- Status changed to Needs review
7 months ago 12:16pm 2 July 2024 In
drupal-3376942-2.patchthe method toString() was applied incorrectly. Fixed and opened MR. All tests passed, so i moving issue to review.- Status changed to Needs work
7 months ago 2:26pm 2 July 2024 - 🇺🇸United States smustgrave
Also looking at 📌 Replace usage of generateString with generate in MediaDisplayTest Needs work and 📌 Replace usage of generateString with generate in MediaSourceImageTest Needs review believe the correct scope would to replace generateString in the "Media" module vs per file. So can the other two be closed out and merged into this one please. Then can mark as seems straightforward
- Status changed to Needs review
7 months ago 7:11am 4 July 2024 Changes from tasks 📌 Replace usage of generateString with generate in MediaDisplayTest Needs work and 📌 Replace usage of generateString with generate in MediaSourceImageTest Needs review merged into current branch and closed as duplicates.
- Status changed to RTBC
7 months ago 1:22pm 4 July 2024 - 🇺🇸United States smustgrave
Thanks for taking care of that so quickly! Changes look good
- Status changed to Fixed
7 months ago 11:31pm 12 July 2024 - 🇬🇧United Kingdom catch
Committed/pushed to 11.x and cherry-picked back through to 10.3.x, thanks!
Automatically closed - issue fixed for 2 weeks with no activity.