- Issue created by @Kristen Pol
- 🇺🇸United States Kristen Pol Santa Cruz, CA, USA
Moving this from project_browser queue to project queue per @leslieg.
- Assigned to manojsaha
- Issue was unassigned.
- Status changed to Needs review
3 months ago 5:16am 9 September 2024 Hi @manojsaha,
Thanks for your contribution! The logo perfectly aligns with the PB logo
constraints as well as it also aligns with the module's functionality. Hence moving this forward RTBC++- 🇺🇸United States danflanagan8 St. Louis, US
it also aligns with the module's functionality
I don't know that I agree with this. To me it looks like the logo is for a form builder or something like that. I don't have any great ideas, but I can't say I convinced this is a good choice. I showed another maintainer and he was skeptical as well.
I also think we should keep in mind that this logo doesn't seem to be rendered at 512px very often. On a project page it's 60px wide. And within entity browser it's more like 256px or something. This logo is not great at 60px:
Hi @danflanagan8,
Thanks for your valuable feedback! We can certainly have a look at an alternative but I'm quite sceptical on one point: Trying to make the logo nice and clear on a 48X48 dimension will make it look more like an icon rather than a logo. I'm not sure why we're concerned about how gitlab renders it! The project browser logo is intended to be shown on 'Browse Projects' page, for which as you've mentioned 60X60 can be a good starting point to keep in mind while making the proposed changes. On an attempt to make it prominent on 48X48 will make the logo more busy which will rather seem to be having much negative spaces on a larger dimension.- 🇺🇸United States danflanagan8 St. Louis, US
I'm not sure why we're concerned about how gitlab renders it!
Because that's one of the essential uses of this logo! See the IS:
as well as on drupalcode.org as your project avatar
Thinking of it as an icon is a good idea in my opinion. Here are some effective examples:
Token:
Redirect:
Search API:
And here's one I created for a project I maintain:
The issue for that one shows that I made the misstep of making things too complicated at first as well. 📌 Project Browser: Create a logo for Crossword Fixed
We need to keep it simple.
Hi @danflanagan8,
Sorry for the delay, I was on vacation in the mean time! Came up with one more with less busy stuff! Please have a look at it once and let me know your thoughts!- 🇺🇸United States danflanagan8 St. Louis, US
Hi @sourojeetpaul!
I really like this part of your new logo:
What if we make that the entire logo? That would look great at all sizes. It's also a good representation of the module, right? We're looking into the database and seeing the relationships.
I'm going to set back to NW, but I think we're really close to a good solution now!
Yes @danflanagan8, You got me right! That's what I thought while creating this version as basically Drupal View is used like a 'query builder' with an ability to create 'relationships' to fetch data accordingly, I came up with this one.
And obviously it'll look good in smaller dimensions as you've mentioned earlier. Attaching the new one here. Please have a look and let me know, should I open the corresponding MR!- 🇺🇸United States danflanagan8 St. Louis, US
I think #11 looks great, @sourojeetpaul.
If you put that in an MR, I'll happily merge it. :)
- 🇺🇸United States danflanagan8 St. Louis, US
Back to NW just to get that logo in an MR. Thanks!
@danflanagan8, Thanks for the approval. Raised the MR, please check now!
-
danflanagan8 →
committed 326753fd on 8.x-3.x authored by
sourojeetpaul →
Issue #3459466 by sourojeetpaul, danflanagan8, manojsaha, kristen pol:...
-
danflanagan8 →
committed 326753fd on 8.x-3.x authored by
sourojeetpaul →
- Status changed to Fixed
about 1 month ago 7:38pm 8 November 2024 - 🇺🇸United States danflanagan8 St. Louis, US
Merged! Nice work, all!
Thanks @danflanagan8, for shipping the logo in and for the recognition :)
Automatically closed - issue fixed for 2 weeks with no activity.