- First commit to issue fork.
- 🇺🇸United States nairb
I reviewed the properties marked as unused in the Project file. I found that 'selector_id' is being used but no others are referenced from any svelte files.
- last update
over 1 year ago 65 pass - last update
over 1 year ago 65 pass - last update
over 1 year ago 36 pass, 4 fail - last update
over 1 year ago 36 pass, 4 fail - last update
over 1 year ago 65 pass - 🇺🇸United States nairb
I removed some parameters from the public function, since they are not needed in Svelte. Although, I left the private functions to set those parameters, since they are used when getting the project data from drupal.org, and we'll probably want to have that in case there is a need to display that info.
The Star User Count is never used and is only ever set to a static value. So this could likely be removed completely.
- Status changed to Needs review
about 1 year ago 2:10pm 28 June 2023 - 🇺🇸United States chrisfromredfin Portland, Maine
This looks good and tests are passing. However, I'd like Tim or Fran to give it a review first.
- Status changed to Needs work
about 1 year ago 3:33pm 28 June 2023 - 🇪🇸Spain fjgarlin
I think that if we are going to remove the exposed properties because they are not used, then we should also remove all the associated methods, like setters and getters.
For example: https://git.drupalcode.org/search?search=setIsActive&nav_source=navbar&p...
- 🇺🇸United States chrisfromredfin Portland, Maine
chrisfromredfin → changed the visibility of the branch 3309273-audit-the-unused to hidden.
- Merge request !459check all properties against svelte usage and remove unnecessary cruft → (Open) created by chrisfromredfin
- Status changed to Needs review
4 months ago 9:57pm 1 May 2024 - 🇺🇸United States chrisfromredfin Portland, Maine
I've refactored this since the previous one was so dated, but I think this is better and spreads deeper into the codebase; would love Fran to look at it.
- Status changed to Needs work
4 months ago 8:19am 2 May 2024 - 🇪🇸Spain fjgarlin
I left some feedback in the MR. If we are cleaning up purely based on what's shown in the svelte templates, then it might be ok, but there are certain properties that are in use one way or another (ie: via filters) or that should be used but might be not (ie: URL).