- ๐บ๐ธUnited States chrisfromredfin Portland, Maine
With manual testing, prior to applying this MR - all messages show (two status messages and the error). When applied, only the error shows (now correctly as a warning, though). What happened to the other messages?
- ๐ฆ๐บAustralia sime Canberra
Ya know, I think this is RTBC. Feels solid to me. Will let Chris have the final say.
- ๐ฆ๐บAustralia sime Canberra
For anyone who wants to manually test this, a simple way is to install the project_browser_test module.
1. You need this in your settings.php, note that it will start showing test modules/themes in the UI.
$settings['extension_discovery_scan_tests'] = TRUE;
2. Then install project_browser_test, I just use drush.
3. Now in TestInstallerReadiness.php in the statusCheck method, just change the code to manual create whatever messages you want to create.
- ๐ฆ๐บAustralia sime Canberra
Changes I made result in this:
The worst case scenario is two messages of the same type, thus showing the same prefix, but I think this is acceptable as it's very rare and looks fine.
- ๐ฆ๐บAustralia sime Canberra
I'm just going to combined these up a little. It would be rare to have multiple errors here, I believe, so we'll just prefix each one and skip the extra ones?