- Issue created by @chrisfromredfin
- ๐ฎ๐ณIndia lavanyatalwar
Hi @chrisfromredfin,
I was trying to reproduce the issue and just want to make sure Iโm understanding it correctly. Iโve attached a screenshot, please let me know if Iโve got it right. - Merge request !701#Issue:3503197-Fixed the Installed button indentation. โ (Merged) created by lavanyatalwar
- ๐ฎ๐ณIndia lavanyatalwar
Hi @chrisfromredfin,
Iโve resolved this issue and am attaching screenshots for your reference.
Please have a look and let me know if any further changes are required. - ๐ฎ๐ณIndia utkarsh_33
@chrisfromredfin I just checked this and the issue is only with the Gin theme.Attaching the SS for claro.It looks fine there.
Also marking it NW as the SS provided in #6 does not seems to fix the problem. - ๐ฎ๐ณIndia utkarsh_33
I think this might require some changes in the svg files.@lavanyatalwar can you try that?
- ๐ฎ๐ณIndia lavanyatalwar
Hi @utkarsh_33,
I donโt think the changes to the SVG are necessary. I made some adjustments, like using display: flex and align-items: center on the span, and I think it looks fine now.
Iโm attaching a screenshot, please have a look. - ๐ฎ๐ณIndia lavanyatalwar
If the screenshot looks good to you, should I go ahead and update the MR ?
- ๐ฎ๐ณIndia lavanyatalwar
@utkarsh_33,
Done with the changes. Kindly check and merge :) - ๐ฎ๐ณIndia utkarsh_33
@lavanyatalwar the changes related to installed text looks good to me.I still think either we need to decrease the height of wrench icon or increase the pixels for both installed text and security icon.
This could also be done in a separate issue.I'll let @chrisfromredfin decide what will be a better approach.
Also it would be helpful to get Chris's feedback by pinging in Drupal slack's PB channel. - ๐ฎ๐ณIndia snehal-chibde
Hello @utkarsh_33 and lavanyatalwar , I have reproduced the issue successfully.
I have tested MR by lavanyatalwar on the Drupal 10.4.1 version, Module version 2.0.x-dev.
The MR is applied cleanly.The installed button is now aligned correctly. Added both gin and claro theme screenshots for reference.
- ๐บ๐ธUnited States chrisfromredfin Portland, Maine
If people can browser test this on Drupal 11, with Firefox, Safari, and some Chrome-based browser, they can move this to RTBC.
- ๐ฎ๐ณIndia snehal-chibde
hello @chrisfromredfin, I have tested the issue on Drupal 11, with Firefox, and Chrome browser. The installed button is aligned correctly on drupal 11. Tested with both gin and claro theme, added the screenshots for reference.
-
chrisfromredfin โ
committed 22f457e3 on 2.0.x authored by
lavanyatalwar โ
Issue #3503197: Installed button height misaligned
-
chrisfromredfin โ
committed 22f457e3 on 2.0.x authored by
lavanyatalwar โ
- ๐บ๐ธUnited States chrisfromredfin Portland, Maine
big bang for the buck. this bothered me so much! thanks, everyone :)
Automatically closed - issue fixed for 2 weeks with no activity.