- Issue created by @tedbow
- πΊπΈUnited States phenaproxima Massachusetts
I don't know if we necessarily want to bother admins with this information all the time (i.e., we shouldn't show it on the status report, or as a validation warning).
I would suggest that, on status check, UnknownPathExcluder should log the list of excluded paths, at the
info
level. That way, it's available for forensic and informational purposes, but doesn't butt into the UI where it's not useful. - last update
11 months ago 782 pass - last update
11 months ago 782 pass - Assigned to tedbow
- Status changed to Needs review
11 months ago 10:07pm 13 December 2023 - πΊπΈUnited States phenaproxima Massachusetts
I offer for your review, a version of this that logs the excluded paths on status check.
- π§πͺBelgium wim leers Ghent π§πͺπͺπΊ
Always logging excluded paths during
StatusCheckEvent
seems reasonable. Unless β¦ this runs on every Automatic Updates cron update? π€ (I do not recall.) Because with a high enough cron update frequency this would then spam your site's log π - πΊπΈUnited States tedbow Ithaca, NY, USA
@Wim Leers no
\Drupal\automatic_updates\Commands\AutomaticUpdatesCommandBase::runStatusChecks
, which will run the status checks during cron or in a direct running of the `auto-update` script, will not run the status checks more that 1x an hour.Unless the result have been cleared programmatically
- Status changed to Needs work
11 months ago 4:00am 15 December 2023 - πΊπΈUnited States tedbow Ithaca, NY, USA
I think it looks. I have to review it more but I left a comment about updating the log message
- last update
11 months ago 783 pass - Status changed to Needs review
11 months ago 4:13pm 15 December 2023 - πΊπΈUnited States phenaproxima Massachusetts
Per discussion with @tedbow, I beefed up the log message to explain why the paths are excluded, and what if anything should be done about it.
- Assigned to phenaproxima
- Status changed to Needs work
11 months ago 4:35pm 15 December 2023 - last update
11 months ago 783 pass - Assigned to tedbow
- Status changed to Needs review
11 months ago 6:31pm 15 December 2023 - Status changed to RTBC
11 months ago 7:09pm 15 December 2023 - πΊπΈUnited States tedbow Ithaca, NY, USA
@phenaproxima RTBC but please fix the 1 type I pointed out
- last update
11 months ago 783 pass - last update
11 months ago 783 pass -
phenaproxima β
committed e4fe8675 on 3.0.x
Issue #3408560 by phenaproxima, tedbow: If paths are being excluded in...
-
phenaproxima β
committed e4fe8675 on 3.0.x
- Issue was unassigned.
- Status changed to Fixed
11 months ago 7:13pm 15 December 2023 Automatically closed - issue fixed for 2 weeks with no activity.