I created a few issues from @todo's that I found in the codebase.
- π³πΏNew Zealand quietone
I checked that each @todo had a link to an issue. Two were missing links which I have added and made a patch.
And now the search results are:
$ grep -ri @todo . | grep -v .js ./tests/src/Traits/PackageManagerFixtureUtilityTrait.php: // @todo Move back to static::$modules in https://www.drupal.org/i/3349193. ./tests/src/FunctionalJavascript/ProjectBrowserUiTest.php: // @todo Remove try/catch in https://www.drupal.org/i/3349193. ./src/ProjectBrowserServiceProvider.php: // @todo Remove the following Drupal 10.0 autowiring shim in ./src/Controller/InstallerController.php: * @todo add return type when php 7.4 support ends. https://www.drupal.org/i/3348960 ./src/Controller/InstallerController.php: // @todo Expand to support other plugins in https://drupal.org/i/3312354. ./src/ProjectBrowser/Project.php: // @todo Not used in Svelte. Audit in https://www.drupal.org/i/3309273. ./project_browser.libraries.yml: # @todo Add "defer" property to generated <script> tag. https://www.drupal.org/i/3348954 ./drupalci.yml: # @todo Replace in favor of commit-code-check.sh once https://www.drupal.org/project/drupal/issues/3314100 lands. ./scripts/commit-code-check.sh:# @todo https://www.drupal.org/project/drupalci_testbot/issues/3181869
and for ProjectBrowserServiceProvider
$ grep -ri -A1 @todo src/ProjectBrowserServiceProvider.php // @todo Remove the following Drupal 10.0 autowiring shim in // https://www.drupal.org/i/3349193.
Then, I think these two can be closed.
- π @todo Replace in favor of commit-code-check.sh Closed: outdated
- π @todo Color output is disabled on # DrupalCI because it is breaks reporting. Closed: won't fix
- Status changed to Needs review
over 1 year ago 6:44pm 27 April 2023 - Status changed to Fixed
over 1 year ago 7:30pm 6 June 2023 - πΊπΈUnited States chrisfromredfin Portland, Maine
Thanks! The only one I see left is for a PHP return type that could/should be added when we drop 7.4 support. That's a long way off and I think that todo should be removed in another issue. Thanks for your help here!
Automatically closed - issue fixed for 2 weeks with no activity.