andrewozone → credited mike.roman → .
I reviewed the module and noticed no styling regressions as a result of all the class name changes.
(Contributing from MidCamp 2024)
#14 looks good! I like how clearly the information is organized (the two boxes of text) which makes it easy to scan and find out exactly what Drupal Mentoring is and who it's for. I do have a couple of notes:
I googled "skill-set" and evidently it should be "skill set" instead (space instead of a hyphen).
I'm wondering if the Slack icon is enough info for those who see the banner? Would they know that it is the *Slack* icon, or should the full Slack logo (icon + "Slack" in their official brand font) be used instead? Also, would they know that "#mentoring-team" is the *Drupal* Slack (drupal.slack.com if I'm not mistaken)? -- the answer to these could very well be "yes", but I thought I would raise the question just in case.
I got this exact error after a deployment, and it was because I forgot to commit the honeypot.settings.yml file. I wonder if OP did the same thing.
#2 fixed the issue for me
I agree with brianbrarian, so I am going to set this issue to "needs work". The wording in the issue fork is set in sveltejs/src/popup.js line 60, and it is currently:
To use the module you next have to install it on the modules page.
Borrowing heavily from the Installing Modules documentation page → , may I suggest:
Go to the Extend page (admin/modules), check the box next to each module you wish to enable, then click the Install button at the bottom of the page.
And be sure to link "Extend" (or "Extend page") to that page.
I contributed to the Project Browser initiative :)
Taking a look at this at MidCamp 2023. I agree with the above that it should be green. I experimented with just changing the line color of the existing icon, but it looked way too similar to the "Compatible with your Drupal installation" icon, which is a white checkmark inside a green circle on the admin/modules/browse/ctools page (for example):
Changing it to the solid green shield like on drupal.org looks a lot better, and this would be my recommendation:
Note that drupal.org uses a black icon with a green filter over it: filter: opacity(0.5) drop-shadow(0 0 0 #7cbc48) brightness(2). We could do it that way, but I say just make the icon itself green (#7cbc48). The current icon is images/blue-security-shield-icon.svg so the file name will need to be changed along with the icon itself. This file name is also referenced in the code itself, so a find-and-replace will be needed. Finally, there also needs to be a white version of the icon to replace images/blue-security-shield-icon--dark-color-scheme.svg.
There are currently child issues for the logo and the categories, but not for the short description; does a third child issue still need to be created?