- Issue created by @chrisfromredfin
- First commit to issue fork.
- last update
12 months ago Custom Commands Failed - 🇺🇸United States andy-blum Ohio, USA
Marked as ready to kick off an initial round of tests to make sure I'm on the right track.
- 🇺🇸United States chrisfromredfin Portland, Maine
Current fail is due to not running prettier on the codebase before committing, I believe you can just do `yarn prettier` then commit and push.
- last update
12 months ago 56 pass, 2 fail - last update
12 months ago 56 pass, 2 fail - last update
12 months ago 77 pass - last update
12 months ago Custom Commands Failed - last update
12 months ago 77 pass - last update
12 months ago 77 pass - last update
12 months ago 77 pass - last update
12 months ago 57 pass, 4 fail - last update
12 months ago 62 pass, 1 fail - last update
12 months ago 77 pass - last update
12 months ago Custom Commands Failed - last update
12 months ago Custom Commands Failed - last update
12 months ago 77 pass - last update
12 months ago 56 pass, 2 fail - last update
12 months ago 77 pass - last update
12 months ago 51 pass, 6 fail - last update
12 months ago 51 pass, 6 fail - last update
12 months ago 51 pass, 6 fail - last update
12 months ago Custom Commands Failed - last update
12 months ago Custom Commands Failed - last update
12 months ago 30 pass, 8 fail - last update
12 months ago 30 pass, 8 fail - last update
12 months ago 15 pass, 9 fail - last update
12 months ago 30 pass, 8 fail - last update
12 months ago 30 pass, 8 fail - last update
12 months ago 30 pass, 8 fail - last update
11 months ago 56 pass, 2 fail - last update
11 months ago 36 pass, 5 fail - last update
11 months ago 41 pass, 3 fail - last update
10 months ago Custom Commands Failed - last update
10 months ago Custom Commands Failed - last update
10 months ago 56 pass, 2 fail - last update
10 months ago 77 pass - 🇺🇸United States andy-blum Ohio, USA
Adding a comment here just to bump this issue back to the top of my dashboard.
- last update
10 months ago Custom Commands Failed - last update
10 months ago 56 pass, 2 fail - last update
10 months ago 56 pass, 2 fail - Open on Drupal.org →Core: 10.2.x + Environment: PHP 8.1 & MySQL 5.7last update
10 months ago Waiting for branch to pass - last update
10 months ago 77 pass - Open on Drupal.org →Core: 10.2.x + Environment: PHP 8.1 & MySQL 5.7last update
10 months ago Waiting for branch to pass - last update
10 months ago 29 pass, 5 fail - Open on Drupal.org →Core: 10.2.x + Environment: PHP 8.1 & MySQL 5.7last update
9 months ago Waiting for branch to pass 58:43 55:28 Running- First commit to issue fork.
- Open on Drupal.org →Core: 10.2.x + Environment: PHP 8.1 & MySQL 5.7last update
9 months ago Not currently mergeable. - Merge request !1Issue #3389246 by lostcarpark, marcoliver, phenaproxima: InstallerController... → (Open) created by bernardm28
- 🇺🇸United States bernardm28 Tennessee
The issue seemed to be for most test errors that we had .project instead of .pb-project which could not be found.
- Status changed to Needs work
9 months ago 8:44pm 23 February 2024 - last update
9 months ago 66 pass, 2 fail - last update
9 months ago 81 pass, 1 fail - last update
9 months ago 45 pass, 4 fail - last update
9 months ago 81 pass, 1 fail - 🇺🇸United States bernardm28 Tennessee
The last merge request works on my local, could It be a timeout issue with the functional PHP unit test, on drupal ci?
- Open on Drupal.org →Core: 10.2.x + Environment: PHP 8.1 & MySQL 5.7last update
9 months ago Not currently mergeable. - Open on Drupal.org →Core: 10.2.x + Environment: PHP 8.1 & MySQL 5.7last update
9 months ago Not currently mergeable. - Open on Drupal.org →Core: 10.2.x + Environment: PHP 8.1 & MySQL 5.7last update
9 months ago Not currently mergeable. - 🇺🇸United States chrisfromredfin Portland, Maine
If you compare the DrupalCI test fails and the GitLab CI test fails, are they the same? (Might need to rebase to get DrupalCI to fail. If they're different, then it's just flakiness all around... :( )
- Merge request !441Updates markup in multiple commits to avoid CI issues. → (Open) created by bernardm28
- last update
9 months ago Custom Commands Failed - last update
9 months ago Custom Commands Failed - 🇺🇸United States bernardm28 Tennessee
They were not the same last time I checked.
- Open on Drupal.org →Core: 10.2.x + Environment: PHP 8.1 & MySQL 5.7last update
9 months ago Not currently mergeable. - Open on Drupal.org →Core: 10.2.x + Environment: PHP 8.1 & MySQL 5.7last update
9 months ago Not currently mergeable. - last update
9 months ago Custom Commands Failed - last update
9 months ago Custom Commands Failed - last update
9 months ago Custom Commands Failed - 🇮🇳India ehsann_95
ahsannazir → made their first commit to this issue’s fork.
- last update
9 months ago Custom Commands Failed - last update
9 months ago Custom Commands Failed - Status changed to Needs review
8 months ago 1:55pm 5 March 2024 - Open on Drupal.org →Core: 10.2.x + Environment: PHP 8.1 & MySQL 5.7last update
8 months ago Not currently mergeable. - last update
8 months ago Custom Commands Failed - last update
8 months ago Custom Commands Failed - last update
8 months ago Custom Commands Failed - last update
8 months ago Custom Commands Failed - last update
8 months ago Custom Commands Failed - last update
8 months ago Custom Commands Failed - last update
8 months ago Custom Commands Failed - last update
8 months ago Custom Commands Failed - last update
8 months ago Custom Commands Failed - last update
8 months ago Custom Commands Failed - last update
8 months ago Custom Commands Failed - last update
8 months ago Custom Commands Failed - 🇺🇸United States bernardm28 Tennessee
bernardm28 → changed the visibility of the branch 3365435-update-markup-classnames to hidden.
- 🇺🇸United States bernardm28 Tennessee
bernardm28 → changed the visibility of the branch 3365435-update-markup-classnames-rebased-test to hidden.
- Status changed to RTBC
8 months ago 10:11pm 22 March 2024 - 🇺🇸United States mike.roman Chicago
I reviewed the module and noticed no styling regressions as a result of all the class name changes.
- 🇺🇸United States bernardm28 Tennessee
I spent some time looking at it today, I did not notice any visual regression.
Also, I added the FLDC2024 tag as I started working on this for Florida drupal camp contribution day. - Open on Drupal.org →Core: 10.2.x + Environment: PHP 8.1 & MySQL 5.7last update
8 months ago Waiting for branch to pass - Open on Drupal.org →Core: 10.2.x + Environment: PHP 8.1 & MySQL 5.7last update
8 months ago Waiting for branch to pass -
chrisfromredfin →
committed bd9064d0 on 1.0.x authored by
bernardm28 →
Issue #3365435 by andy-blum, bernardm28, chrisfromredfin, mike.roman:...
-
chrisfromredfin →
committed bd9064d0 on 1.0.x authored by
bernardm28 →
- Status changed to Fixed
8 months ago 6:05pm 26 March 2024 - 🇺🇸United States chrisfromredfin Portland, Maine
Marking this fixed, because there IS a test failure, but it is failing on HEAD also--a result of us chasing HEAD on automatic_updates (package_manager).
And this is a big-bad, and getting it in means we can rebase and move forward on a number of smaller issues.
There was 1 failure: 1) Drupal\Tests\project_browser\FunctionalJavascript\ProjectBrowserInstallerUiTest::testInstallModuleAlreadyInFilesystem Failed asserting that a NULL is not empty. /builds/project/project_browser/vendor/phpunit/phpunit/src/Framework/Constraint/Constraint.php:122 /builds/project/project_browser/vendor/phpunit/phpunit/src/Framework/Constraint/Constraint.php:56 /builds/project/project_browser/tests/src/FunctionalJavascript/ProjectBrowserInstallerUiTest.php:106 /builds/project/project_browser/vendor/phpunit/phpunit/src/Framework/TestResult.php:729 FAILURES! Tests: 5, Assertions: 48, Failures: 1.
Automatically closed - issue fixed for 2 weeks with no activity.