- First commit to issue fork.
- Status changed to Needs review
over 1 year ago 4:25pm 24 March 2023 - 🇺🇸United States brianbrarian
Should the instructions refer to "the modules page" when both the admin menu label and h1 heading for the page say "Extend"? I suggest making the instructions consistent with the wording of the UI.
- Status changed to Needs work
over 1 year ago 4:44am 29 April 2023 - 🇺🇸United States mike.roman Chicago
I agree with brianbrarian, so I am going to set this issue to "needs work". The wording in the issue fork is set in
sveltejs/src/popup.js
line 60, and it is currently:To use the module you next have to install it on the modules page.
Borrowing heavily from the Installing Modules documentation page → , may I suggest:
Go to the Extend page (admin/modules), check the box next to each module you wish to enable, then click the Install button at the bottom of the page.
And be sure to link "Extend" (or "Extend page") to that page.
- 🇺🇸United States chrisfromredfin Portland, Maine
I agree with Mike.Roman's analysis; this would be the preferred wording.
- Assigned to sourabhjain
- last update
over 1 year ago Custom Commands Failed - Issue was unassigned.
- Status changed to Needs review
over 1 year ago 1:10pm 15 May 2023 - Open on Drupal.org →Core: 10.1.x + Environment: PHP 8.1 & MySQL 5.7last update
over 1 year ago Not currently mergeable. - last update
over 1 year ago CI aborted - last update
over 1 year ago 44 pass, 1 fail - Assigned to chrisfromredfin
- Status changed to Needs work
over 1 year ago 3:42pm 8 June 2023 - last update
over 1 year ago 44 pass, 1 fail - last update
over 1 year ago 65 pass - Status changed to Needs review
over 1 year ago 4:46pm 8 June 2023 - 🇺🇸United States chrisfromredfin Portland, Maine
I have rebased, fixed, and made the popup work again. I've also added a test for the third area we added. Needs review!
- Issue was unassigned.
- Open on Drupal.org →Core: 10.1.x + Environment: PHP 8.1 & MySQL 5.7
58:19 58:19 Queueing - last update
over 1 year ago Custom Commands Failed - Status changed to RTBC
over 1 year ago 5:26pm 21 July 2023 - 🇺🇸United States bronzehedwick New York
I tested that the first sentence in the "Show commands" modal's "1. Download" section's language changed to "The recommended way to download any Drupal module is with Composer.", with "recommended way" linked to https://www.drupal.org/docs/develop/using-composer/using-composer-to-ins... → .
I tested that the first sentence in the above modal's "2. Install" section changed to "Go to the Extend page (admin/modules), check the box next to each module you wish to enable, then click the Install button at the bottom of the page." With "Extend page" linked to https://drupal-project-browser.ddev.site/admin/modules.
Looks good to me, RBTC.
- Open on Drupal.org →Core: 10.1.x + Environment: PHP 8.1 & MySQL 5.7last update
over 1 year ago Not currently mergeable. - Open on Drupal.org →Core: 10.1.x + Environment: PHP 8.1 & MySQL 5.7last update
over 1 year ago Not currently mergeable. - last update
over 1 year ago Custom Commands Failed - last update
over 1 year ago 80 pass - last update
over 1 year ago 80 pass -
chrisfromredfin →
committed c84083a6 on 1.0.x authored by
srishtiiee →
Issue #3315853 by chrisfromredfin, srishtiiee, bnjmnm, narendraR,...
-
chrisfromredfin →
committed c84083a6 on 1.0.x authored by
srishtiiee →
- Status changed to Fixed
over 1 year ago 7:50pm 21 July 2023 Automatically closed - issue fixed for 2 weeks with no activity.