[PP-1] \Drupal\automatic_updates\Validation\StatusCheckRequirements makes admin/reports/status 10x slower!

In 📌 Add new setting for how unattended updates will be run Fixed we will probably change to only showing the cached results on the status report page. So then this would not affect the page load

Once that issue is fixed can re-open this issue to test if it is still a problem. I think it will not be and we can just close the issue.

👍

actually 📌 Add new setting for how unattended updates will be run Fixed is very big so lets just do this after that issue is done.

Blocker is in.

omkar.podey → made their first commit to this issue’s fork.

running a kernel test gives me

total time package_manager.validator.environment_support =>>> 0.00011515617370605
total time package_manager.validator.composer =>>> 0.47905015945435
total time package_manager.validator.disk_space =>>> 0.00065398216247559
total time package_manager.validator.file_system =>>> 0.0002140998840332
total time package_manager.validator.multisite =>>> 8.9883804321289E-5
total time package_manager.validator.symlink =>>> 0.013756036758423
total time package_manager.validator.stage_not_in_active =>>> 0.00015902519226074
total time package_manager.validator.base_requirements_fulfilled =>>> 0.00034904479980469
total time package_manager.validator.pending_updates =>>> 0.17668294906616
total time package_manager.validator.lock_file =>>> 0.00026702880859375
total time package_manager.validator.allowed_scaffold_packages =>>> 0.28983497619629
total time package_manager.validator.staged_database_updates =>>> 0.00043702125549316
total time package_manager.validator.settings =>>> 9.8943710327148E-5
total time Drupal\package_manager\Validator\RsyncValidator =>>> 0.00078988075256348
total time package_manager.validator.composer_plugins =>>> 0.24100685119629
total time package_manager.validator.patches =>>> 0.4860999584198
total time package_manager.validator.php_extensions =>>> 0.00017690658569336
total time package_manager.validator.php_extensions =>>> 0.00015687942504883

the validators that stand out

1. package_manager.validator.composer
2. package_manager.validator.allowed_scaffold_packages
3. package_manager.validator.composer_plugins
4. package_manager.validator.patches

from a build test

total time package_manager.validator.environment_support =>>> 0.00042605400085449
total time package_manager.validator.composer =>>> 0.62173891067505
total time package_manager.validator.disk_space =>>> 0.00076508522033691
total time package_manager.validator.file_system =>>> 0.00023698806762695
total time package_manager.validator.multisite =>>> 0.00013208389282227
total time package_manager.validator.symlink =>>> 4.5157771110535
total time package_manager.validator.stage_not_in_active =>>> 0.00046586990356445
total time package_manager.validator.base_requirements_fulfilled =>>> 0.00059890747070312
total time automatic_updates.cron_frequency_validator =>>> 0.00032591819763184
total time Drupal\automatic_updates\Validator\AutomatedCronDisabledValidator =>>> 0.0001530647277832
total time automatic_updates.validator.version_policy =>>> 0.7344229221344
total time automatic_updates.validator.cron_server =>>> 9.5844268798828E-5
total time package_manager.validator.pending_updates =>>> 0.011720895767212
total time package_manager.validator.lock_file =>>> 0.00018596649169922
total time package_manager.validator.allowed_scaffold_packages =>>> 0.14549493789673
total time package_manager.validator.staged_database_updates =>>> 0.00029420852661133
total time package_manager.validator.settings =>>> 0.00016403198242188
total time Drupal\package_manager\Validator\RsyncValidator =>>> 0.00024795532226562
total time package_manager.validator.composer_plugins =>>> 0.30691409111023
total time package_manager.validator.patches =>>> 0.63482904434204
total time package_manager.validator.php_extensions =>>> 0.00059890747070312
total time package_manager.validator.php_extensions =>>> 0.00015783309936523

1. the validators that stand out
2. package_manager.validator.composer
3. package_manager.validator.symlink
4. automatic_updates.validator.version_policy
5. package_manager.validator.composer_plugins
6. package_manager.validator.patches

Crediting Omkar for the profiling.

the code i used to get results by modifying \Drupal\Component\EventDispatcher\ContainerAwareEventDispatcher::dispatch

          if ($event_name == StatusCheckEvent::class) {
            if (array_key_exists('service', $definition)) {
              $name = $definition['service'][0];
              $time = microtime(TRUE);
              file_put_contents('/Users/omkar.podey/www/auto_updates_dev/sites/test.txt', "total time $name =>>> ", FILE_APPEND);
            }
          }
          call_user_func($definition['callable'], $event, $event_name, $this);
          if ($event_name == StatusCheckEvent::class) {
            if (array_key_exists('service', $definition)) {
              file_put_contents('/Users/omkar.podey/www/auto_updates_dev/sites/test.txt', microtime(TRUE) - $time . "\n", FILE_APPEND);
            }
          }

I pushed a start. We will need tests.

I think we should the profiling but in any case I don't think we should run the status checks unless they click the link.

In most cases there should be some results. If not then it probably means they don't have cron or the console command running often enough

@omkar.podey GREAT work on #8 & #9! 👏 🤩

If not then it probably means they don't have cron or the console command running often enough

Great point, @tedbow! 👍 Agreed.

99% done. Just one @todo that needs to be addressed.

I can't login into drupal code the @todo

 // @todo Link to the documentation on how to set up unattended updates
          //   via the terminal in https://drupal.org/i/3362695.

I don't think there is a point unless we have documentation and right now we don't. 📌 Create documentation for using the auto-update terminal command Active

#18: that is not the @todo I commented on. I commented on the other one:

// @todo Do better text.

Looking good! Needs Work for MR comments

Still fails as the status can't be fetched The project 'drupal' can not be updated because its status is not-fetched

Since the cron updates implementation will change significantly in 📌 For web server dependent unattended updates run the entire life cycle in a separate process that will not be affected by hosting time limits Fixed