- Issue created by @tedbow
- First commit to issue fork.
- last update
over 1 year ago 772 pass, 8 fail - @phenaproxima opened merge request.
- πΊπΈUnited States tedbow Ithaca, NY, USA
Updated the summary to use "background" instead of "webrequest"
- last update
over 1 year ago 775 pass, 8 fail - last update
over 1 year ago 782 pass, 2 fail - last update
over 1 year ago 788 pass - πΊπΈUnited States phenaproxima Massachusetts
\Drupal\automatic_updates\Validation\StatusChecker::run needs to be updated to run set the stage to the correct Drush stage or Cron stage or UpdateStage
This is not something we can do, because DrushUpdateStage only exists when running Drush (that's where the service is defined). I think it's okay if it stays the way it is -- the point is that it's checking for an unattended update, and CronUpdateStage fulfills that criterion.
- last update
over 1 year ago 773 pass, 2 fail - last update
over 1 year ago 789 pass - last update
over 1 year ago Custom Commands Failed - last update
over 1 year ago 524 pass, 78 fail - last update
over 1 year ago Custom Commands Failed - last update
over 1 year ago 788 pass, 1 fail - last update
over 1 year ago 789 pass - last update
over 1 year ago 789 pass - last update
over 1 year ago 789 pass - last update
over 1 year ago 789 pass - Assigned to tedbow
- Status changed to Needs review
over 1 year ago 3:22pm 12 May 2023 - Status changed to Needs work
over 1 year ago 3:52pm 12 May 2023 - πΊπΈUnited States tedbow Ithaca, NY, USA
Looking good. left some comments
- last update
over 1 year ago 789 pass - last update
over 1 year ago 789 pass - last update
over 1 year ago Custom Commands Failed - last update
over 1 year ago 789 pass - last update
over 1 year ago 789 pass - last update
over 1 year ago 789 pass - last update
over 1 year ago Custom Commands Failed - last update
over 1 year ago Custom Commands Failed - last update
over 1 year ago 789 pass - last update
over 1 year ago 789 pass - Status changed to Needs review
over 1 year ago 7:20pm 12 May 2023 - Assigned to phenaproxima
- Status changed to Needs work
over 1 year ago 7:28pm 12 May 2023 - πΊπΈUnited States tedbow Ithaca, NY, USA
@phenaproxima needs work. that change in CronHandler might affect the tests so not looking at them now
- last update
over 1 year ago 707 pass, 8 fail - last update
over 1 year ago 713 pass, 6 fail - last update
over 1 year ago 713 pass, 6 fail - last update
over 1 year ago 789 pass - Assigned to tedbow
- Status changed to Needs review
over 1 year ago 4:29pm 14 May 2023 - π§πͺBelgium wim leers Ghent π§πͺπͺπΊ
Turns out @phenaproxima already tried enums, didn't work out. Ah well.
- last update
over 1 year ago 789 pass - Issue was unassigned.
- Status changed to Needs work
over 1 year ago 2:08pm 22 May 2023 - Assigned to phenaproxima
- last update
over 1 year ago Custom Commands Failed - last update
over 1 year ago Custom Commands Failed - last update
over 1 year ago 793 pass - Assigned to tedbow
- Status changed to Needs review
over 1 year ago 5:43pm 24 May 2023 - last update
over 1 year ago 793 pass - Status changed to RTBC
over 1 year ago 7:38am 25 May 2023 - π§πͺBelgium wim leers Ghent π§πͺπͺπΊ
Looks great! π
It's really good to see this getting done, because as became very explicitly clear at #3362143-20: Install rsync on DrupalCI and run build tests with it β and subsequent comments, we really need these checks to work reliably in all possible setups! π
- Assigned to phenaproxima
- Status changed to Needs work
over 1 year ago 1:51pm 25 May 2023 - πΊπΈUnited States tedbow Ithaca, NY, USA
Looks good just 1 problem. See MR comment
- last update
over 1 year ago 783 pass, 2 fail - last update
over 1 year ago 783 pass, 2 fail - last update
over 1 year ago 783 pass, 2 fail - last update
over 1 year ago 783 pass, 2 fail - Issue was unassigned.
- Status changed to RTBC
over 1 year ago 4:24pm 25 May 2023 - πΊπΈUnited States tedbow Ithaca, NY, USA
Looks good, if tests pass!!!!
- Status changed to Needs work
over 1 year ago 12:56pm 26 May 2023 - πΊπΈUnited States tedbow Ithaca, NY, USA
Needs work.
The new function test points out a problem. Probably caused by the fact that we run the status checks when install modules.
- πΊπΈUnited States tedbow Ithaca, NY, USA
We were going to do π For web cron updates run each stage life cycle phase in a different request Closed: won't fix first but now we have closed that issue favor trying π For web server dependent unattended updates run the entire life cycle in a separate process that will not be affected by hosting time limits Fixed but that will not before 3.0.x Alpha
So this issue needs to updated for changes in π To prevent conflict and performance problems with other code that runs during cron, decorate the cron service instead of implementing hook_cron Needs work
The 2 ways to run unattended updates
- drush cron tab
- Cron route. see π To prevent conflict and performance problems with other code that runs during cron, decorate the cron service instead of implementing hook_cron Needs work
- Open on Drupal.org βCore: 10.1.x + Environment: PHP 8.1 & MySQL 8last update
over 1 year ago Not currently mergeable. - last update
over 1 year ago 759 pass, 3 fail - last update
over 1 year ago 764 pass, 3 fail - last update
over 1 year ago 804 pass, 2 fail - last update
over 1 year ago 804 pass, 1 fail - last update
over 1 year ago Custom Commands Failed - last update
over 1 year ago 815 pass - last update
over 1 year ago 815 pass - πΊπΈUnited States tedbow Ithaca, NY, USA
This is looks very good!
I think 1 thing that is missing is that `
automatic_updates_cron()
` we should return early ifmethod === cli
this because this could be cron is being run by
drush cron
or another CLI method then running the status checks might get results that don't match when run byweb
and we don't want to cache those or email.\Drupal\automatic_updates\Commands\AutomaticUpdatesCommands::autoUpdate
already runs status checks so if they selectedcli
they cron should never need to be run by cronThis also will need a test
- last update
over 1 year ago 815 pass, 1 fail - last update
over 1 year ago 816 pass - Status changed to RTBC
over 1 year ago 6:03pm 2 June 2023 - πΊπΈUnited States tedbow Ithaca, NY, USA
Looks great! Thanks @phenaproxima
- last update
over 1 year ago 816 pass - last update
over 1 year ago 816 pass -
phenaproxima β
committed 83415837 on 3.0.x
Issue #3359727 by phenaproxima, tedbow: Add new setting for how...
-
phenaproxima β
committed 83415837 on 3.0.x
- Status changed to Fixed
over 1 year ago 6:28pm 2 June 2023 Automatically closed - issue fixed for 2 weeks with no activity.