- Issue created by @phenaproxima
- 🇺🇸United States tedbow Ithaca, NY, USA
If we do this issue do we really need the PreDestroy and PostDestroy events?
- 🇮🇳India omkar.podey
omkar.podey → made their first commit to this issue’s fork.
- last update
over 1 year ago Custom Commands Failed - @omkarpodey opened merge request.
- 🇮🇳India omkar.podey
Needs more info on how exactly this will work does the cron operation just search all instances of
DELETE_stage
in case of/private/tmp/package_manager_testing_roottest64053336/stage
the directory to be searched in is according to the site settings and just starts recursively deleting all things inside of it ? OR should we somehow tell the cron specifically what directory needs to be cleaned up. - 🇺🇸United States tedbow Ithaca, NY, USA
I did some simple benchmarking in 📌 In package_manager_test_event_logger also log the time to help benchmarking and debugging Needs work . It looks like deleting the directory does not take take much time compared to the other stages. 4 secs.
So the 4 seconds is better but not a huge improvement. I wonder if the bigger advantage would be removing the PreDestroy and PostDestory events. What would be use cases for using these vs PostApply.
- 🇺🇸United States phenaproxima Massachusetts
If we remove both of them, I'd be comfortable removing PreDestroyEvent and PostDestroyEvent. That would indeed be simpler, and I can't think of a case for them that can't be done in post-apply.
- last update
over 1 year ago 628 pass, 17 fail - 🇺🇸United States tedbow Ithaca, NY, USA
re #5
I think would just delete everything inside of\Drupal\package_manager\PathLocator::getStagingRoot
that starts withDELETE_
Won't the stage directories pile up if cron isn't run for a long time ? do we need to make this optional ?
Cron is expected to be run regularly or your site might not function correctlythough maybe with project browser I could many stage life cycles before cron is run.
Another option we could do is set a set state flag in
\Drupal\package_manager\StageBase::destroy
and then createStageCleanUp
service that subscribes to\Symfony\Component\HttpKernel\KernelEvents::TERMINATE
and checks the flag and then deletes any "DELETE_" directories - last update
about 1 year ago 734 pass, 2 fail - last update
about 1 year ago Custom Commands Failed - last update
about 1 year ago Custom Commands Failed - last update
about 1 year ago 601 pass, 57 fail - last update
about 1 year ago 601 pass, 57 fail - last update
about 1 year ago 776 pass - Status changed to Needs work
about 1 year ago 3:08pm 25 August 2023 - 🇺🇸United States tedbow Ithaca, NY, USA
Looking good. Needs work for MR comments
- last update
about 1 year ago Custom Commands Failed - last update
about 1 year ago Custom Commands Failed - last update
about 1 year ago Custom Commands Failed - last update
about 1 year ago Custom Commands Failed - last update
about 1 year ago 777 pass - last update
about 1 year ago 777 pass - Status changed to Needs review
about 1 year ago 5:35pm 25 August 2023 - last update
about 1 year ago 777 pass - last update
about 1 year ago 777 pass - last update
about 1 year ago 770 pass, 2 fail - last update
about 1 year ago 770 pass, 2 fail - Open on Drupal.org →Core: 10.1.x + Environment: PHP 8.1 & MySQL 8last update
about 1 year ago Not currently mergeable. - last update
about 1 year ago 777 pass - last update
about 1 year ago Custom Commands Failed - last update
about 1 year ago 736 pass, 1 fail - last update
about 1 year ago 770 pass - Assigned to tedbow
- Assigned to phenaproxima
- Status changed to Needs work
about 1 year ago 8:07pm 13 October 2023 - 🇺🇸United States tedbow Ithaca, NY, USA
Looking good. Just a couple small things
- Assigned to tedbow
- Status changed to Needs review
about 1 year ago 2:48am 14 October 2023 - last update
about 1 year ago 770 pass - Assigned to phenaproxima
- Status changed to Needs work
about 1 year ago 3:03pm 17 October 2023 - Open on Drupal.org →Core: 10.1.x + Environment: PHP 8.1 & MySQL 8last update
about 1 year ago Not currently mergeable. - Assigned to tedbow
- Status changed to Needs review
about 1 year ago 3:05pm 17 October 2023 - Status changed to RTBC
about 1 year ago 3:06pm 17 October 2023 - 🇺🇸United States tedbow Ithaca, NY, USA
looks good.
Looks like 3.0.x needs to be merged in again but otherwise should be good if tests pass again
- last update
about 1 year ago 770 pass - last update
about 1 year ago 770 pass - last update
about 1 year ago 770 pass - last update
about 1 year ago 770 pass -
phenaproxima →
committed b2f42080 on 3.0.x authored by
omkar.podey →
Issue #3364958 by phenaproxima, omkar.podey, tedbow: Stage directories...
-
phenaproxima →
committed b2f42080 on 3.0.x authored by
omkar.podey →
- Issue was unassigned.
- Status changed to Fixed
about 1 year ago 3:59pm 17 October 2023 Automatically closed - issue fixed for 2 weeks with no activity.