In package_manager_test_event_logger also log the time to help benchmarking and debugging

Created on 16 August 2023, 11 months ago
Updated 6 December 2023, 7 months ago

Problem/Motivation

Looking at ✨ Stage directories should be deleted in the background, during cron runs Fixed I wanted to figure out how long the destroying the stage directory actually takes.

I was going to add some debugging output lines. But then I realized in \Drupal\package_manager_test_event_logger\EventSubscriber\EventLogSubscriber::logEventInfo actually would a good place to always log the time for debugging purposes.

Proposed resolution

  1. In \Drupal\package_manager_test_event_logger\EventSubscriber\EventLogSubscriber::logEventInfo also log the time
  2. use JSON_PRETTY_PRINT so that it will be very easy to read the file without reformatting.
  3. Change file name to end with .json so when open the file for debugging the OS will pick the default app for json files

These 3 things won't be needed in the test but also will not affect the tests. It will make it easier to do casual benchmarking in the future.

Remaining tasks

User interface changes

API changes

Data model changes

πŸ“Œ Task
Status

Needs work

Version

3.0

Component

Package Manager

Created by

πŸ‡ΊπŸ‡ΈUnited States tedbow Ithaca, NY, USA

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

Production build 0.69.0 2024