Document that StageFixtureManipulator should not be used in build tests

Created on 1 February 2023, almost 2 years ago
Updated 7 July 2023, over 1 year ago

Problem/Motivation

follow-up to πŸ“Œ Remove all fixtures except for one: `fake_site` Fixed

@wim leers mentioned

β‡’ this actually makes me realize that BuildTests should never use (Active|Stage)FixtureManipulator? πŸ€” Because doing so means we're no longer testing php-tuf/composer-stager

I think it is true that `ActiveFixtureManipulator` and `StageFixtureManipulator` should not be used in build tests.

But I could see that generic FixtureManipulator could be used as way to set up a test case especially if we test cases where there are modules present at the start that are not managed by composer or if we want to test a set up where there Composer meta that said package is present but it actually wasn't present in the file system

Steps to reproduce

Proposed resolution

Remaining tasks

Determined what should documented

User interface changes

API changes

Data model changes

πŸ› Bug report
Status

Active

Version

3.0

Component

Code

Created by

πŸ‡ΊπŸ‡ΈUnited States tedbow Ithaca, NY, USA

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

  • Issue created by @tedbow
  • πŸ‡ΊπŸ‡ΈUnited States tedbow Ithaca, NY, USA

    I don't we need to work on this now since our focus is core-mvp issues

  • πŸ‡ΊπŸ‡ΈUnited States tedbow Ithaca, NY, USA
  • πŸ‡§πŸ‡ͺBelgium wim leers Ghent πŸ‡§πŸ‡ͺπŸ‡ͺπŸ‡Ί

    I just tried to switch \Drupal\Tests\package_manager\Build\PackageInstallTest to use (Active)FixtureManipulator but failed because it started using \Drupal::service() … which is not available in a build test. So I think the point is pretty much moot here? πŸ˜…

    Although … I think it would totally be possible at this point, and that'd allow us to remove the last on-disk fixtures πŸ˜‡

  • Assigned to tedbow
  • πŸ‡ΊπŸ‡ΈUnited States tedbow Ithaca, NY, USA

    Assigning to myself to see if we can close this.

    Also have to decide if we can't if it should be added back to the roadmap

Production build 0.71.5 2024